Re: [dpdk-dev] [PATCH v5 20/23] net/atlantic: support for VLAN filters and offloads

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 10/11/2018 11:35 AM, Igor Russkikh wrote:
> From: Pavel Belous <Pavel.Belous@aquantia.com>
> 
> VLAN filters and VLAN offloads implementation.
> 
> Signed-off-by: Igor Russkikh <igor.russkikh@aquantia.com>
> Signed-off-by: Pavel Belous <Pavel.Belous@aquantia.com>
> ---
>  doc/guides/nics/features/atlantic.ini |   2 +
>  drivers/net/atlantic/atl_ethdev.c     | 159 ++++++++++++++++++++++++++++++++++
>  drivers/net/atlantic/atl_types.h      |   2 +
>  3 files changed, 163 insertions(+)
> 
> diff --git a/doc/guides/nics/features/atlantic.ini b/doc/guides/nics/features/atlantic.ini
> index cfd6ca6a1323..f9aec42d9345 100644
> --- a/doc/guides/nics/features/atlantic.ini
> +++ b/doc/guides/nics/features/atlantic.ini
> @@ -16,8 +16,10 @@ Unicast MAC filter   = Y
>  RSS hash             = Y
>  RSS key update       = Y
>  RSS reta update      = Y
> +VLAN filter          = Y
>  Flow control         = Y
>  CRC offload          = Y
> +VLAN offload         = Y

If VLAN offload is enable, in Rx side mbuf->ol_flags should have PKT_RX_VLAN to
say mbuf->vlan_tci is valid.
And if vlan tag stripped from packet, mbuf->ol_flags should have
PKT_RX_VLAN_STRIPPED too.

I don't see these flags has been set in datapath, you can add it in this patch.