From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C7B14A00C2; Fri, 11 Feb 2022 20:58:03 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A276840683; Fri, 11 Feb 2022 20:58:03 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id EA73440140 for ; Fri, 11 Feb 2022 20:58:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644609482; x=1676145482; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=ZRZAd2Zt/uTqzD5guNwt3TVgd775qvyfYKUyD689QEY=; b=B2EDebhcwMFEqbO7R0o/8iMR7KYY9GG+BGcKxP99zrfCB3LuNeBnHL9A zVFqS5SDM0sDGOgz4asm6mUhI6CyFGM9DCZcRrkxJJlDsdRkt4SFjRg0k l/5ndepJ3d9WoLX8zAFJFDtJtslxPjdu5dvvJqeRAD17AV/KCB6DUE/mM fOSctZWx3+3WJd8QxexMRK0Kln259VGVpeF1wltEcpK/7UD75/OEwpGqR +e7Gxe0NK6mkG6bjaNDkVCkV1onUfiUunKjFBA5J1/agzv0Ln4rsqzAc5 0w573Avz/Xv7CFb3lbLhggGptir/zQaXt5lT4gCOmJPYXiOYihINpCmHa A==; X-IronPort-AV: E=McAfee;i="6200,9189,10255"; a="250006447" X-IronPort-AV: E=Sophos;i="5.88,361,1635231600"; d="scan'208";a="250006447" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Feb 2022 11:58:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,361,1635231600"; d="scan'208";a="537739364" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga007.fm.intel.com with ESMTP; 11 Feb 2022 11:58:00 -0800 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Fri, 11 Feb 2022 11:58:00 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Fri, 11 Feb 2022 11:58:00 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Fri, 11 Feb 2022 11:58:00 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.170) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Fri, 11 Feb 2022 11:57:59 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kUNKVgl/uuRXgVkaBM0KbZkA6uen3GKo961hxxYs6+v4YUiTlTnR5auSxrKPJgZbTwJM9moD+aE3YJeaA3u2hnWY01E2L4TUB1jfErhovhnaBXl5F/7zboZnZen4vlCSbWua4x1bnCfEgrjX4A/tgxzTVcqqVqVkfC65e0z+0VjxTVt//wAzSm9RMta5bqZ1ZFQHlIXjMeIIigyNHTAmTkd/bG+ouPKBSeVp5Fnb8M5HiSR+8m/j2EraPo0iRqhOlO1AfP6vzssv3mBucOIQljQdpbN5g8jGGYUKFiqF79fSb9XvWCyc76JYgvVYOT2QRM771/dYXUeGalXFx6iDTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=turxTm6U27sE9ERXV928IpxOrgiXRG9qIWiExxdZMps=; b=hiN7n8lME+xwXeZY0KjlnsqJz6A0cBjo29+osnZ394igjIZ2VHwJmM378vM2PQzYfOxeQPanHYQr7MRSrCSztPtVQIrPGOqQhIMNlsJUd/phGFoVygA8EFS8QPbT/M/nDimzgF3yAFIOrNaNX7169AR235uY/k2BycjPL8VxGmgu/Sn96gRFSgvmB+JjFa7Hi/XnfHMuB4e0LbQRotYhtRLI9AVp3O9HLPw5sNeC7Bw1J9aB5Gi6VEsKUTksw4svUplJtuV0S8mdanRwqj5D+pjRZtZitdr+osTcOaDwZiPi/01gH2rCDcdI9p9F/V68O4G4DwgHT6V0kOUC6xdszg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by CY4PR1101MB2117.namprd11.prod.outlook.com (2603:10b6:910:17::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Fri, 11 Feb 2022 19:57:56 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2%4]) with mapi id 15.20.4975.011; Fri, 11 Feb 2022 19:57:56 +0000 Message-ID: <0095ff1d-4bfa-02da-2d59-f8bdb2e43bb0@intel.com> Date: Fri, 11 Feb 2022 19:57:50 +0000 Subject: Re: [PATCH v2 7/8] net/ring: add promisc and all-MC stubs Content-Language: en-US To: Bruce Richardson CC: Robert Sanford , , , References: <1639592401-56845-2-git-send-email-rsanford@akamai.com> <1640116650-3475-1-git-send-email-rsanford@akamai.com> <1640116650-3475-8-git-send-email-rsanford@akamai.com> <532bfd7f-34ff-620f-8a9a-487864d40754@intel.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0219.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a6::8) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 387f5be6-58bc-4b89-ca47-08d9ed98cba2 X-MS-TrafficTypeDiagnostic: CY4PR1101MB2117:EE_ X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: G4q+U4K9RmdZEdYAfKlBDK6Uq+w6vMtvWd3sDqZ7l/xYcyE6QSttPkG/X7oB9P5GWsKe66v6iXge5mvTZhiLqsQp1CmSd3gqA389BMIzIlupF4uJ5KpqGsqS2NiaHTigzbjsbrC8hWIWSNLRBMLLqvGgOUd7aCMFhd2kgAW/JlumLpnXKBll6htT9LlUtUjKfRhHPa4aIY/sMbzFKnWiCL1gt3mXmOmnQXeJtHhPzSrwuJw4EHjc3IeAvgWcFVnHT33Jo5JcPATcVv1jMak0ruQRGCDQ/9Q+VmU/uC+ASosfIV58YA+uyY0uHFBrXNOwx965OOhGUfx38/cTXU4i8zDFiXBd31BO23PXehASUHpNKJEqkuaDR+4pjOdavDTS6/UDXzu80agBO1ZkzF1UFXVtACprvC9vX+BsPQSLF/LgwL+xTA61RncTsr73B1y7OqvpAMOBWcQMyjozv+nuqL/MRFUvxvG4NgsT+TUX8MXwIV5a8lyVf+Vx0kcnq5nzRIdEmggna46tMHvoVxX6L0VQ1syOel7bUSX93w8YMqjafic4jwjqY7Emp1X1pCdpNk4tbxdxM4vj2em1UJ7EnAn9eU3NbjAjoHCKsAxznX3UIrdk9GfC3QXX1x2Ae2YbkSDS6V3UFK/HrTdYb8KM8TuGT0CW+E0+1XibTxZ27r5fE25hStPD3YHIfsnwGDa1RXjop6mhMdcOhIj7VO0bBw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(8936002)(44832011)(66556008)(5660300002)(4326008)(36756003)(38100700002)(2906002)(66476007)(8676002)(66946007)(31686004)(82960400001)(6862004)(83380400001)(6486002)(37006003)(316002)(508600001)(55236004)(53546011)(6666004)(6506007)(31696002)(6512007)(86362001)(6636002)(186003)(2616005)(26005)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?am9TTGEwbFU1ZmFZTW5SeStlYlFQUXg2NFdZcS91YTVSVDhRTVlvVmZNQWhj?= =?utf-8?B?VmF2U0tLTTQrYU03Z01NRCtYVTg3d2JRb1AxSW1qNEZFSW9TazA5amRQUnRH?= =?utf-8?B?VjFwdG5RbGdjWkNpbjczakFuYjl1aFAwYjdyTzVMaDBsdjdnVEFkdDVTR2N5?= =?utf-8?B?S2RxdFg4bEd6aGZoQ1l1OXpsZlpkMlllbWdEcFVCK1VUSDJ6bExvVElaMjNh?= =?utf-8?B?TWdGdnppWXUwZGpWUzNPQVRjakxBZlJDdlR0MXF6ak82RHRWSmtVbnZPeGds?= =?utf-8?B?cGorQVdFYzVydE9ZSDRXYlRaSHlJMnhkTEpzY0tBK2cwZzdYemF5aWtyRTZ0?= =?utf-8?B?VmczdUpBZ1pMM3VJUFhFeGN1ckU0R3NmS0E0SmQ1cUF2R3lpd2U2Z2FEb1hn?= =?utf-8?B?Y1JXNE5DRGRsRDRWc3pGNjJGa3BwUURrZlA3MW8yN2VVU1JHUHNWb1pCN1Fi?= =?utf-8?B?V21VTERhS2t3Z2pSbGFYaUY3aDZQTmFNYTlBeTRoNVBudzVrS1ZkTnFnS3Nu?= =?utf-8?B?UDZta2RUbSsrYVJDYWp4bHljcWxKNmh6U3FyeUZ1KytnQVFmS01mUzZjNzBq?= =?utf-8?B?YmxiUXBhSmlaZWhtR3kwUFlSRlgvNzFaeXJHMjBYUTZEbGo1aHZaMlkrOVlp?= =?utf-8?B?Z0ZFY2VTMXFrKy95bS9obHFMdW1wYm5WL3NhUnNhSWRITlVDT2FjQnFJYkNj?= =?utf-8?B?NDNTNktNdWIyUzZEM1NKeE9rUm56eXk5aStseVROVklGaitvNTE4WDl6c0xz?= =?utf-8?B?NDhvWCswdXFVMElPRXh6RzY1Z0xRMER3OGQzT1RVU1VYUWFzZDAwWEFqTkhO?= =?utf-8?B?NkF4U1pldENCajl6bTJGSXdDNnkzem0wc0FrSGovWlJFb1JFclpxQ0czbDJi?= =?utf-8?B?cEhiOUY2bFNkbnM4TmhmNWE4TVEvb25YZThqQkRCOWFQRGRLbkZHaFE4ZERO?= =?utf-8?B?cEtXOHNlUXkweGdYSEVxMFBKb0dldXY4QzRFa2hmS2NnalJmSUdvS243dmFK?= =?utf-8?B?YW5CN25UUlRsTDNqMlFCUTVCNzdjRGpzaUU4TFJVWUoxMmVLU1J4ZFE1SkRP?= =?utf-8?B?dGRpVFdiS3R0UHpXTTNTWkhsdTF3MzV3eXNMV2VNM0d0Y3dVRlZGa3Q3Ri9G?= =?utf-8?B?K29PUVNPVGNOQ09odDJHd1dydjkzazR4SnlKZDd3cGx5ditkaFhuRlZUUktT?= =?utf-8?B?Q3FwMWZobXRoSUVwZ2d5V0ZXWEJLWUJmTlpOZDlNZUtpYTY1SEt4ekZXRWpT?= =?utf-8?B?cWdGNk1GMDIwS2RRZ2EwVHU4Q0M3UDVmUi9uQXZTZEhFSlZKOGFLaWxaRGRv?= =?utf-8?B?SzVwaVJ2cWVtSlBkbUVuUCswUllTbW51TlN4T1VwSzFQQWRkNVlhMGVxSHhs?= =?utf-8?B?MUJGWGJhQ3MydEplcWpYUUROTDF2bG5pZWpueDJoU0tGYzdHRGdobWtBRjVm?= =?utf-8?B?NDcyeU9sS3k1WmNNaVZIVXVKV1ZsbXdyZGlITDNvQVdVdVJZZUxSQU5pQlZz?= =?utf-8?B?bWE5YW5vUXR2M0VMZVM4M0lncnVoMTg4SWlPZUpXbUpnTk90dkQ0b3dzcDJn?= =?utf-8?B?ZndxK2tBY0tnSXRKWGErM0JEc3k3U2gwQjN5L3ZuZVdiNVBsdWhXSDZvbnky?= =?utf-8?B?OGorYkJGTExjMXp5ZkNnT0RTaHdnUnU1elJONUlOYjVENDdBZDY1bFArS3Bx?= =?utf-8?B?ZnYzMzZLbGVPd0RscWRLdjBERGZweG4xbUVDdGxNRUp3dTFqTko1ekNhSGRj?= =?utf-8?B?ekgyNW5lSGhqY2NCbVJ6SjBNR2RuOFdxVWdKb2dpWm5Nd0RyTHJNOXRMbkYr?= =?utf-8?B?Qzlobks1Q1Q3emFLK2s5YWlsWmlWU1Z6R2ZwZHpXMXpQd1lyV25qSnZvcG5X?= =?utf-8?B?MkJoU3JxTGNvWHc2Rk5oRXVDZWZiSWw5d3dGM1krVng1SWxtRlhXdGFGVmRH?= =?utf-8?B?ckczTVFBSXBLbmNHb1M1QTczbXBBamJlUWlmUGZrM0ZEQm5EU0ZzNlpBRDI4?= =?utf-8?B?cUlYZWExVTZnRGpNZG4xVnNWKzBKNnhjcjQ5S3I3aFpyejhEdXlxMjhpSUpJ?= =?utf-8?B?UXNEQjNhaUoyakdBay9ZVEZCZUFFSGZhSHRBMWpBT1FwNVI2UDFsMVdvenBk?= =?utf-8?B?dWoydXh5Rkl2ZzB1aUpmbW9xT1RmeGQ3d253SWNIWDZhdG5idXRremVoNXVT?= =?utf-8?Q?lgxdzR0KqPtgOO0OnzNz1gA=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 387f5be6-58bc-4b89-ca47-08d9ed98cba2 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Feb 2022 19:57:56.3152 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NNNEEaprsz21W26NMWO/lCQ4u3Nnn8cB5eM1LN2kksT5xTgHXKjCLTGQrSDYTAfrYWPw5KKLtNqldOQ7DwcGfg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1101MB2117 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/4/2022 2:49 PM, Bruce Richardson wrote: > On Fri, Feb 04, 2022 at 02:36:47PM +0000, Ferruh Yigit wrote: >> On 12/21/2021 7:57 PM, Robert Sanford wrote: >>> Add promiscuous_enable, promiscuous_disable, allmulticast_enable, >>> and allmulticast_disable API stubs. >>> This helps clean up errors in dpdk-test link_bonding_mode4_autotest. >>> >>> Signed-off-by: Robert Sanford >>> --- >>> drivers/net/ring/rte_eth_ring.c | 28 ++++++++++++++++++++++++++++ >>> 1 file changed, 28 insertions(+) >>> >>> diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c >>> index db10f03..cfb81da 100644 >>> --- a/drivers/net/ring/rte_eth_ring.c >>> +++ b/drivers/net/ring/rte_eth_ring.c >>> @@ -226,6 +226,30 @@ eth_mac_addr_add(struct rte_eth_dev *dev __rte_unused, >>> } >>> static int >>> +eth_promiscuous_enable(struct rte_eth_dev *dev __rte_unused) >>> +{ >>> + return 0; >>> +} >>> + >>> +static int >>> +eth_promiscuous_disable(struct rte_eth_dev *dev __rte_unused) >>> +{ >>> + return 0; >>> +} >>> + >>> +static int >>> +eth_allmulticast_enable(struct rte_eth_dev *dev __rte_unused) >>> +{ >>> + return 0; >>> +} >>> + >>> +static int >>> +eth_allmulticast_disable(struct rte_eth_dev *dev __rte_unused) >>> +{ >>> + return 0; >>> +} >>> + >>> +static int >>> eth_link_update(struct rte_eth_dev *dev __rte_unused, >>> int wait_to_complete __rte_unused) { return 0; } >>> @@ -275,6 +299,10 @@ static const struct eth_dev_ops ops = { >>> .stats_reset = eth_stats_reset, >>> .mac_addr_remove = eth_mac_addr_remove, >>> .mac_addr_add = eth_mac_addr_add, >>> + .promiscuous_enable = eth_promiscuous_enable, >>> + .promiscuous_disable = eth_promiscuous_disable, >>> + .allmulticast_enable = eth_allmulticast_enable, >>> + .allmulticast_disable = eth_allmulticast_disable, >> >> not sure about adding dummy dev_ops to the driver for the unit test, >> what about updating 'link_bonding_mode4_autotest' accordingly? >> >> Bruce (net/ring maintainer), what do you think about dummy dev_ops? > > For something like ring PMD, I don't see an issue with it, since they don't > really have any meaning for a ring PMD, they might as well just return > success rather than having application code have to handle errors from > them. > > > Acked-by: Bruce Richardson Applied to dpdk-next-net/main, thanks.