From: Olivier Matz <olivier.matz@6wind.com>
To: "Mcnamara, John" <john.mcnamara@intel.com>,
"Zhao1, Wei" <wei.zhao1@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] lib/librte_mempool: a redundant of socket_id assignment
Date: Fri, 18 Nov 2016 15:07:47 +0100 [thread overview]
Message-ID: <009f3afb-beeb-9f9f-d786-f6d20c1217c5@6wind.com> (raw)
In-Reply-To: <B27915DBBA3421428155699D51E4CFE20264E206@IRSMSX103.ger.corp.intel.com>
Hi Wei,
On 11/14/2016 11:25 AM, Mcnamara, John wrote:
>
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wei Zhao
>> Sent: Monday, November 14, 2016 2:16 AM
>> To: dev@dpdk.org
>> Cc: olivier.matz@6wind.com; Zhao1, Wei <wei.zhao1@intel.com>
>> Subject: [dpdk-dev] [PATCH] lib/librte_mempool: a redundant of socket_id
>> assignment
>>
>> From: zhao wei <wei.zhao1@intel.com>
>>
>> There is a redundant repetition mempool socket_id assignment in the file
>> rte_mempool.c in function rte_mempool_create_empty.The statement "mp-
>>> socket_id = socket_id;"appear twice in line 821 and 824.One of them is
>> redundant, so delete it.
>>
>> Fixes: 85226f9c526b ("lib/librte_mempool: mempool:introduce a function to
>> create an empty pool")
>>
>> Signed-off-by: zhao wei <wei.zhao1@intel.com>
>
> Titles should generally start with a verb to indicate what is being done.
> Something like:
>
> lib/librte_mempool: remove redundant socket_id assignment
>
> Apart from that.
>
> Acked-by: John McNamara <john.mcnamara@intel.com>
I would even say:
mempool: remove redundant socket_id assignment
Acked-by: Olivier Matz <olivier.matz@6wind.com>
prev parent reply other threads:[~2016-11-18 14:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-14 2:15 Wei Zhao
2016-11-14 10:25 ` Mcnamara, John
2016-11-18 14:07 ` Olivier Matz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=009f3afb-beeb-9f9f-d786-f6d20c1217c5@6wind.com \
--to=olivier.matz@6wind.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=wei.zhao1@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).