From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8C230A0353; Wed, 13 Nov 2019 07:21:14 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8526037AF; Wed, 13 Nov 2019 07:21:13 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 6FE54374E for ; Wed, 13 Nov 2019 07:21:12 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Nov 2019 22:21:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,299,1569308400"; d="scan'208";a="207361202" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga003.jf.intel.com with ESMTP; 12 Nov 2019 22:21:11 -0800 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 12 Nov 2019 22:21:10 -0800 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 12 Nov 2019 22:21:10 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 12 Nov 2019 22:21:10 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.213]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.2]) with mapi id 14.03.0439.000; Wed, 13 Nov 2019 14:21:08 +0800 From: "Wang, ShougangX" To: "Yang, Qiming" , "dev@dpdk.org" CC: "Zhang, Qi Z" Thread-Topic: [PATCH v4 2/4] net/ice: fix removal of FDIR profile Thread-Index: AQHVmUFFWraBGGHF6kmpZr6P4KT+FqeG0YmAgAHQiMA= Date: Wed, 13 Nov 2019 06:21:08 +0000 Message-ID: <00A8E5A1740DFA49A87AFFAC34B8EDEA3C03C0@SHSMSX101.ccr.corp.intel.com> References: <20191105033806.2878-1-shougangx.wang@intel.com> <20191112035011.67537-1-shougangx.wang@intel.com> <20191112035011.67537-3-shougangx.wang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 2/4] net/ice: fix removal of FDIR profile X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Qiming > -----Original Message----- > From: Yang, Qiming > Sent: Tuesday, November 12, 2019 6:37 PM > To: Wang, ShougangX ; dev@dpdk.org > Cc: Zhang, Qi Z > Subject: RE: [PATCH v4 2/4] net/ice: fix removal of FDIR profile >=20 > Hi, >=20 > > -----Original Message----- > > From: Wang, ShougangX > > Sent: Tuesday, November 12, 2019 11:50 AM > > To: dev@dpdk.org > > Cc: Yang, Qiming ; Zhang, Qi Z > > ; Wang, ShougangX > > Subject: [PATCH v4 2/4] net/ice: fix removal of FDIR profile > > > > The removal of FDIR profile should start from the next of > > ICE_FLTR_PTYPE_NONF_NONE. > > > > Fixes: 109e8e06249e ("net/ice: configure HW flow director rule") > > > > Signed-off-by: Wang ShougangX > > --- > > drivers/net/ice/ice_fdir_filter.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/ice/ice_fdir_filter.c > > b/drivers/net/ice/ice_fdir_filter.c > > index a89c506c0..039e00a28 100644 > > --- a/drivers/net/ice/ice_fdir_filter.c > > +++ b/drivers/net/ice/ice_fdir_filter.c > > @@ -571,7 +571,7 @@ ice_fdir_prof_rm_all(struct ice_pf *pf) { > > enum ice_fltr_ptype ptype; > > > > - for (ptype =3D ICE_FLTR_PTYPE_NONF_NONE; > > + for (ptype =3D ICE_FLTR_PTYPE_NONF_NONE + 1; >=20 > I think we should also use ICE_FLTR_PTYPE_NONF_NONE + 1 instead of > ICE_FLTR_PTYPE_TCP_IPV4 in prof_add, To make sure it is symmetric. And it > should be contained in this patch. OK, I will replace them. >=20 > > ptype < ICE_FLTR_PTYPE_MAX; > > ptype++) { > > ice_fdir_prof_rm(pf, ptype, false); > > -- > > 2.17.1