From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.windriver.com (mail.windriver.com [147.11.1.11]) by dpdk.org (Postfix) with ESMTP id AD30F7E10 for ; Sun, 28 Sep 2014 16:31:02 +0200 (CEST) Received: from ALA-HCB.corp.ad.wrs.com (ala-hcb.corp.ad.wrs.com [147.11.189.41]) by mail.windriver.com (8.14.9/8.14.5) with ESMTP id s8SEbW8L009922 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Sun, 28 Sep 2014 07:37:33 -0700 (PDT) Received: from ALA-MBB.corp.ad.wrs.com ([169.254.1.18]) by ALA-HCB.corp.ad.wrs.com ([147.11.189.41]) with mapi id 14.03.0174.001; Sun, 28 Sep 2014 07:37:31 -0700 From: "Wiles, Roger Keith" To: Neil Horman Thread-Topic: [dpdk-dev] [PATCH v2] rte_mempool_dump() crashes with NULL rte_mempool pointer. Thread-Index: AQHP2t0S8e1ctlbauEatlaiZR/WDL5wW7qYAgAAkboA= Date: Sun, 28 Sep 2014 14:37:30 +0000 Message-ID: <00F93A0F-9269-4A12-907A-8AFA2E3BB502@windriver.com> References: <05E7C1C5-2730-4BE3-B808-6F69821F7898@windriver.com> <20140928122706.GB30445@localhost.localdomain> In-Reply-To: <20140928122706.GB30445@localhost.localdomain> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.25.40.166] Content-Type: text/plain; charset="us-ascii" Content-ID: <14EC9D4BF311BB4D97D7C038E0610EE5@local> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "" Subject: Re: [dpdk-dev] [PATCH v2] rte_mempool_dump() crashes with NULL rte_mempool pointer. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Sep 2014 14:31:03 -0000 On Sep 28, 2014, at 7:27 AM, Neil Horman wrote: > On Sun, Sep 28, 2014 at 05:28:44AM +0000, Wiles, Roger Keith wrote: >>=20 >> Check the FILE *f and rte_mempool *mp pointers for NULL and >> return plus print out a message if RTE_LIBRTE_MEMPOOL_DEBUG is enabled. >>=20 >> Signed-off-by: Keith Wiles >> --- >> lib/librte_mempool/rte_mempool.c | 3 +++ >> 1 file changed, 3 insertions(+) >>=20 >> diff --git a/lib/librte_mempool/rte_mempool.c b/lib/librte_mempool/rte_m= empool.c >> index 332f469..0f71f10 100644 >> --- a/lib/librte_mempool/rte_mempool.c >> +++ b/lib/librte_mempool/rte_mempool.c >> @@ -765,6 +765,9 @@ rte_mempool_dump(FILE *f, const struct rte_mempool *= mp) >> unsigned common_count; >> unsigned cache_count; >>=20 >> + RTE_VERIFY(f !=3D NULL); >> + RTE_VERIFY(mp !=3D NULL); >> + >> fprintf(f, "mempool <%s>@%p\n", mp->name, mp); >> fprintf(f, " flags=3D%x\n", mp->flags); >> fprintf(f, " ring=3D<%s>@%p\n", mp->ring->name, mp->ring); >> --=20 >> 2.1.0 >>=20 >> Keith Wiles, Principal Technologist with CTO office, Wind River mobile 9= 72-213-5533 >>=20 >>=20 >=20 > I'm fine with this, as I think passing in a NULL mempool is clearly a bug= here, > thats worth panicing over, though I wouldnt mind if we did a RTE_VERIFY_W= ARN > macro here instead using what I suggested in my other note > Neil Maybe I can add RTE_VERIFY_WARN() later or someone else can. >=20 Keith Wiles, Principal Technologist with CTO office, Wind River mobile 972-= 213-5533