From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <p.fedin@samsung.com>
Received: from mailout3.w1.samsung.com (mailout3.w1.samsung.com
[210.118.77.13]) by dpdk.org (Postfix) with ESMTP id 3A036568D
for <dev@dpdk.org>; Thu, 4 Feb 2016 11:29:22 +0100 (CET)
Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245])
by mailout3.w1.samsung.com
(Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014))
with ESMTP id <0O2000KMFQGWFF30@mailout3.w1.samsung.com> for dev@dpdk.org;
Thu, 04 Feb 2016 10:29:20 +0000 (GMT)
X-AuditID: cbfec7f5-f79b16d000005389-37-56b328005f87
Received: from eusync4.samsung.com ( [203.254.199.214])
by eucpsbgm2.samsung.com (EUCPMTA) with SMTP id BC.76.21385.00823B65; Thu,
4 Feb 2016 10:29:20 +0000 (GMT)
Received: from fedinw7x64 ([106.109.131.169])
by eusync4.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0
64bit (built May 5 2014))
with ESMTPA id <0O2000BYWQGVUP20@eusync4.samsung.com>; Thu,
04 Feb 2016 10:29:20 +0000 (GMT)
From: Pavel Fedin <p.fedin@samsung.com>
To: 'Jianfeng Tan' <jianfeng.tan@intel.com>, dev@dpdk.org
Date: Thu, 04 Feb 2016 13:29:19 +0300
Message-id: <00b201d15f36$e87e0260$b97a0720$@samsung.com>
MIME-version: 1.0
Content-type: text/plain; charset=us-ascii
Content-transfer-encoding: 7bit
X-Mailer: Microsoft Outlook 14.0
Thread-index: AdFfNrpperjr0h1ASNusolsi+AFLMQ==
Content-language: ru
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrMLMWRmVeSWpSXmKPExsVy+t/xa7oMGpvDDP5tlbF492k7k0X37C9s
FpNnS1lcn3CB1YHF49eCpawei/e8ZPKYdzLQo2/LKsYAligum5TUnMyy1CJ9uwSujO/HvjAV
fBGuOHO7n7WBcbpAFyMnh4SAicS+qdPZIGwxiQv31gPZXBxCAksZJebtuMUI4XxnlPjzfDkz
SBWbgLrE6a8fWEBsEQFLiU9v/oHFmQXcJV6sPw42SVjAR+JS/zuwOIuAqkT7oo2MIDYvUP2N
B5dYIGxBiR+T77FA9GpJrN95nAnClpfYvOYtM8RFChI7zr5mhNilJ/H70FOoXSIS0/7dY57A
KDALyahZSEbNQjJqFpKWBYwsqxhFU0uTC4qT0nON9IoTc4tL89L1kvNzNzFCgvrrDsalx6wO
MQpwMCrx8DZ4bgoTYk0sK67MPcQowcGsJMKbprY5TIg3JbGyKrUoP76oNCe1+BCjNAeLkjjv
zF3vQ4QE0hNLUrNTUwtSi2CyTBycUg2Mm3UsdrYEh94VPzRX8cW2CeyLl08Q43hV+eiVj/mO
6rQvDMETnO9drHsnlq934In03uZDvFtOd/86vSGp4kyIR1iAcKr/wfWe9hctrB+srLBdlR63
Mk1M3Pznt0w3Zv91rxcdWcUp8fmImnmpr/mHrN8l+eHtJ+Jfyc548ueD9veW/FkbBLyeK7EU
ZyQaajEXFScCAOxEXF1mAgAA
Cc: 'Dyasly Sergey' <s.dyasly@samsung.com>
Subject: [dpdk-dev] PING: [PATCH v2] pmd/virtio: fix cannot start virtio dev
after stop
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 04 Feb 2016 10:29:22 -0000
Hello! Are there any news about this patch? We have got this problem for the second time, it reproduces every time we try to use
ovs-dpdk inside virtual machine with virtio-net adapter.
Kind regards,
Pavel Fedin
Senior Engineer
Samsung Electronics Research center Russia
> -----Original Message-----
> From: Jianfeng Tan [mailto:jianfeng.tan@intel.com]
> Sent: Monday, January 11, 2016 9:16 AM
> To: dev@dpdk.org
> Cc: p.fedin@samsung.com; yuanhan.liu@linux.intel.com; Jianfeng Tan
> Subject: [PATCH v2] pmd/virtio: fix cannot start virtio dev after stop
>
> v2 changes:
> - Address compiling error.
> - Add Reported-by.
>
> Fix the issue that virtio device cannot be started after stopped.
>
> The field, hw->started, should be changed by virtio_dev_start/stop instead
> of virtio_dev_close.
>
> Reported-by: Pavel Fedin <p.fedin@samsung.com>
> Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
> Acked-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
>
> ---
> drivers/net/virtio/virtio_ethdev.c | 14 +++++++++-----
> 1 file changed, 9 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c
> index d928339..5bdd305 100644
> --- a/drivers/net/virtio/virtio_ethdev.c
> +++ b/drivers/net/virtio/virtio_ethdev.c
> @@ -490,11 +490,13 @@ virtio_dev_close(struct rte_eth_dev *dev)
>
> PMD_INIT_LOG(DEBUG, "virtio_dev_close");
>
> + if (hw->started == 1)
> + virtio_dev_stop(dev);
> +
> /* reset the NIC */
> if (pci_dev->driver->drv_flags & RTE_PCI_DRV_INTR_LSC)
> vtpci_irq_config(hw, VIRTIO_MSI_NO_VECTOR);
> vtpci_reset(hw);
> - hw->started = 0;
> virtio_dev_free_mbufs(dev);
> virtio_free_queues(dev);
> }
> @@ -1408,10 +1410,9 @@ eth_virtio_dev_uninit(struct rte_eth_dev *eth_dev)
> if (rte_eal_process_type() == RTE_PROC_SECONDARY)
> return -EPERM;
>
> - if (hw->started == 1) {
> - virtio_dev_stop(eth_dev);
> - virtio_dev_close(eth_dev);
> - }
> + /* Close it anyway since there's no way to know if closed */
> + virtio_dev_close(eth_dev);
> +
> pci_dev = eth_dev->pci_dev;
>
> eth_dev->dev_ops = NULL;
> @@ -1612,9 +1613,12 @@ static void
> virtio_dev_stop(struct rte_eth_dev *dev)
> {
> struct rte_eth_link link;
> + struct virtio_hw *hw = dev->data->dev_private;
>
> PMD_INIT_LOG(DEBUG, "stop");
>
> + hw->started = 0;
> +
> if (dev->data->dev_conf.intr_conf.lsc)
> rte_intr_disable(&dev->pci_dev->intr_handle);
>
> --
> 2.1.4