DPDK patches and discussions
 help / color / mirror / Atom feed
From: Nick Connolly <nick.connolly@mayadata.io>
To: John Alexander <John.Alexander@datapath.co.uk>,
	Bruce Richardson <bruce.richardson@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] windows: minor build fixes
Date: Fri, 30 Oct 2020 20:21:17 +0000
Message-ID: <00be3a68-19eb-9146-781b-feff8f78f381@mayadata.io> (raw)
In-Reply-To: <DB6PR0902MB2072A91AECFF70D00F15E336B4150@DB6PR0902MB2072.eurprd09.prod.outlook.com>

> Do we know what the motivation to rename the import library for the 
> Windows build was in the first place? I've tried removing the renaming 
> of the import library completely in the Windows build and the build 
> produces valid output (a valid DLL and paired import library is 
> generated for each RTE lib using clang build); The meson version test 
> addition may be unnecessary here?
> Kind Regards,
> John Alexander.

I looked back through the commit history for Meson and there were a 
number of changes to the way that import libraries are handled between 
0.47.1 and 0.54.0.  I installed the meson releases in order, but was 
unable to build successfully with anything before 0.54.0 - I was seeing 
complaints about unknown linker flags building with Clang 11.0.0 and 
Link 14.27.29112.0 from Visual Studio 2019.

Assuming that builds with meson 0.47.1 and Clang/Link do work, I took 
the conservative approach of only making the change for the version of 
Meson where I know that /implib is handled correctly, leaving the 
previous behaviour unchanged for earlier versions which I'm unable to 


  reply	other threads:[~2020-10-30 20:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-30 17:46 [dpdk-dev] [PATCH] Windows: " Nick Connolly
2020-10-30 17:46 ` [dpdk-dev] [PATCH] windows: " Nick Connolly
2020-10-30 19:57   ` John Alexander
2020-10-30 20:21     ` Nick Connolly [this message]
2020-10-30 21:41   ` Ranjit Menon
2020-10-30 22:51     ` Tal Shnaiderman
2020-10-31  6:16       ` Nick Connolly
2020-10-31  6:44 ` [dpdk-dev] [PATCH v2] " Nick Connolly
2020-11-06 18:51   ` [dpdk-dev] [EXTERNAL] " Khoa To
2020-11-13 14:16     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=00be3a68-19eb-9146-781b-feff8f78f381@mayadata.io \
    --to=nick.connolly@mayadata.io \
    --cc=John.Alexander@datapath.co.uk \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git