From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 47B06A04E6; Fri, 30 Oct 2020 21:21:24 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DE8CEAC8D; Fri, 30 Oct 2020 21:21:22 +0100 (CET) Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by dpdk.org (Postfix) with ESMTP id DB1B072DF for ; Fri, 30 Oct 2020 21:21:20 +0100 (CET) Received: by mail-wr1-f66.google.com with SMTP id n18so7790966wrs.5 for ; Fri, 30 Oct 2020 13:21:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mayadata-io.20150623.gappssmtp.com; s=20150623; h=from:subject:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=iS+hcFFdMKzRnb48K45ViUuHyRLHFY6WlRgYra4N12w=; b=DuZO3+j87dMv3iYtJgRwAo8lCJ8uI8HRwatuZcqM+ZIzGyiBq/KofN7X/1FZnvyJHD MbWIjkGFPYFWkSVwNduztvMx95Tq/7eU9fJLsokFopboIgU1+NG8A7tvnwI8oMX8g+gC UVcSKjFeavo3cj6fyXczINfw6nl1+XxA1u8VpSoUjFzqSv57V+L1/DNGS4V71r3xzokw LnuqSSGrCUMxkhydlnyAmjUWV9yKduUdAUfe371ke616sVFnWpDrHoOZgm8mkbECUUJ9 sorzFE6n70P51XSM++ndjlTOcz3qjVCnGUbtlzMhYpgJRkjDhO0b9ru6COYYhNk5tLMK X45Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=iS+hcFFdMKzRnb48K45ViUuHyRLHFY6WlRgYra4N12w=; b=qTuah2GXiwSZoaeTvQAiyo2tbdVQv3j5/HJVYkZ+INOPjSgAyug4iDYkuOtzbFQByI fwFbIDdoki3tYw1eRIA2e8iiSbLx0qLBEnrAItEKZyMGN9CB87mkHkaQ+QkBLmLqPBM6 C76Nqa5eLbgjeiowzfSG+H7CJ8qbM6wEcAo1PFdBvHLn+srU5WfkkaYMxsLgGRG8jqED LCqn2tYMU5HoLu34ZtBQLaTrPeRW5EJeRYkq9anEJfafUu7Im1Lnmpzw8kpr0weYuJ1w 3eU5Xq1xfwK+Y9eFJO2XVqjPy+du+P382j7dXr3KwkzoJpy3FNXgEW8ZmQU4+IKDXEu8 FVhg== X-Gm-Message-State: AOAM532e8ntKwUr/29whOEvkGQF7lZxte5P/keJEjJ1zFVzAUNC4p1w2 STX5DV530zkcv6k+26eH0AYfHNsaGpFFmtJi X-Google-Smtp-Source: ABdhPJxQIR+tRmWVhR/Tn+Bj5rvtGS5tOCeRfRHiBBqW3en+Dc5knnyaNDhuco7f3cdjiojzJsiJVg== X-Received: by 2002:a5d:54c8:: with SMTP id x8mr5137576wrv.286.1604089280039; Fri, 30 Oct 2020 13:21:20 -0700 (PDT) Received: from [192.168.0.33] (cpc98320-croy25-2-0-cust77.19-2.cable.virginm.net. [80.235.134.78]) by smtp.gmail.com with ESMTPSA id y206sm6065388wmd.34.2020.10.30.13.21.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Oct 2020 13:21:19 -0700 (PDT) From: Nick Connolly X-Google-Original-From: Nick Connolly To: John Alexander , Bruce Richardson Cc: "dev@dpdk.org" References: <20201030174617.1958-1-nick.connolly@mayadata.io> <20201030174617.1958-2-nick.connolly@mayadata.io> Message-ID: <00be3a68-19eb-9146-781b-feff8f78f381@mayadata.io> Date: Fri, 30 Oct 2020 20:21:17 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-GB Subject: Re: [dpdk-dev] [PATCH] windows: minor build fixes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > Do we know what the motivation to rename the import library for the > Windows build was in the first place? I've tried removing the renaming > of the import library completely in the Windows build and the build > produces valid output (a valid DLL and paired import library is > generated for each RTE lib using clang build); The meson version test > addition may be unnecessary here? > > Kind Regards, > John Alexander. I looked back through the commit history for Meson and there were a number of changes to the way that import libraries are handled between 0.47.1 and 0.54.0.  I installed the meson releases in order, but was unable to build successfully with anything before 0.54.0 - I was seeing complaints about unknown linker flags building with Clang 11.0.0 and Link 14.27.29112.0 from Visual Studio 2019. Assuming that builds with meson 0.47.1 and Clang/Link do work, I took the conservative approach of only making the change for the version of Meson where I know that /implib is handled correctly, leaving the previous behaviour unchanged for earlier versions which I'm unable to verify. Regards, Nick