From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E2560A0A0A; Tue, 23 Mar 2021 23:17:12 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 66C384014D; Tue, 23 Mar 2021 23:17:12 +0100 (CET) Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) by mails.dpdk.org (Postfix) with ESMTP id 617C240143 for ; Tue, 23 Mar 2021 23:17:11 +0100 (CET) Received: by mail-ed1-f52.google.com with SMTP id z1so25361658edb.8 for ; Tue, 23 Mar 2021 15:17:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mayadata-io.20150623.gappssmtp.com; s=20150623; h=from:subject:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=Dpwuv8gyqwszLZ4Zu9OGIZW6SYSO2dpZy9KJh3j7lmo=; b=AghauqcaWc0+gMoj2Ieb1+KHEU8Ws9Tj520Q8JDctbm7lF/rcT4WDaVCa0s+HIAucN /PH6DFkNxilZjR6Q5Nd3Xjy+KZjlAwpqx92eT58F7XNusqzg358QVOo1EnGXf+kR5I34 GMbV0F6IJnjfKXeDpELChxL/q+PDq9xwdkAujPO6fmlWJJSFgSscHzNoLCvQUPn6Bdxj NDFkyo2q8BdePFvAM6o0C+90Mmedc8rIKld8uGfb2gb1ZVqtMKvGQwA2UfTCg8YdGbmm XXD6jdyLZVwZ4UluSQtFK8g2PVPf/7jzKATpZ3ob1McQzJK3+GmSCYKItmGeexRThTMQ sCfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=Dpwuv8gyqwszLZ4Zu9OGIZW6SYSO2dpZy9KJh3j7lmo=; b=Fg+OmyHd2HmdP1sKdfM3Gt+L3BTwX5IZSVBzmiIXi8b9/y5ZM2McVPJTNHQbMV3Dwm nYDW07qrZPNk3TS+qSK+G2w11+nzDSqRDapBiCoWMzoLk0eCvJ19fsBUGhSypk3PQm5F vGua1RhgTU3PVMgqID7TqLnQnZgBXjfzXnkNkpLnlCJdzjUiOzyU1OroplvMi60lS/sp UoEgkc5aOopmC76gdu+PM/LOMYY3ZDQUtqDorUN00uzcTvS/YCTKeevnOn8oAjDFsl5x HzPLJ+xG9MVAehj8/laYSS8eFL+scVNpGKUqd2Gu5NPb+OHlOCdAdCuSsUbqEdm6hCla s15g== X-Gm-Message-State: AOAM53061eqYaT98yQGwv++IXpcYfn1X+mBoTIhTsEOR5yN9wlphpwvA vSrbBnlLueLzOB0n62cFcBweaA== X-Google-Smtp-Source: ABdhPJxtlqjwyMx9k4OPgeSveObNAlJMhCAdXX3o7GQQdtTSN47mMEe7SHmnlZbeh/SYkrz02k/uTg== X-Received: by 2002:a05:6402:17e9:: with SMTP id t9mr24667edy.211.1616537831039; Tue, 23 Mar 2021 15:17:11 -0700 (PDT) Received: from [192.168.0.33] (cpc98320-croy25-2-0-cust77.19-2.cable.virginm.net. [80.235.134.78]) by smtp.gmail.com with ESMTPSA id a12sm140195edx.91.2021.03.23.15.17.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Mar 2021 15:17:10 -0700 (PDT) From: Nick Connolly X-Google-Original-From: Nick Connolly To: Dmitry Kozlyuk , Gabriel Ganne Cc: Bruce Richardson , Kevin Laatz , dev@dpdk.org, olivier.matz@6wind.com, thierry.herbelot@6wind.com, "Dmitry Malloy (MESHCHANINOV)" , tal Shnaiderman , "Menon, Ranjit" , Thomas Monjalon , Tyler Retzlaff References: <20210322140757.7888-1-gabriel.ganne@6wind.com> <20210323011800.2a50fde8@sovereign> <7f3f5e7c-6731-1062-49ef-52e071a076d1@mayadata.io> <20210324002148.5d7e008d@sovereign> Message-ID: <00d8f878-2008-2d09-4d5f-9ddf94be954c@mayadata.io> Date: Tue, 23 Mar 2021 22:17:08 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210324002148.5d7e008d@sovereign> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Subject: Re: [dpdk-dev] [PATCH v2 2/3] meson: use threads dependency as provided by meson X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > Agreed. In my tests it's "-pthread", not "-lpthread", but still. Agreed - I must have been distracted by the array of -l: arguments :-) > It's more like, in lib/librte_telemetry/meson.build: > > if not is_windows > ext_deps += threads_dep > endif It's not a big deal, but my thinking was that the library has a genuine threads dependency, but in the Windows case this is satisfied by EAL and so threads_dep can perhaps legitimately be empty. It also means there's only one place where the decision is made regardless of the number of dependencies. Regards, Nick