From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: xuan.ding@intel.com, chenbo.xia@intel.com
Cc: dev@dpdk.org, jiayu.hu@intel.com, xingguang.he@intel.com,
yvonnex.yang@intel.com, cheng1.jiang@intel.com
Subject: Re: [PATCH] vhost: fix unnecessary dirty page logging
Date: Thu, 7 Jul 2022 14:04:00 +0200 [thread overview]
Message-ID: <00f1ca48-aeb9-d194-4af0-3af6681d2f84@redhat.com> (raw)
In-Reply-To: <20220707065513.66458-1-xuan.ding@intel.com>
On 7/7/22 08:55, xuan.ding@intel.com wrote:
> From: Xuan Ding <xuan.ding@intel.com>
>
> The dirty page logging is only required in vhost enqueue direction for
> live migration. This patch removes the unnecessary dirty page logging
> in vhost dequeue direction. Otherwise, it will result in a performance
> drop. Some if-else judgements are also optimized to improve performance.
>
> Fixes: 6d823bb302c7 ("vhost: prepare sync for descriptor to mbuf refactoring")
> Fixes: b6eee3e83402 ("vhost: fix sync dequeue offload")
>
> Signed-off-by: Xuan Ding <xuan.ding@intel.com>
> ---
> lib/vhost/virtio_net.c | 31 +++++++++++++------------------
> 1 file changed, 13 insertions(+), 18 deletions(-)
>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
next prev parent reply other threads:[~2022-07-07 12:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-07 6:55 xuan.ding
2022-07-07 8:23 ` Hu, Jiayu
2022-07-07 9:51 ` Xia, Chenbo
2022-07-07 11:30 ` Maxime Coquelin
2022-07-08 7:04 ` Ding, Xuan
2022-07-08 7:53 ` He, Xingguang
2022-07-08 8:13 ` He, Xingguang
2022-07-08 7:57 ` Maxime Coquelin
2022-07-08 8:09 ` Ding, Xuan
2022-07-11 8:09 ` He, Xingguang
2022-07-07 12:04 ` Maxime Coquelin [this message]
2022-07-08 9:11 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00f1ca48-aeb9-d194-4af0-3af6681d2f84@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=chenbo.xia@intel.com \
--cc=cheng1.jiang@intel.com \
--cc=dev@dpdk.org \
--cc=jiayu.hu@intel.com \
--cc=xingguang.he@intel.com \
--cc=xuan.ding@intel.com \
--cc=yvonnex.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).