From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 41242A0540; Thu, 7 Jul 2022 14:04:17 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 25A7940A7B; Thu, 7 Jul 2022 14:04:17 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 6DD17406B4 for ; Thu, 7 Jul 2022 14:04:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1657195454; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YUawy3D+fo7zjbG6nEFSc+Bw5j8PxlkvQ9Hr1ivh104=; b=GXNeaS3O+trgpwK8OryKcyI308ZKkIAf0U6swgfdME3uDv+0iAYQOiRIfPfKZc/KvaEFLl MENDX6+pGzq97i2kqABChiqX2bTSps7xwpkwaMA8YWZW7fv3ozEtO122nzoSA4m78m+TEf CUn1K6vhBdJJnlEhq+5paO7FXiuYz6c= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-660-W50CwTeyMTufN7frniTYrw-1; Thu, 07 Jul 2022 08:04:03 -0400 X-MC-Unique: W50CwTeyMTufN7frniTYrw-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6812480A0A1; Thu, 7 Jul 2022 12:04:03 +0000 (UTC) Received: from [10.39.208.34] (unknown [10.39.208.34]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0F25B492C3B; Thu, 7 Jul 2022 12:04:01 +0000 (UTC) Message-ID: <00f1ca48-aeb9-d194-4af0-3af6681d2f84@redhat.com> Date: Thu, 7 Jul 2022 14:04:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] vhost: fix unnecessary dirty page logging To: xuan.ding@intel.com, chenbo.xia@intel.com Cc: dev@dpdk.org, jiayu.hu@intel.com, xingguang.he@intel.com, yvonnex.yang@intel.com, cheng1.jiang@intel.com References: <20220707065513.66458-1-xuan.ding@intel.com> From: Maxime Coquelin In-Reply-To: <20220707065513.66458-1-xuan.ding@intel.com> X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 7/7/22 08:55, xuan.ding@intel.com wrote: > From: Xuan Ding > > The dirty page logging is only required in vhost enqueue direction for > live migration. This patch removes the unnecessary dirty page logging > in vhost dequeue direction. Otherwise, it will result in a performance > drop. Some if-else judgements are also optimized to improve performance. > > Fixes: 6d823bb302c7 ("vhost: prepare sync for descriptor to mbuf refactoring") > Fixes: b6eee3e83402 ("vhost: fix sync dequeue offload") > > Signed-off-by: Xuan Ding > --- > lib/vhost/virtio_net.c | 31 +++++++++++++------------------ > 1 file changed, 13 insertions(+), 18 deletions(-) > Reviewed-by: Maxime Coquelin Thanks, Maxime