From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 75E13108F for ; Mon, 23 Jan 2017 18:35:28 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP; 23 Jan 2017 09:35:27 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,274,1477983600"; d="scan'208";a="1097845289" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.38]) ([10.237.220.38]) by fmsmga001.fm.intel.com with ESMTP; 23 Jan 2017 09:35:25 -0800 To: Hemant Agrawal , dev@dpdk.org References: <1484832240-2048-1-git-send-email-hemant.agrawal@nxp.com> <1485172803-17288-1-git-send-email-hemant.agrawal@nxp.com> <1485172803-17288-19-git-send-email-hemant.agrawal@nxp.com> Cc: thomas.monjalon@6wind.com, bruce.richardson@intel.com, shreyansh.jain@nxp.com, john.mcnamara@intel.com, jerin.jacob@caviumnetworks.com From: Ferruh Yigit Message-ID: <010516e0-e56b-88c1-7734-3baf568f4e01@intel.com> Date: Mon, 23 Jan 2017 17:35:25 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <1485172803-17288-19-git-send-email-hemant.agrawal@nxp.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCHv6 18/33] net/dpaa2: adding eth ops to dpaa2 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Jan 2017 17:35:28 -0000 On 1/23/2017 11:59 AM, Hemant Agrawal wrote: > Signed-off-by: Hemant Agrawal > --- <...> > static int > dpaa2_dev_init(struct rte_eth_dev *eth_dev) > { <...> > + eth_dev->data->nb_rx_queues = priv->nb_rx_queues; > + eth_dev->data->nb_tx_queues = priv->nb_tx_queues; No need to assign these during init(), app should set these via rte_eth_dev_configure() API. > + > + priv->hw = dpni_dev; > + priv->hw_id = hw_id; > + priv->flags = 0; <...>