From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 503E1A0A02; Fri, 26 Mar 2021 10:19:29 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 34EE040686; Fri, 26 Mar 2021 10:19:29 +0100 (CET) Received: from smtpbguseast1.qq.com (smtpbguseast1.qq.com [54.204.34.129]) by mails.dpdk.org (Postfix) with ESMTP id E83A14067B for ; Fri, 26 Mar 2021 10:19:26 +0100 (CET) X-QQ-mid: bizesmtp3t1616750359t4f0b5leu Received: from jiawenwu (unknown [183.129.236.74]) by esmtp6.qq.com (ESMTP) with id ; Fri, 26 Mar 2021 17:19:18 +0800 (CST) X-QQ-SSF: 01400000002000D0E000B00A0000000 X-QQ-FEAT: t98IiFeQWzh80/QhAGWF5V12zliRDXx7vAM1IGw0tCSSU3lw/fHZlVkARY1sO cYpf0xJF8TXgLfxwIG6iJa0Xv7aTH8T8zxC6EArSzHnVGKZUkavNFGA6PvyeFKG88LxCDoN Lv5YhuzYwy4ujtHBWSo2/aa2BUujpVdZTXBXKkmXYF4Y0fVESL7VSlYlTVEKbn7t763xZMC hPMw6bslKzGt3c5m7c4kBEtCewGgylof902xwc5L3BQo/tI1AK1A2p7IyHFL10fYWvVV0n9 nuy2VisN9OJ1bSNLbWrLYeakwbo60f7Aik2mq2aRCF55EtITMo2GSVo7R/lUZVdKRs8moM1 JiNiCAcKcJrUPNBROG9AtrttwkZMQ== X-QQ-GoodBg: 2 From: "Jiawen Wu" To: "'Ferruh Yigit'" , References: <20210325055141.629963-1-jiawenwu@trustnetic.com> <20210325055141.629963-4-jiawenwu@trustnetic.com> <603dc490-6524-aac4-4865-5670d9ecb9ca@intel.com> <00f701d721e4$14d4f600$3e7ee200$@trustnetic.com> <42cec25c-6684-9985-2ec9-f7b1c9b95af1@intel.com> In-Reply-To: <42cec25c-6684-9985-2ec9-f7b1c9b95af1@intel.com> Date: Fri, 26 Mar 2021 17:19:18 +0800 Message-ID: <011a01d72221$19c31740$4d4945c0$@trustnetic.com>+6D46824F9C7DB110 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQGQ4Kh8LyId+XhZlLGAV5ICqrp6ygJOx1dQAoMoUuICD1mDegKfzrAxqtZ3vXA= Content-Language: zh-cn X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:trustnetic.com:qybgforeign:qybgforeign6 X-QQ-Bgrelay: 1 Subject: Re: [dpdk-dev] [PATCH v3 3/7] net/txgbe: update link setup process of backplane NICs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On March 26, 2021 4:56 PM, Ferruh Yigit wrote: > On 3/26/2021 2:02 AM, Jiawen Wu wrote: > > On March 25, 2021 6:20 PM, Ferruh Yigit wrote: > >> On 3/25/2021 5:51 AM, Jiawen Wu wrote: > >>> Add device arguments to support runtime options. > >>> And use these configuration to control the link setup flow, to = adapt > >>> to different NIC's construction. Use firmware version to control = the > >>> impact of firmware update. And fix some left bugs. > >>> > >>> Signed-off-by: Jiawen Wu > >> > >> <...> > >> > >>> +#define TXGBE_DEBUG_BP > >>> +#ifdef TXGBE_DEBUG_BP > >>> +#define BP_LOG(fmt, ...) \ > >>> + RTE_LOG(CRIT, PMD, "[%lu.%lu]%s(%d): " fmt, \ > >>> + usec_stamp() / 1000000, usec_stamp() % 1000000, \ > >>> + __func__, __LINE__, ## __VA_ARGS__) #else #define > >> BP_LOG(fmt, ...) > >>> +do { } while (0) #endif > >>> + > >>> #endif /* _TXGBE_LOGS_H_ */ > >>> > >> > >> The 'BP_LOG' looks like used for developer debug prints, if so I > >> suggest removing them completely, but if not can you please convert > >> it dynamic logging, or using existing dynamic logs = 'txgbe_logtype_init', > 'txgbe_logtype_driver'? > >> > >> Thanks, > >> ferruh > > > > I think it should not be removed, since the user needs to adjust = 'ffe' > > parameters according to the logs. I considered converting it to > > dynamic logging. But when the log level is 'debug', it will result = in the printing > of other logs, which I don't need. > > Should I lower the log level of 'BP_LOG', to avoid the above = situation? > > >=20 > You can create a new logtype for it, and it can be controlled without = affecting > other logs, user need to get those logs can enable/disable them in = runtime on > demand, does this work for you? Got it, thanks!