From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 1CEE6A00C4;
	Mon, 30 May 2022 03:09:11 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id D1C5640A89;
	Mon, 30 May 2022 03:09:10 +0200 (CEST)
Received: from loongson.cn (mail.loongson.cn [114.242.206.163])
 by mails.dpdk.org (Postfix) with ESMTP id 10F6F40A82
 for <dev@dpdk.org>; Mon, 30 May 2022 03:09:08 +0200 (CEST)
Received: from [192.168.0.101] (unknown [114.241.48.130])
 by mail.loongson.cn (Coremail) with SMTP id AQAAf9BxaeQsGZRivKkHAA--.30495S3; 
 Mon, 30 May 2022 09:09:00 +0800 (CST)
Content-Type: multipart/alternative;
 boundary="------------IiAUTW0gtBgNjQ5jblk5z0xE"
Message-ID: <012306e3-cdcd-2e17-0b25-a1cee9778b7b@loongson.cn>
Date: Mon, 30 May 2022 09:09:00 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:91.0)
 Gecko/20100101 Thunderbird/91.9.1
Subject: Re: [v1 05/24] eal/loongarch: add spinlock operations for LoongArch
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: thomas@monjalon.net, david.marchand@redhat.com,
 bruce.richardson@intel.com, anatoly.burakov@intel.com,
 qiming.yang@intel.com, Yuying.Zhang@intel.com, jgrajcia@cisco.com,
 konstantin.v.ananyev@yandex.ru, dev@dpdk.org, maobibo@loongson.cn
References: <20220528093311.123946-1-zhoumin@loongson.cn>
 <20220528093311.123946-6-zhoumin@loongson.cn>
 <20220528085410.62f27ba2@hermes.local>
From: zhoumin <zhoumin@loongson.cn>
In-Reply-To: <20220528085410.62f27ba2@hermes.local>
X-CM-TRANSID: AQAAf9BxaeQsGZRivKkHAA--.30495S3
X-Coremail-Antispam: 1UD129KBjvdXoWrJr48Zr1DGw4DCF1xGrW3ZFb_yoWxXFb_C3
 4IyFZ7CFyaqr4rt345Z3ZYqF1SkF1I93W8C3yqg3WDJ3W5ta4DXFs3ur9Fqr13ZryrArn8
 twn0qw4vkw12gjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT
 9fnUUIcSsGvfJTRUUUbT8FF20E14v26r4j6ryUM7CY07I20VC2zVCF04k26cxKx2IYs7xG
 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w
 A2z4x0Y4vE2Ix0cI8IcVAFwI0_Gr0_Xr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr0_
 Cr1l84ACjcxK6I8E87Iv67AKxVW8JVWxJwA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_Gr0_Gr
 1UM2AIxVAIcxkEcVAq07x20xvEncxIr21lYx0E2Ix0cI8IcVAFwI0_JrI_JrylYx0Ex4A2
 jsIE14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvEwIxGrwACjI8F5VA0II
 8E6IAqYI8I648v4I1lFIxGxcIEc7CjxVA2Y2ka0xkIwI1l7480Y4vEI4kI2Ix0rVAqx4xJ
 Mxk0xIA0c2IEe2xFo4CEbIxvr21lc2xSY4AK67AK6w4l42xK82IYc2Ij64vIr41l4I8I3I
 0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUGVWUWwC20s026x8GjcxK67AKxVWU
 GVWUWwC2zVAF1VAY17CE14v26r1q6r43MIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI
 0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r4j6F4UMIIF0xvE42xK8VAvwI8IcIk0
 rVWrJr0_WFyUJwCI42IY6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r
 4j6r4UJbIYCTnIWIevJa73UjIFyTuYvjfU7oUqUUUUU
X-CM-SenderInfo: 52kr3ztlq6z05rqj20fqof0/
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

This is a multi-part message in MIME format.
--------------IiAUTW0gtBgNjQ5jblk5z0xE
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Stephen,

Thanks for your comments!  I'm evaluating the generic code of spinlock
on std atomics of LoongArch toolchain. An updated patch will come later.

On 2022/5/28 下午11:54, Stephen Hemminger wrote:
> On Sat, 28 May 2022 17:32:52 +0800
> Min Zhou<zhoumin@loongson.cn>  wrote:
>
>> This patch adds spinlock operations for LoongArch architecture.
>> These implementations refer to GLIBC pthread_spin_xxlock(). The
>> underlying implementation is based on LoongArch atomic
>> instructions (ie, AMSWAP_DB.W).
>>
>> Signed-off-by: Min Zhou<zhoumin@loongson.cn>
> If you supported std atomics, then the g eneric code
> could work here.
--------------IiAUTW0gtBgNjQ5jblk5z0xE
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 8bit

<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <pre class="content">Stephen,

Thanks for your comments!  I'm evaluating the generic code of spinlock
on std atomics of LoongArch toolchain. An updated patch will come later.
</pre>
    <div class="moz-cite-prefix">On 2022/5/28 下午11:54, Stephen Hemminger
      wrote:<br>
    </div>
    <blockquote type="cite"
      cite="mid:20220528085410.62f27ba2@hermes.local">
      <pre class="moz-quote-pre" wrap="">On Sat, 28 May 2022 17:32:52 +0800
Min Zhou <a class="moz-txt-link-rfc2396E" href="mailto:zhoumin@loongson.cn">&lt;zhoumin@loongson.cn&gt;</a> wrote:

</pre>
      <blockquote type="cite">
        <pre class="moz-quote-pre" wrap="">This patch adds spinlock operations for LoongArch architecture.
These implementations refer to GLIBC pthread_spin_xxlock(). The
underlying implementation is based on LoongArch atomic
instructions (ie, AMSWAP_DB.W).

Signed-off-by: Min Zhou <a class="moz-txt-link-rfc2396E" href="mailto:zhoumin@loongson.cn">&lt;zhoumin@loongson.cn&gt;</a>
</pre>
      </blockquote>
      <pre class="moz-quote-pre" wrap="">
If you supported std atomics, then the g eneric code
could work here.
</pre>
    </blockquote>
  </body>
</html>

--------------IiAUTW0gtBgNjQ5jblk5z0xE--