From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 18076A328D for ; Tue, 22 Oct 2019 10:59:53 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6B57F4C9D; Tue, 22 Oct 2019 10:59:51 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 2782D4C8E for ; Tue, 22 Oct 2019 10:59:48 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Oct 2019 01:59:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,326,1566889200"; d="scan'208";a="397607549" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.10]) ([10.237.221.10]) by fmsmga005.fm.intel.com with ESMTP; 22 Oct 2019 01:59:47 -0700 To: Gagandeep Singh , "dev@dpdk.org" References: <20191021091134.12850-1-g.singh@nxp.com> <20191021105027.14792-1-g.singh@nxp.com> <20191021105027.14792-3-g.singh@nxp.com> <05bc5098-776d-ab76-b48d-5c0480d9bbca@intel.com> From: Ferruh Yigit Openpgp: preference=signencrypt Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJUBBMBCgA+AhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEAFiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl1meboFCQlupOoACgkQ+TPrQ98T YR9ACBAAv2tomhyxY0Tp9Up7mNGLfEdBu/7joB/vIdqMRv63ojkwr9orQq5V16V/25+JEAD0 60cKodBDM6HdUvqLHatS8fooWRueSXHKYwJ3vxyB2tWDyZrLzLI1jxEvunGodoIzUOtum0Ce gPynnfQCelXBja0BwLXJMplM6TY1wXX22ap0ZViC0m714U5U4LQpzjabtFtjT8qOUR6L7hfy YQ72PBuktGb00UR/N5UrR6GqB0x4W41aZBHXfUQnvWIMmmCrRUJX36hOTYBzh+x86ULgg7H2 1499tA4o6rvE13FiGccplBNWCAIroAe/G11rdoN5NBgYVXu++38gTa/MBmIt6zRi6ch15oLA Ln2vHOdqhrgDuxjhMpG2bpNE36DG/V9WWyWdIRlz3NYPCDM/S3anbHlhjStXHOz1uHOnerXM 1jEjcsvmj1vSyYoQMyRcRJmBZLrekvgZeh7nJzbPHxtth8M7AoqiZ/o/BpYU+0xZ+J5/szWZ aYxxmIRu5ejFf+Wn9s5eXNHmyqxBidpCWvcbKYDBnkw2+Y9E5YTpL0mS0dCCOlrO7gca27ux ybtbj84aaW1g0CfIlUnOtHgMCmz6zPXThb+A8H8j3O6qmPoVqT3qnq3Uhy6GOoH8Fdu2Vchh TWiF5yo+pvUagQP6LpslffufSnu+RKAagkj7/RSuZV25Ag0EV9ZMvgEQAKc0Db17xNqtSwEv mfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ESYpV8QWj0xK4YM0dLxnDU2IYxjEshSB1T qAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4AibPtrHuIXWQOBECcVZTTOdZYGAzaYzxiA ONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxDUQljeNvKYt1lZE/gAUUxNLWsYyTT+22/ vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35p iVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVjsM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQ I3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdcq9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYH fVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH71PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZ qw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFBVOQOxCvwRG2QCgcJ/UTn5vlivul+cThi 6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJl Rr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYCGwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNh HwUCXWZ5wAUJB3FgggAKCRD5M+tD3xNhH2O+D/9OEz62YuJQLuIuOfL67eFTIB5/1+0j8Tsu o2psca1PUQ61SZJZOMl6VwNxpdvEaolVdrpnSxUF31kPEvR0Igy8HysQ11pj8AcgH0a9FrvU /8k2Roccd2ZIdpNLkirGFZR7LtRw41Kt1Jg+lafI0efkiHKMT/6D/P1EUp1RxOBNtWGV2hrd 0Yg9ds+VMphHHU69fDH02SwgpvXwG8Qm14Zi5WQ66R4CtTkHuYtA63sS17vMl8fDuTCtvfPF HzvdJLIhDYN3Mm1oMjKLlq4PUdYh68Fiwm+boJoBUFGuregJFlO3hM7uHBDhSEnXQr5mqpPM 6R/7Q5BjAxrwVBisH0yQGjsWlnysRWNfExAE2sRePSl0or9q19ddkRYltl6X4FDUXy2DTXa9 a+Fw4e1EvmcF3PjmTYs9IE3Vc64CRQXkhujcN4ZZh5lvOpU8WgyDxFq7bavFnSS6kx7Tk29/ wNJBp+cf9qsQxLbqhW5kfORuZGecus0TLcmpZEFKKjTJBK9gELRBB/zoN3j41hlEl7uTUXTI JQFLhpsFlEdKLujyvT/aCwP3XWT+B2uZDKrMAElF6ltpTxI53JYi22WO7NH7MR16Fhi4R6vh FHNBOkiAhUpoXRZXaCR6+X4qwA8CwHGqHRBfYFSU/Ulq1ZLR+S3hNj2mbnSx0lBs1eEqe2vh cA== Message-ID: <01326a7c-ed75-19a2-29cf-142ed98fd920@intel.com> Date: Tue, 22 Oct 2019 09:59:46 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v4 2/3] net/enetc: set random MAC in case no MAC for SI X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/22/2019 6:31 AM, Gagandeep Singh wrote: > > <...> >>> >>> include $(RTE_SDK)/mk/rte.lib.mk >>> diff --git a/drivers/net/enetc/enetc_ethdev.c >> b/drivers/net/enetc/enetc_ethdev.c >>> index 4e978348c..475ec77c3 100644 >>> --- a/drivers/net/enetc/enetc_ethdev.c >>> +++ b/drivers/net/enetc/enetc_ethdev.c >>> @@ -4,6 +4,7 @@ >>> >>> #include >>> #include >>> +#include >>> >>> #include "enetc_logs.h" >>> #include "enetc.h" >>> @@ -123,11 +124,22 @@ enetc_link_update(struct rte_eth_dev *dev, int >> wait_to_complete __rte_unused) >>> return rte_eth_linkstatus_set(dev, &link); >>> } >>> >>> +static void >>> +print_ethaddr(const char *name, const struct rte_ether_addr *eth_addr) >>> +{ >>> + char buf[RTE_ETHER_ADDR_FMT_SIZE]; >>> + >>> + rte_ether_format_addr(buf, RTE_ETHER_ADDR_FMT_SIZE, eth_addr); >>> + ENETC_PMD_INFO("%s%s\n", name, buf); >>> +} >>> + >>> static int >>> enetc_hardware_init(struct enetc_eth_hw *hw) >>> { >>> struct enetc_hw *enetc_hw = &hw->hw; >>> uint32_t *mac = (uint32_t *)hw->mac.addr; >>> + uint32_t high_mac = 0; >>> + uint16_t low_mac = 0; >>> >>> PMD_INIT_FUNC_TRACE(); >>> /* Calculating and storing the base HW addresses */ >>> @@ -138,8 +150,29 @@ enetc_hardware_init(struct enetc_eth_hw *hw) >>> enetc_wr(enetc_hw, ENETC_SIMR, ENETC_SIMR_EN); >>> >>> *mac = (uint32_t)enetc_port_rd(enetc_hw, ENETC_PSIPMAR0(0)); >>> + high_mac = (uint32_t)*mac; >>> mac++; >>> *mac = (uint16_t)enetc_port_rd(enetc_hw, ENETC_PSIPMAR1(0)); >>> + low_mac = (uint16_t)*mac; >>> + >>> + if ((high_mac | low_mac) == 0) { >>> + char *first_byte; >>> + >>> + ENETC_PMD_INFO("MAC is not available for this SI, " >>> + "set random MAC\n"); >>> + mac = (uint32_t *)hw->mac.addr; >>> + *mac = (uint32_t)rte_rand(); >>> + first_byte = (char *)mac; >>> + *first_byte &= 0xfe; /* clear multicast bit */ >>> + *first_byte |= 0x02; /* set local assignment bit (IEEE802) */ >>> + >>> + enetc_port_wr(enetc_hw, ENETC_PSIPMAR0(0), *mac); >>> + mac++; >>> + *mac = (uint16_t)rte_rand(); >>> + enetc_port_wr(enetc_hw, ENETC_PSIPMAR1(0), *mac); >>> + print_ethaddr("New address: ", >>> + (const struct rte_ether_addr *)hw->mac.addr); >>> + } >>> >>> return 0; >>> } >>> @@ -906,5 +939,5 @@ RTE_INIT(enetc_pmd_init_log) >>> { >>> enetc_logtype_pmd = rte_log_register("pmd.net.enetc"); >>> if (enetc_logtype_pmd >= 0) >>> - rte_log_set_level(enetc_logtype_pmd, RTE_LOG_NOTICE); >>> + rte_log_set_level(enetc_logtype_pmd, RTE_LOG_INFO); >> >> >> This part look unrelated with the what commit log describes. And why you are >> making the driver more verbose by default? >> > I changed this to print MAC address by default. Currently, enetc driver is not supporting > NOTICE type log and the next supported log level is INFO and we are using INFO type log > only while setting the random MAC addresses. > If INFO type log is not ok to print this information, please suggest me. Should I add NOTICE > Type log? Or just add a printf to display the MAC address. > There is no strict rule, but mostly* drivers set the default log level to NOTICE, the intention is to make logging less noisy by default. Is the log you have mentioned should be printed always for all applications by default, if so I suggest updating its level to NOTICE, (adding NOTICE level is easy or you can use 'ENETC_PMD_LOG' directly for it.) But if that log is not required for all, I suggest keeping it INFO and the default level NOTICE.