From: Andrew Rybchenko <arybchenko@solarflare.com>
To: Ali Alnubani <alialnu@nvidia.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] common/sfc_efx/base: fix build breakage on clang 3.4.x
Date: Tue, 27 Oct 2020 18:23:37 +0300 [thread overview]
Message-ID: <01515a12-441d-0df3-49cd-11371d66f897@solarflare.com> (raw)
In-Reply-To: <DM6PR12MB4618C718224C2877C612DAB3DA160@DM6PR12MB4618.namprd12.prod.outlook.com>
On 10/27/20 5:55 PM, Ali Alnubani wrote:
> Thanks Andrew.
>
>> -----Original Message-----
>> From: dev <dev-bounces@dpdk.org> On Behalf Of Andrew Rybchenko
>> Sent: Tuesday, October 27, 2020 2:09 PM
>> To: dev@dpdk.org
>> Subject: [dpdk-dev] [PATCH] common/sfc_efx/base: fix build breakage on
>> clang 3.4.x
>>
>> Remove duplicate typedef for efx_mae_actions_t.
>>
>> Fixes: 57f9eb33d32c ("common/sfc_efx/base: add action set spec init/fini
>> APIs")
>>
>> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
>> ---
>> drivers/common/sfc_efx/base/efx_impl.h | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/common/sfc_efx/base/efx_impl.h
>> b/drivers/common/sfc_efx/base/efx_impl.h
>> index d8423d4..ed5b872 100644
>> --- a/drivers/common/sfc_efx/base/efx_impl.h
>> +++ b/drivers/common/sfc_efx/base/efx_impl.h
>> @@ -1736,7 +1736,7 @@ struct efx_mae_match_spec_s {
>> uint16_t emavp_tci_be;
>> } efx_mae_action_vlan_push_t;
>>
>> -typedef struct efx_mae_actions_s {
>> +struct efx_mae_actions_s {
>> /* Bitmap of actions in spec, indexed by action type */
>> uint32_t emass_actions;
>>
>> @@ -1746,7 +1746,7 @@ struct efx_mae_match_spec_s {
>> EFX_MAE_VLAN_PUSH_MAX_NTAGS];
>> uint32_t emass_mark_value;
>> efx_mport_sel_t emass_deliver_mport;
>> -} efx_mae_actions_t;
>> +};
>>
>> #endif /* EFSYS_OPT_MAE */
>>
>> --
>> 1.8.3.1
>
> Tested-by: Ali Alnubani <alialnu@nvidia.com>
>
Squashed into corresponding changeset, thanks.
prev parent reply other threads:[~2020-10-27 15:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-27 12:08 Andrew Rybchenko
2020-10-27 14:55 ` Ali Alnubani
2020-10-27 15:23 ` Andrew Rybchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01515a12-441d-0df3-49cd-11371d66f897@solarflare.com \
--to=arybchenko@solarflare.com \
--cc=alialnu@nvidia.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).