From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DCDBAA04B5; Tue, 27 Oct 2020 16:23:53 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9D1A269F8; Tue, 27 Oct 2020 16:23:52 +0100 (CET) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id C5EE75A8C for ; Tue, 27 Oct 2020 16:23:49 +0100 (CET) Received: from mx1-us1.ppe-hosted.com (unknown [10.110.50.150]) by dispatch1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 6B090201D2; Tue, 27 Oct 2020 15:23:48 +0000 (UTC) Received: from us4-mdac16-14.at1.mdlocal (unknown [10.110.49.196]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 662FC800B3; Tue, 27 Oct 2020 15:23:48 +0000 (UTC) X-Virus-Scanned: Proofpoint Essentials engine Received: from mx1-us1.ppe-hosted.com (admin2.mdlocal [10.110.48.53]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id D13B5100084; Tue, 27 Oct 2020 15:23:47 +0000 (UTC) Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 8FE61A00069; Tue, 27 Oct 2020 15:23:47 +0000 (UTC) Received: from [192.168.38.17] (10.17.10.39) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 27 Oct 2020 15:23:42 +0000 To: Ali Alnubani , "dev@dpdk.org" References: <1603800517-32207-1-git-send-email-arybchenko@solarflare.com> From: Andrew Rybchenko Message-ID: <01515a12-441d-0df3-49cd-11371d66f897@solarflare.com> Date: Tue, 27 Oct 2020 18:23:37 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.17.10.39] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.6.1012-25750.003 X-TM-AS-Result: No-2.516300-8.000000-10 X-TMASE-MatchedRID: 9zTThWtzImvmLzc6AOD8DfHkpkyUphL9QfblIp3oBdEutoY2UtFqGHY8 O0T+5GcksOgv3K25H2nppdh1IrIg2Tfa6I248QZMEhGH3CRdKUUmKH/Kj46+VZGhAvBSa2i/2yT G00/Sv02t2gtuWr1LmlkBaILiXD1xosAmmD5+bCbMbQu1fPiCD+imxgRHwEwm1x7hyCSjyxijxY yRBa/qJQPTK4qtAgwIAYt5KiTiutkLbigRnpKlKZx+7GyJjhAUq6yojMr2xFEZU2OCEVwXVAku9 /tVOHz3EEPaadZyONxYhyzzhPmek2ZSx4Qq3B0yPDHmMT7hR9VeAiB+r+Ev24YWZva67fpBj4Ag 2wGNz+7VR/C6Jzklsv0tgNOYnrUHtlij81XKIOEfwV6sBPR0lg== X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--2.516300-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.6.1012-25750.003 X-MDID: 1603812228-6oSMk61pT07f X-PPE-DISP: 1603812228;6oSMk61pT07f Subject: Re: [dpdk-dev] [PATCH] common/sfc_efx/base: fix build breakage on clang 3.4.x X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/27/20 5:55 PM, Ali Alnubani wrote: > Thanks Andrew. > >> -----Original Message----- >> From: dev On Behalf Of Andrew Rybchenko >> Sent: Tuesday, October 27, 2020 2:09 PM >> To: dev@dpdk.org >> Subject: [dpdk-dev] [PATCH] common/sfc_efx/base: fix build breakage on >> clang 3.4.x >> >> Remove duplicate typedef for efx_mae_actions_t. >> >> Fixes: 57f9eb33d32c ("common/sfc_efx/base: add action set spec init/fini >> APIs") >> >> Signed-off-by: Andrew Rybchenko >> --- >> drivers/common/sfc_efx/base/efx_impl.h | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/common/sfc_efx/base/efx_impl.h >> b/drivers/common/sfc_efx/base/efx_impl.h >> index d8423d4..ed5b872 100644 >> --- a/drivers/common/sfc_efx/base/efx_impl.h >> +++ b/drivers/common/sfc_efx/base/efx_impl.h >> @@ -1736,7 +1736,7 @@ struct efx_mae_match_spec_s { >> uint16_t emavp_tci_be; >> } efx_mae_action_vlan_push_t; >> >> -typedef struct efx_mae_actions_s { >> +struct efx_mae_actions_s { >> /* Bitmap of actions in spec, indexed by action type */ >> uint32_t emass_actions; >> >> @@ -1746,7 +1746,7 @@ struct efx_mae_match_spec_s { >> EFX_MAE_VLAN_PUSH_MAX_NTAGS]; >> uint32_t emass_mark_value; >> efx_mport_sel_t emass_deliver_mport; >> -} efx_mae_actions_t; >> +}; >> >> #endif /* EFSYS_OPT_MAE */ >> >> -- >> 1.8.3.1 > > Tested-by: Ali Alnubani > Squashed into corresponding changeset, thanks.