From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DC4FEA034E; Wed, 9 Feb 2022 07:17:58 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A081F410FD; Wed, 9 Feb 2022 07:17:58 +0100 (CET) Received: from smtpproxy21.qq.com (smtpbg702.qq.com [203.205.195.102]) by mails.dpdk.org (Postfix) with ESMTP id 2ECD9410F3 for ; Wed, 9 Feb 2022 07:17:55 +0100 (CET) X-QQ-mid: bizesmtp6t1644387468tz7pori9k Received: from jiawenwu (unknown [183.129.236.74]) by bizesmtp.qq.com (ESMTP) with id ; Wed, 09 Feb 2022 14:17:47 +0800 (CST) X-QQ-SSF: 01400000000000F0L000B00A0000000 X-QQ-FEAT: ifY4WOCVI/ONYpLXf5bhujIxrH5WH3VGf/TezHXTZne+rqvb+a9jF4Q3q9IQA uznmKxT5hbR77EDpn+tPlPrLMSyEx/uhKb4KaJ6m/m2FDlwJO9NvNwhurBMtf1TQOJ48XfD y6Dw6i5ldEfb/AnZxuK8uDJBbES7ym7+5OoWmjEAbeNTzTwKnUohNhtgAqlFvvJ8KzwUmpF A9AoHEXEf/EfisSngyWFKQ5xXfBiOcvoLFeaS7I4ElzFujinc6ud52Ml5cuHgcf3Y8FfhxW 4GSYIEZpLzuXbAk77jQUVFcW95IxPLB/KqrfvNBHJHePEa6zzbetQVt3wmNXlm+qqEHZdQ9 ixxPcyfuTyoGz51FmuzjlNmUCXKHtvmrxDdSLUqfAV2bSsgzHQ= X-QQ-GoodBg: 2 From: "Jiawen Wu" To: "'Ferruh Yigit'" , References: <20220208101129.69173-1-jiawenwu@trustnetic.com> <20220208101129.69173-7-jiawenwu@trustnetic.com> <364cf5b8-d20e-8825-52c1-f8efca740826@intel.com> In-Reply-To: <364cf5b8-d20e-8825-52c1-f8efca740826@intel.com> Subject: RE: [PATCH 6/9] net/ngbe: add support to custom PHY interfaces Date: Wed, 9 Feb 2022 14:17:48 +0800 Message-ID: <015901d81d7c$c34f8b70$49eea250$@trustnetic.com>+F4A4FF4E763A4889 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQHTyKOf1otGGvNycD4vyc9g5KAuLAKp75CDAkHAEnGsbAnCgA== Content-Language: zh-cn X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:trustnetic.com:qybgforeign:qybgforeign6 X-QQ-Bgrelay: 1 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On February 9, 2022 1:41 AM, Ferruh Yigit wrote: > On 2/8/2022 10:11 AM, Jiawen Wu wrote: > > Support sub_device ID 61/62/64 for YT8521S SFP, and 51/52 for = M88E1512 > > PHY. > > > > Signed-off-by: Jiawen Wu >=20 > <...> >=20 > > @@ -69,6 +69,10 @@ New Features > > * Added AES-XCBC support in lookaside protocol (IPsec) for CN9K = & > CN10K. > > * Added AES-CMAC support in CN9K & CN10K. > > > > +* **Updated Wangxun ngbe driver.** > > + > > + * Added support for devices of custom PHY interfaces. > > + >=20 > "Custom PHY" is vague, should we provide more details on added PHY > interfaces, like code names etc.... >=20 > <...> >=20 > > @@ -1815,11 +1816,23 @@ s32 ngbe_set_mac_type(struct ngbe_hw *hw) > > case NGBE_SUB_DEV_ID_EM_MVL_RGMII: > > hw->phy.media_type =3D ngbe_media_type_copper; > > hw->mac.type =3D ngbe_mac_em; > > + hw->mac.link_type =3D ngbe_link_copper; > > + break; > > + case NGBE_SUB_DEV_ID_EM_RTL_YT8521S_SFP: > > + hw->phy.media_type =3D ngbe_media_type_copper; > > + hw->mac.type =3D ngbe_mac_em; > > + hw->mac.link_type =3D ngbe_link_fiber; > > break; > > case NGBE_SUB_DEV_ID_EM_MVL_SFP: > > case NGBE_SUB_DEV_ID_EM_YT8521S_SFP: > > hw->phy.media_type =3D ngbe_media_type_fiber; > > hw->mac.type =3D ngbe_mac_em; > > + hw->mac.link_type =3D ngbe_link_fiber; > > + break; > > + case NGBE_SUB_DEV_ID_EM_MVL_MIX: > > + hw->phy.media_type =3D ngbe_media_type_unknown; > > + hw->mac.type =3D ngbe_mac_em; > > + hw->mac.link_type =3D ngbe_media_type_unknown; >=20 > This gives build error [1] because assigned enum type is wrong, is = this > copy/paste error? >=20 > ../drivers/net/ngbe/base/ngbe_hw.c: In function = =E2=80=98ngbe_set_mac_type=E2=80=99: > ../drivers/net/ngbe/base/ngbe_hw.c:1835:35: error: implicit = conversion > from =E2=80=98enum ngbe_media_type=E2=80=99 to =E2=80=98enum = ngbe_link_type=E2=80=99 > [-Werror=3Denum-conversion] > 1835 | hw->mac.link_type =3D > ngbe_media_type_unknown; > | >=20 >=20 > [1] > http://mails.dpdk.org/archives/test-report/2022-February/257750.html >=20 >=20 > <...> >=20 > > +s32 ngbe_check_phy_mode_mvl(struct ngbe_hw *hw) { > > + u16 value =3D 0; > > + > > + /* select page 18 reg 20 */ > > + ngbe_write_phy_reg_mdi(hw, MVL_PAGE_SEL, 0, 18); > > + ngbe_read_phy_reg_mdi(hw, MVL_GEN_CTL, 0, &value); > > + if (MVL_GEN_CTL_MODE(value) =3D=3D MVL_GEN_CTL_MODE_COPPER) { > > + /* mode select to RGMII-to-copper */ > > + hw->phy.type =3D ngbe_phy_mvl; > > + hw->phy.media_type =3D ngbe_media_type_copper; > > + hw->mac.link_type =3D ngbe_link_copper; > > + } else if (MVL_GEN_CTL_MODE(value) =3D=3D MVL_GEN_CTL_MODE_FIBER) = { > > + /* mode select to RGMII-to-sfi */ > > + hw->phy.type =3D ngbe_phy_mvl_sfi; > > + hw->phy.media_type =3D ngbe_media_type_fiber; > > + hw->mac.link_type =3D ngbe_link_fiber; > > + } else { > > + DEBUGOUT("marvell 88E1512 mode %x is not supported.\n", value); >=20 > 'DEBUGOUT' already adds '\n' as far as I can see, it log add double = line. >=20 > There are multiple usages in this patch. I would fix it in a separate patch.