From: "Kinsella, Ray" <mdr@ashroe.eu>
To: Ruifeng Wang <Ruifeng.Wang@arm.com>,
Ferruh Yigit <ferruh.yigit@intel.com>,
Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
Vladimir Medvedkin <vladimir.medvedkin@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, nd <nd@arm.com>
Subject: Re: [dpdk-dev] [PATCH] lib: fix build for missing RCU library dependency
Date: Tue, 14 Jul 2020 12:20:41 +0100 [thread overview]
Message-ID: <01775d44-860e-6501-50aa-60f55346a4f8@ashroe.eu> (raw)
In-Reply-To: <HE1PR0801MB2025CEFE014B271C240C67F19E600@HE1PR0801MB2025.eurprd08.prod.outlook.com>
On 13/07/2020 16:46, Ruifeng Wang wrote:
>
>> -----Original Message-----
>> From: Ferruh Yigit <ferruh.yigit@intel.com>
>> Sent: Monday, July 13, 2020 9:51 PM
>> To: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>; Ruifeng Wang
>> <Ruifeng.Wang@arm.com>; Vladimir Medvedkin
>> <vladimir.medvedkin@intel.com>; Ray Kinsella <mdr@ashroe.eu>
>> Cc: dev@dpdk.org; Ferruh Yigit <ferruh.yigit@intel.com>
>> Subject: [PATCH] lib: fix build for missing RCU library dependency
>>
>> 'librte_rcu' is now dependency to 'librte_lpm' library, this dependency should
>> be reflected to build system.
>>
>> Fixes: 8a9f8564e9f9 ("lpm: implement RCU rule reclamation")
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>> ---
>> Cc: ruifeng.wang@arm.com
> Hi Ferruh,
>
> Thanks for fixing this.
> Although I didn't reproduce the building issue, this patch is obviously valid.
>
> Regards.
> /Ruifeng
>
> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
Was already there for meson/ninja.
Acked-by: Ray Kinsella <mdr@ashroe.eu>
>> ---
>> lib/Makefile | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/lib/Makefile b/lib/Makefile index 4b981f505e..8f5b68a2d4 100644
>> --- a/lib/Makefile
>> +++ b/lib/Makefile
>> @@ -59,7 +59,7 @@ DEPDIRS-librte_rib := librte_eal librte_mempool
>> DIRS-$(CONFIG_RTE_LIBRTE_FIB) += librte_fib DEPDIRS-librte_fib :=
>> librte_eal librte_rib
>> DIRS-$(CONFIG_RTE_LIBRTE_LPM) += librte_lpm -DEPDIRS-librte_lpm :=
>> librte_eal librte_hash
>> +DEPDIRS-librte_lpm := librte_eal librte_hash librte_rcu
>> DIRS-$(CONFIG_RTE_LIBRTE_ACL) += librte_acl DEPDIRS-librte_acl :=
>> librte_eal
>> DIRS-$(CONFIG_RTE_LIBRTE_MEMBER) += librte_member
>> --
>> 2.25.4
>
next prev parent reply other threads:[~2020-07-14 11:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-13 13:51 Ferruh Yigit
2020-07-13 15:46 ` Ruifeng Wang
2020-07-14 11:20 ` Kinsella, Ray [this message]
2020-07-15 11:16 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01775d44-860e-6501-50aa-60f55346a4f8@ashroe.eu \
--to=mdr@ashroe.eu \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=Ruifeng.Wang@arm.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=nd@arm.com \
--cc=vladimir.medvedkin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).