From: oulijun <oulijun@huawei.com>
To: "Li, Xiaoyun" <xiaoyun.li@intel.com>,
"linuxarm@openeuler.org" <linuxarm@openeuler.org>,
dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [Linuxarm] Re: [PATCH 1/3] app/testpmd: fix forwarding configuration when DCB test
Date: Sat, 27 Mar 2021 11:53:56 +0800 [thread overview]
Message-ID: <01839804-cf22-56a9-40d8-2798a0dd1130@huawei.com> (raw)
In-Reply-To: <DM4PR11MB55345A99567EA390CA26170499629@DM4PR11MB5534.namprd11.prod.outlook.com>
在 2021/3/25 10:21, Li, Xiaoyun 写道:
>
>
>> -----Original Message-----
>> From: oulijun <oulijun@huawei.com>
>> Sent: Wednesday, March 24, 2021 21:40
>> To: linuxarm@openeuler.org; Li, Xiaoyun <xiaoyun.li@intel.com>; dev
>> <dev@dpdk.org>
>> Subject: Re: [Linuxarm] Re: [PATCH 1/3] app/testpmd: fix forwarding
>> configuration when DCB test
>>
>>
>>
>> 在 2021/3/24 10:03, Li, Xiaoyun 写道:
>>>
>>>
>>>> -----Original Message-----
>>>> From: oulijun <oulijun@huawei.com>
>>>> Sent: Tuesday, March 23, 2021 22:19
>>>> To: Li, Xiaoyun <xiaoyun.li@intel.com>; Yigit, Ferruh
>>>> <ferruh.yigit@intel.com>
>>>> Cc: dev@dpdk.org; linuxarm@openeuler.org
>>>> Subject: Re: [PATCH 1/3] app/testpmd: fix forwarding configuration
>>>> when DCB test
>>>>
>>> <snip>
>>>>>> @@ -2707,14 +2707,16 @@ stop_port(portid_t pid)
>>>>>> portid_t peer_pl[RTE_MAX_ETHPORTS];
>>>>>> int peer_pi;
>>>>>>
>>>>>> - if (dcb_test) {
>>>>>> - dcb_test = 0;
>>>>>> - dcb_config = 0;
>>>>>> - }
>>>>>> -
>>>>>> if (port_id_is_invalid(pid, ENABLED_WARN))
>>>>>> return;
>>>>>>
>>>>>> + /*
>>>>>> + * In "start_port" function, dcb_test is set to 1 based on dcb_config.
>>>>>> + * So it should be cleared when dcb_config is 0.
>>>>>> + */
>>>>>> + if (dcb_config == 0)
>>>>>> + dcb_test = 0;
>>>>>> +
>>>>>
>>>>> I don't understand why are you changing this.
>>>>> dcb_test will only be set when dcb_config is 1 when starting ports.
>>>>> And both
>>>> dcb_test and dcb_config will be cleared when stopping ports.
>>>>> So dcb will only affect when you set port dcb and then start port
>>>>> and when
>>>> stop port dcb will be cleared.
>>>>>
>>>> Yes, I think. The forwarding streams should not be changed from
>>>> "dcb_fwd_config_setup" to "rss_fwd_config_setup" after dcb info is
>> configured.
>>>> But, now, the logical codes do it when stopping ports and then starting ports.
>>>>> So what's the problem of original codes?
>>>>>
>>>>> Your change will cause issues that there's no place to set
>>>>> dcb_config as 0. If
>>>> you config dcb, then it'll be always dcb mode unless restart the whole
>> testpmd.
>>>>>
>>>> As far as I know, the current testpmd only supports switching from
>>>> the normal mode to the dcb mode, but does not support the reverse
>> operation.
>>>> And " dcb_config" is set to 1, and then "dcb_test" is set to 1 after
>>>> config.
>>>
>>> You're not answering my questions. Why are you changing the behavior of
>> testpmd?
>>> Your change will make testpmd stay dcb mode once set dcb mode and can't go
>> back to normal mode. If users want to go back to normal mode, he/she has to
>> restart the whole testpmd.
>>>
>> Yes. Testpmd and PMD driver are both in dcb mode after dcb info is configured.
>> In my opinion, the 'dcb_test' flag can't be clear to go back to normal mode after
>> stopping port and then starting port. Because PMD driver is still dcb mode. If
>> users want to go back it, users should disable dcb mode and enable RSS or other
>> mode.
>>
>>> It worked as you can set dcb mode and start port. After stopping port, if you
>> still want dcb mode, you need to set dcb mode command again. But at least the
>> old way won't break anything.
>>> @Yigit, Ferruh Not sure which behavior is better, what do you think?
>>>
>>> And @oulijun can you just answer all comments in one thread?
>>>
>> After stopping port, the 'dcb_test' flag is clear. At this moment, the dcb
>> configuration in testpmd has not be changed. users may not understand why
>> the DCB mode needs to be reconfigured.
>
> OK. You're right. There's no place writing port->dcb_flag back to 0.
>
Yes. Unless testpmd supports switching from DCB mode to other modes.
Do you have any other suggestions about this patch set, xiaoyun?
>>>>>> printf("Stopping ports...\n");
>>>>>>
>>>>>> RTE_ETH_FOREACH_DEV(pi) {
>>>>>> --
>>>>>> 2.7.4
>>>>>
>>>>> .
>>>>>
>>> _______________________________________________
>>> Linuxarm mailing list -- linuxarm@openeuler.org To unsubscribe send an
>>> email to linuxarm-leave@openeuler.org
>>>
next prev parent reply other threads:[~2021-03-27 3:54 UTC|newest]
Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-05 10:22 [dpdk-dev] [PATCH 0/3] Fixes for testpmd Lijun Ou
2021-03-05 10:22 ` [dpdk-dev] [PATCH 1/3] app/testpmd: fix forwarding configuration when DCB test Lijun Ou
2021-03-23 8:55 ` Li, Xiaoyun
2021-03-23 14:17 ` oulijun
2021-03-23 14:17 ` oulijun
2021-03-24 1:51 ` Li, Xiaoyun
2021-04-10 1:12 ` Ferruh Yigit
2021-04-10 2:53 ` oulijun
2021-03-23 14:18 ` oulijun
2021-03-24 2:03 ` Li, Xiaoyun
2021-03-24 13:40 ` [dpdk-dev] [Linuxarm] " oulijun
2021-03-25 2:21 ` Li, Xiaoyun
2021-03-27 3:53 ` oulijun [this message]
2021-04-10 0:56 ` Ferruh Yigit
2021-04-10 2:58 ` oulijun
2021-04-12 7:52 ` Ferruh Yigit
2021-04-12 12:20 ` oulijun
2021-03-05 10:22 ` [dpdk-dev] [PATCH 2/3] app/testpmd: remove forwarding config from parsing Rx and Tx Lijun Ou
2021-03-23 7:50 ` Li, Xiaoyun
2021-03-24 1:00 ` oulijun
2021-03-24 1:44 ` Li, Xiaoyun
2021-03-25 3:03 ` oulijun
2021-03-29 1:53 ` Li, Xiaoyun
2021-04-02 1:44 ` oulijun
2021-04-02 2:33 ` Li, Xiaoyun
2021-04-09 6:09 ` [dpdk-dev] [Linuxarm] " oulijun
2021-04-09 7:08 ` Li, Xiaoyun
2021-04-10 3:02 ` oulijun
2021-04-12 10:35 ` [dpdk-dev] " Ferruh Yigit
2021-04-12 12:20 ` oulijun
2021-03-05 10:22 ` [dpdk-dev] [PATCH 3/3] app/testpmd: use of Rx/Tx in testpmd Lijun Ou
2021-03-23 3:12 ` Li, Xiaoyun
2021-03-23 3:17 ` Li, Xiaoyun
2021-03-23 7:25 ` Andrew Rybchenko
2021-03-23 7:46 ` Tu, Lijuan
2021-03-23 7:51 ` oulijun
2021-03-23 7:58 ` Li, Xiaoyun
2021-03-23 10:42 ` Ferruh Yigit
2021-03-23 7:59 ` Tu, Lijuan
2021-03-20 1:19 ` [dpdk-dev] [PATCH 0/3] Fixes for testpmd Min Hu (Connor)
2021-04-20 7:31 ` [dpdk-dev] [PATCH V2 0/7] modifications about DCB forwarding configuration Huisong Li
2021-04-20 7:32 ` [dpdk-dev] [PATCH V2 1/7] app/testpmd: fix forward lcores number when DCB test Huisong Li
2021-04-27 9:20 ` Li, Xiaoyun
2021-04-27 13:49 ` Huisong Li
2021-04-28 2:13 ` Li, Xiaoyun
2021-04-20 7:32 ` [dpdk-dev] [PATCH V2 2/7] app/testpmd: fix DCB forwarding configuration Huisong Li
2021-04-20 7:32 ` [dpdk-dev] [PATCH V2 3/7] app/testpmd: fix a segment fault when DCB test Huisong Li
2021-04-20 7:32 ` [dpdk-dev] [PATCH V2 4/7] app/testpmd: add check for support of reporting DCB info Huisong Li
2021-04-20 7:32 ` [dpdk-dev] [PATCH V2 5/7] app/testpmd: move position of verifying DCB test Huisong Li
2021-04-20 7:32 ` [dpdk-dev] [PATCH V2 6/7] app/testpmd: add forwarding config in start port Huisong Li
2021-04-20 7:32 ` [dpdk-dev] [PATCH V2 7/7] app/testpmd: remove redundant fwd streams initialization Huisong Li
2021-04-20 7:35 ` [dpdk-dev] [PATCH 0/3] Fixes for testpmd Huisong Li
2021-04-20 9:00 ` [dpdk-dev] [PATCH V3 0/7] modifications about DCB forwarding configuration Huisong Li
2021-04-20 9:01 ` [dpdk-dev] [PATCH V3 1/7] app/testpmd: fix forward lcores number when DCB test Huisong Li
2021-04-27 10:18 ` Li, Xiaoyun
2021-04-20 9:01 ` [dpdk-dev] [PATCH V3 2/7] app/testpmd: fix DCB forwarding configuration Huisong Li
2021-04-27 10:59 ` Li, Xiaoyun
2021-04-27 14:13 ` Huisong Li
2021-04-20 9:01 ` [dpdk-dev] [PATCH V3 3/7] app/testpmd: fix a segment fault when DCB test Huisong Li
2021-04-27 11:19 ` Li, Xiaoyun
2021-04-27 14:10 ` Huisong Li
2021-04-28 2:02 ` Li, Xiaoyun
2021-04-28 2:26 ` Huisong Li
2021-04-20 9:01 ` [dpdk-dev] [PATCH V3 4/7] app/testpmd: add check for support of reporting DCB info Huisong Li
2021-04-27 11:26 ` Li, Xiaoyun
2021-04-20 9:01 ` [dpdk-dev] [PATCH V3 5/7] app/testpmd: move position of verifying DCB test Huisong Li
2021-04-27 11:33 ` Li, Xiaoyun
2021-04-20 9:01 ` [dpdk-dev] [PATCH V3 6/7] app/testpmd: add forwarding config in start port Huisong Li
2021-04-27 11:43 ` Li, Xiaoyun
2021-04-28 2:14 ` Huisong Li
2021-04-20 9:01 ` [dpdk-dev] [PATCH V3 7/7] app/testpmd: remove redundant fwd streams initialization Huisong Li
2021-04-27 11:50 ` Li, Xiaoyun
2021-04-28 6:40 ` [dpdk-dev] [PATCH V4 0/7] modifications about DCB forwarding configuration Huisong Li
2021-04-28 6:40 ` [dpdk-dev] [PATCH V4 1/7] app/testpmd: fix forward lcores number when DCB test Huisong Li
2021-04-28 6:40 ` [dpdk-dev] [PATCH V4 2/7] app/testpmd: fix DCB forwarding configuration Huisong Li
2021-04-28 6:40 ` [dpdk-dev] [PATCH V4 3/7] app/testpmd: fix a segment fault when DCB test Huisong Li
2021-04-28 6:40 ` [dpdk-dev] [PATCH V4 4/7] app/testpmd: add check for support of reporting DCB info Huisong Li
2021-04-28 6:40 ` [dpdk-dev] [PATCH V4 5/7] app/testpmd: move position of verifying DCB test Huisong Li
2021-04-28 6:40 ` [dpdk-dev] [PATCH V4 6/7] app/testpmd: add forwarding configuration when config DCB Huisong Li
2021-04-28 6:40 ` [dpdk-dev] [PATCH V4 7/7] app/testpmd: remove redundant fwd streams initialization Huisong Li
2021-04-28 7:01 ` [dpdk-dev] [PATCH V4 0/7] modifications about DCB forwarding configuration Li, Xiaoyun
2021-04-29 16:13 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01839804-cf22-56a9-40d8-2798a0dd1130@huawei.com \
--to=oulijun@huawei.com \
--cc=dev@dpdk.org \
--cc=linuxarm@openeuler.org \
--cc=xiaoyun.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).