DPDK patches and discussions
 help / color / mirror / Atom feed
From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Xueming Li <xuemingl@nvidia.com>, Matan Azrad <matan@nvidia.com>,
	Viacheslav Ovsiienko <viacheslavo@nvidia.com>
Cc: dev@dpdk.org, Asaf Penso <asafp@nvidia.com>
Subject: Re: [dpdk-dev] [v1] vdpa/mlx5: fix event channel setup
Date: Fri, 18 Sep 2020 11:41:47 +0200
Message-ID: <0185104f-b420-3afb-0a86-0bcea3c9e6d5@redhat.com> (raw)
In-Reply-To: <1598347048-25796-1-git-send-email-xuemingl@nvidia.com>



On 8/25/20 11:17 AM, Xueming Li wrote:
> During vdap device setup, if some error happens, event channel release

s/vdap/vDPA/

> stuck at polling event channel.
> 
> Event channel fd is set to nonblocking in cqe setup, so if any error

non-blocking

> happens before this function and after event channel created, the
> pooling before releasing resources will stuck.
> 
> This patch moves event channel to non-blocking mode right after
> creation.
> 
> Fixes: 8395927cdf ("vdpa/mlx5: prepare HW queues")
> Cc: matan@nvidia.com
> 
> Signed-off-by: Xueming Li <xuemingl@nvidia.com>
> ---
>  drivers/vdpa/mlx5/mlx5_vdpa_event.c | 15 ++++++++-------
>  1 file changed, 8 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/vdpa/mlx5/mlx5_vdpa_event.c b/drivers/vdpa/mlx5/mlx5_vdpa_event.c
> index 5a2d4fb1ec..bda547ffe0 100644
> --- a/drivers/vdpa/mlx5/mlx5_vdpa_event.c
> +++ b/drivers/vdpa/mlx5/mlx5_vdpa_event.c
> @@ -51,6 +51,8 @@ mlx5_vdpa_event_qp_global_release(struct mlx5_vdpa_priv *priv)
>  static int
>  mlx5_vdpa_event_qp_global_prepare(struct mlx5_vdpa_priv *priv)
>  {
> +	int flags, ret;
> +
>  	if (priv->eventc)
>  		return 0;
>  	if (mlx5_glue->devx_query_eqn(priv->ctx, 0, &priv->eqn)) {
> @@ -66,6 +68,12 @@ mlx5_vdpa_event_qp_global_prepare(struct mlx5_vdpa_priv *priv)
>  			rte_errno);
>  		goto error;
>  	}
> +	flags = fcntl(priv->eventc->fd, F_GETFL);
> +	ret = fcntl(priv->eventc->fd, F_SETFL, flags | O_NONBLOCK);
> +	if (ret) {
> +		DRV_LOG(ERR, "Failed to change event channel FD.");
> +		goto error;
> +	}
>  	priv->uar = mlx5_glue->devx_alloc_uar(priv->ctx, 0);
>  	if (!priv->uar) {
>  		rte_errno = errno;
> @@ -376,7 +384,6 @@ mlx5_vdpa_interrupt_handler(void *cb_arg)
>  int
>  mlx5_vdpa_cqe_event_setup(struct mlx5_vdpa_priv *priv)
>  {
> -	int flags;
>  	int ret;
>  
>  	if (!priv->eventc)
> @@ -393,12 +400,6 @@ mlx5_vdpa_cqe_event_setup(struct mlx5_vdpa_priv *priv)
>  			return -1;
>  		}
>  	}
> -	flags = fcntl(priv->eventc->fd, F_GETFL);
> -	ret = fcntl(priv->eventc->fd, F_SETFL, flags | O_NONBLOCK);
> -	if (ret) {
> -		DRV_LOG(ERR, "Failed to change event channel FD.");
> -		goto error;
> -	}
>  	priv->intr_handle.fd = priv->eventc->fd;
>  	priv->intr_handle.type = RTE_INTR_HANDLE_EXT;
>  	if (rte_intr_callback_register(&priv->intr_handle,
> 

Looks good to me, I'll fix the typos while applying.

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime


  parent reply	other threads:[~2020-09-18  9:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-20 14:32 [dpdk-dev] [PATCH] " Xueming Li
2020-08-25  9:17 ` [dpdk-dev] [v1] " Xueming Li
2020-08-30  8:17   ` Matan Azrad
2020-09-18  9:41   ` Maxime Coquelin [this message]
2020-09-18 11:14     ` Xueming(Steven) Li
2020-09-18 12:28   ` Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0185104f-b420-3afb-0a86-0bcea3c9e6d5@redhat.com \
    --to=maxime.coquelin@redhat.com \
    --cc=asafp@nvidia.com \
    --cc=dev@dpdk.org \
    --cc=matan@nvidia.com \
    --cc=viacheslavo@nvidia.com \
    --cc=xuemingl@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git