From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 8C90EA0A0C;
	Fri,  2 Jul 2021 11:27:24 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 117B841353;
	Fri,  2 Jul 2021 11:27:24 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id 8E9C340686
 for <dev@dpdk.org>; Fri,  2 Jul 2021 11:27:22 +0200 (CEST)
Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 04E047F519;
 Fri,  2 Jul 2021 12:27:22 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 04E047F519
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1625218042;
 bh=VNspozDdujKcHxpmB6YVXFCcxI3n88buLaZTlMxhodM=;
 h=Subject:To:References:From:Date:In-Reply-To;
 b=UIaukS7mJKu7EMzQ3N0bNPtrVeoKGzEEQG6gdau3L83KEVjU2urA0yJt7f1futs+n
 i9bzx13s3WujzAdiwRSYkdBCTC9ON0SdKzwZmTU5C7ya1aP+4jMuAo5gqpRf854MK0
 mDwrDN5bOpIbjH9JPkIFPAZ1Cxd2n++vECqO9ClI=
To: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>, dev@dpdk.org
References: <cover.1622738751.git.rahul.lakkireddy@chelsio.com>
 <cover.1625157360.git.rahul.lakkireddy@chelsio.com>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Organization: OKTET Labs
Message-ID: <0185f854-8a9f-2c5f-9adb-83d49de80e3e@oktetlabs.ru>
Date: Fri, 2 Jul 2021 12:27:21 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <cover.1625157360.git.rahul.lakkireddy@chelsio.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v2 0/2] net/cxgbe: add support for xstats API
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 7/1/21 7:56 PM, Rahul Lakkireddy wrote:
> This series of patches add support to fetch port and queue stats via
> xstats API.
> 
> Patch 1 adds support to fetch port and queue stats via xstats API.

Fixed mulit-line comments to following DPDK coding style.
Just made it single-line.

> Patch 2 removes queue stats from basic stats since they're available
> via xstats API. Also removes RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS flag.
> 
> ---
> v2:
> - Perform explicit checks for NULL in conditions.
> - Use rte_strlcpy() instead of strcpy().
> 
> Rahul Lakkireddy (2):
>   net/cxgbe: add support for xstats API
>   net/cxgbe: remove queue stats from basic stats
> 
>  drivers/net/cxgbe/cxgbe_ethdev.c | 321 ++++++++++++++++++++++++++++---
>  1 file changed, 297 insertions(+), 24 deletions(-)
> 

Applied, thanks.