From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E0CACA09F6; Fri, 18 Dec 2020 03:43:03 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1CDA5CA2A; Fri, 18 Dec 2020 03:43:02 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id C4C2BCA1A for ; Fri, 18 Dec 2020 03:43:00 +0100 (CET) IronPort-SDR: O7uSXTgtTGC4IJFseSxR6xZTEHqMwYbNeBX53Yv1f7bXUYMa8qyHyPAify3gXRqjMOzyzdY/dC BZLZY45HPOWw== X-IronPort-AV: E=McAfee;i="6000,8403,9838"; a="155173899" X-IronPort-AV: E=Sophos;i="5.78,428,1599548400"; d="scan'208";a="155173899" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Dec 2020 18:42:58 -0800 IronPort-SDR: ruCg12G144RuwdM0YBk6WMUE8hVXu744dKRaI82hs8zkqQRtnhACskURD67CbmQh+qwapS72ve Ple+7f3ifIVg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,428,1599548400"; d="scan'208";a="558500012" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga006.fm.intel.com with ESMTP; 17 Dec 2020 18:42:58 -0800 Received: from shsmsx605.ccr.corp.intel.com (10.109.6.215) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 17 Dec 2020 18:42:57 -0800 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX605.ccr.corp.intel.com (10.109.6.215) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 18 Dec 2020 10:42:55 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.1713.004; Fri, 18 Dec 2020 10:42:55 +0800 From: "Guo, Jia" To: "Yang, SteveX" , "dev@dpdk.org" CC: "Lu, Wenzhuo" , "Xing, Beilei" , "Iremonger, Bernard" , "asomalap@amd.com" , "rahul.lakkireddy@chelsio.com" , "hemant.agrawal@nxp.com" , "sachin.saxena@oss.nxp.com" , "Wang, Haiyue" , "g.singh@nxp.com" , "xuanziyang2@huawei.com" , "cloud.wangxiaoyun@huawei.com" , "zhouguoyang@huawei.com" , "xavier.huwei@huawei.com" , "humin29@huawei.com" , "yisen.zhuang@huawei.com" , "oulijun@huawei.com" , "Wu, Jingjing" , "Yang, Qiming" , "Zhang, Qi Z" , "Xu, Rosen" , "sthotton@marvell.com" , "srinivasan@marvell.com" , "heinrich.kuhn@netronome.com" , "hkalra@marvell.com" , "jerinj@marvell.com" , "ndabilpuram@marvell.com" , "kirankumark@marvell.com" , "rmody@marvell.com" , "shshaikh@marvell.com" , "andrew.rybchenko@oktetlabs.ru" , "mczekaj@marvell.com" , "thomas@monjalon.net" , "Yigit, Ferruh" , "ivan.boule@6wind.com" , "Ananyev, Konstantin" , "samuel.gauthier@6wind.com" , "david.marchand@6wind.com" , "shahafs@mellanox.com" , "stephen@networkplumber.org" , "maxime.coquelin@redhat.com" , "olivier.matz@6wind.com" , "lihuisong@huawei.com" , "shreyansh.jain@nxp.com" , "wei.dai@intel.com" , "fengchunsong@huawei.com" , "chenhao164@huawei.com" , "tangchengchang@hisilicon.com" , "Zhang, Helin" , "yanglong.wu@intel.com" , "xiaolong.ye@intel.com" , "Xu, Ting" , "Li, Xiaoyun" , "Wei, Dan" , "Pei, Andy" , "vattunuru@marvell.com" , "skori@marvell.com" , "sony.chacko@qlogic.com" , "Richardson, Bruce" , "ivan.malov@oktetlabs.ru" , "rad@semihalf.com" , "slawomir.rosek@semihalf.com" , "kamil.rytarowski@caviumnetworks.com" , "Zhao1, Wei" , "Jiang, JunyuX" , "kumaras@chelsio.com" , "girish.nandibasappa@amd.com" , "rolf.neugebauer@netronome.com" , "alejandro.lucero@netronome.com" , "Yang, SteveX" Thread-Topic: [PATCH v2 05/22] net/e1000: fix the jumbo frame flag condition for mtu set Thread-Index: AQHW1Fc29pdikC6tEEmeP4livK07Han8JjQA Date: Fri, 18 Dec 2020 02:42:55 +0000 Message-ID: <01957a4255f64394967d5e6304e2e9e3@intel.com> References: <20201209031628.29572-1-stevex.yang@intel.com> <20201217092312.27033-1-stevex.yang@intel.com> <20201217092312.27033-6-stevex.yang@intel.com> In-Reply-To: <20201217092312.27033-6-stevex.yang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 05/22] net/e1000: fix the jumbo frame flag condition for mtu set X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Acked-by: Jeff Guo > -----Original Message----- > From: Steve Yang > Sent: Thursday, December 17, 2020 5:23 PM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; Xing, Beilei > ; Iremonger, Bernard > ; asomalap@amd.com; > rahul.lakkireddy@chelsio.com; hemant.agrawal@nxp.com; > sachin.saxena@oss.nxp.com; Guo, Jia ; Wang, Haiyue > ; g.singh@nxp.com; xuanziyang2@huawei.com; > cloud.wangxiaoyun@huawei.com; zhouguoyang@huawei.com; > xavier.huwei@huawei.com; humin29@huawei.com; > yisen.zhuang@huawei.com; oulijun@huawei.com; Wu, Jingjing > ; Yang, Qiming ; Zhang, Qi > Z ; Xu, Rosen ; > sthotton@marvell.com; srinivasan@marvell.com; > heinrich.kuhn@netronome.com; hkalra@marvell.com; jerinj@marvell.com; > ndabilpuram@marvell.com; kirankumark@marvell.com; > rmody@marvell.com; shshaikh@marvell.com; > andrew.rybchenko@oktetlabs.ru; mczekaj@marvell.com; > thomas@monjalon.net; Yigit, Ferruh ; > ivan.boule@6wind.com; Ananyev, Konstantin > ; samuel.gauthier@6wind.com; > david.marchand@6wind.com; shahafs@mellanox.com; > stephen@networkplumber.org; maxime.coquelin@redhat.com; > olivier.matz@6wind.com; lihuisong@huawei.com; shreyansh.jain@nxp.com; > wei.dai@intel.com; fengchunsong@huawei.com; chenhao164@huawei.com; > tangchengchang@hisilicon.com; Zhang, Helin ; > yanglong.wu@intel.com; xiaolong.ye@intel.com; Xu, Ting > ; Li, Xiaoyun ; Wei, Dan > ; Pei, Andy ; > vattunuru@marvell.com; skori@marvell.com; sony.chacko@qlogic.com; > Richardson, Bruce ; ivan.malov@oktetlabs.ru; > rad@semihalf.com; slawomir.rosek@semihalf.com; > kamil.rytarowski@caviumnetworks.com; Zhao1, Wei ; > Jiang, JunyuX ; kumaras@chelsio.com; > girish.nandibasappa@amd.com; rolf.neugebauer@netronome.com; > alejandro.lucero@netronome.com; Yang, SteveX > Subject: [PATCH v2 05/22] net/e1000: fix the jumbo frame flag condition f= or > mtu set >=20 > The jumbo frame uses the 'RTE_ETHER_MAX_LEN' as boundary condition, > but the Ether overhead is larger than 18 when it supports VLAN tag. That = will > cause the jumbo flag rx offload is wrong when MTU size is 'RTE_ETHER_MTU'= . >=20 > This fix will change the boundary condition with 'RTE_ETHER_MTU' and > overhead. >=20 > Fixes: ef990fb56e55 ("net/e1000: convert to new Rx offloads API") >=20 > Signed-off-by: Steve Yang > --- > drivers/net/e1000/e1000_ethdev.h | 2 +- > drivers/net/e1000/em_ethdev.c | 5 ++--- > drivers/net/e1000/igb_ethdev.c | 2 +- > 3 files changed, 4 insertions(+), 5 deletions(-) >=20 > diff --git a/drivers/net/e1000/e1000_ethdev.h > b/drivers/net/e1000/e1000_ethdev.h > index 4755a5f333..3b4d9c3ee6 100644 > --- a/drivers/net/e1000/e1000_ethdev.h > +++ b/drivers/net/e1000/e1000_ethdev.h > @@ -97,7 +97,7 @@ > */ > #define E1000_ETH_OVERHEAD (RTE_ETHER_HDR_LEN + > RTE_ETHER_CRC_LEN + \ > VLAN_TAG_SIZE) > - > +#define E1000_ETH_MAX_LEN (RTE_ETHER_MTU + E1000_ETH_OVERHEAD) > /* > * Maximum number of Ring Descriptors. > * > diff --git a/drivers/net/e1000/em_ethdev.c > b/drivers/net/e1000/em_ethdev.c index 8ee9422bf4..2036c6e917 100644 > --- a/drivers/net/e1000/em_ethdev.c > +++ b/drivers/net/e1000/em_ethdev.c > @@ -1799,8 +1799,7 @@ eth_em_mtu_set(struct rte_eth_dev *dev, > uint16_t mtu) > if (ret !=3D 0) > return ret; >=20 > - frame_size =3D mtu + RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN + > - VLAN_TAG_SIZE; > + frame_size =3D mtu + E1000_ETH_OVERHEAD; >=20 > /* check that mtu is within the allowed range */ > if (mtu < RTE_ETHER_MIN_MTU || frame_size > > dev_info.max_rx_pktlen) @@ -1816,7 +1815,7 @@ eth_em_mtu_set(struct > rte_eth_dev *dev, uint16_t mtu) > rctl =3D E1000_READ_REG(hw, E1000_RCTL); >=20 > /* switch to jumbo mode if needed */ > - if (frame_size > RTE_ETHER_MAX_LEN) { > + if (frame_size > E1000_ETH_MAX_LEN) { > dev->data->dev_conf.rxmode.offloads |=3D > DEV_RX_OFFLOAD_JUMBO_FRAME; > rctl |=3D E1000_RCTL_LPE; > diff --git a/drivers/net/e1000/igb_ethdev.c > b/drivers/net/e1000/igb_ethdev.c index 647aa8d995..dfe87508c2 100644 > --- a/drivers/net/e1000/igb_ethdev.c > +++ b/drivers/net/e1000/igb_ethdev.c > @@ -4369,7 +4369,7 @@ eth_igb_mtu_set(struct rte_eth_dev *dev, > uint16_t mtu) > rctl =3D E1000_READ_REG(hw, E1000_RCTL); >=20 > /* switch to jumbo mode if needed */ > - if (frame_size > RTE_ETHER_MAX_LEN) { > + if (frame_size > E1000_ETH_MAX_LEN) { > dev->data->dev_conf.rxmode.offloads |=3D > DEV_RX_OFFLOAD_JUMBO_FRAME; > rctl |=3D E1000_RCTL_LPE; > -- > 2.17.1