From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id C0573590E for ; Tue, 25 Oct 2016 04:11:55 +0200 (CEST) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP; 24 Oct 2016 19:11:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,544,1473145200"; d="scan'208";a="23245328" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga005.fm.intel.com with ESMTP; 24 Oct 2016 19:11:54 -0700 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 24 Oct 2016 19:11:54 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 24 Oct 2016 19:11:53 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.206]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.139]) with mapi id 14.03.0248.002; Tue, 25 Oct 2016 10:11:52 +0800 From: "Guo, Jia" To: "Wu, Jingjing" , "Zhang, Helin" CC: "dev@dpdk.org" , "Yigit, Ferruh" Thread-Topic: [PATCH] net/i40e: fix the hash filter invalid calculation in X722 Thread-Index: AQHSKnwjyapZKkEeZ0q3iioG1AYdHaC20bkAgAGh5oA= Date: Tue, 25 Oct 2016 02:11:51 +0000 Message-ID: <01BA8470C017D6468C8290E4B9C5E1E838FB7700@shsmsx102.ccr.corp.intel.com> References: <1476582005-110811-2-git-send-email-jia.guo@intel.com> <1476931738-44140-1-git-send-email-jia.guo@intel.com> <9BB6961774997848B5B42BEC655768F80E293A6B@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <9BB6961774997848B5B42BEC655768F80E293A6B@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix the hash filter invalid calculation in X722 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Oct 2016 02:11:56 -0000 I will refine the commit log. Other hand, since the issue is not directly = related with prior patch, it just because some nic type adding request some= special behavior handle. So it is reported issue fix, but may be have not = corresponding fix line. Thanks jingjing's review.=20 Best regards, Jeff Guo -----Original Message----- From: Wu, Jingjing=20 Sent: Monday, October 24, 2016 5:10 PM To: Guo, Jia ; Zhang, Helin Cc: dev@dpdk.org; Yigit, Ferruh Subject: RE: [PATCH] net/i40e: fix the hash filter invalid calculation in X= 722 > -----Original Message----- > From: Guo, Jia > Sent: Thursday, October 20, 2016 10:49 AM > To: Zhang, Helin ; Wu, Jingjing=20 > > Cc: dev@dpdk.org; Guo, Jia ; Yigit, Ferruh=20 > > Subject: [PATCH] net/i40e: fix the hash filter invalid calculation in=20 > X722 >=20 > As X722 extracts IPv4 header to Field Vector different with=20 > XL710/X710, need to corresponding to modify the fields of IPv4 header=20 > in input set to map different default Field Vector Table of different NIC= s. > Signed-off-by: Jeff Guo > --- > v3: > remove the x722 macro > v2: > fix compile error when x722 macro is not defined and simplify the code=20 > to avoid duplication. > --- > drivers/net/i40e/i40e_ethdev.c | 60=20 > +++++++++++++++++++++++++++++++++--------- > 1 file changed, 47 insertions(+), 13 deletions(-) >=20 How about change the commit log it like: When verifying the Hash filtering on X722, we found the behavior was not ex= pected. For example, the hash value in descriptor is incorrect. That was because X722 uses different way of hash key word selection compari= ng with X710/XL710. This patch fixes it by setting X722 specific key selection. And few minor comments: If this is not the first patch, please use [PATCH v3] instead of [PATCH]. And the fixes line is missed. Thanks Jingijng