From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 3CBF01094; Thu, 23 Mar 2017 04:55:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1490241342; x=1521777342; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=WmEp33tTYWNeaNFp8BCFciYOmk51M71SZefrKSoyqVA=; b=TFd5T9TV15kPdVDr8ItttHhOGxtP1wUOTVheD9ViuypOhwvUCdNkK/lE OQ8twa90Kx9rlyj3zYzB30og6aWzSg==; Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Mar 2017 20:55:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,208,1486454400"; d="scan'208";a="1145880787" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga002.fm.intel.com with ESMTP; 22 Mar 2017 20:55:39 -0700 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 22 Mar 2017 20:55:39 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 22 Mar 2017 20:55:39 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.88]) by SHSMSX103.ccr.corp.intel.com ([10.239.4.69]) with mapi id 14.03.0248.002; Thu, 23 Mar 2017 11:55:37 +0800 From: "Guo, Jia" To: "Wu, Jingjing" , "Zhang, Helin" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [dpdk-dev v2 3/3] test: enable HW CRC strip by default Thread-Index: AQHSoWDLFTAPvzUXUEaQnJU7V1FZFaGgRkeAgAGJayA= Date: Thu, 23 Mar 2017 03:55:36 +0000 Message-ID: <01BA8470C017D6468C8290E4B9C5E1E83B1E2ADF@shsmsx102.ccr.corp.intel.com> References: <1490003874-37766-1-git-send-email-jia.guo@intel.com> <1490003874-37766-3-git-send-email-jia.guo@intel.com> <9BB6961774997848B5B42BEC655768F810CF987F@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <9BB6961774997848B5B42BEC655768F810CF987F@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [dpdk-dev v2 3/3] test: enable HW CRC strip by default X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Mar 2017 03:55:44 -0000 Accept that, and will send v3 to fix it. Thanks for review. Best regards, Jeff Guo -----Original Message----- From: Wu, Jingjing=20 Sent: Wednesday, March 22, 2017 8:27 PM To: Guo, Jia ; Zhang, Helin Cc: dev@dpdk.org; stable@dpdk.org Subject: RE: [dpdk-dev v2 3/3] test: enable HW CRC strip by default > -----Original Message----- > From: Guo, Jia > Sent: Monday, March 20, 2017 5:58 PM > To: Zhang, Helin ; Wu, Jingjing=20 > > Cc: dev@dpdk.org; Guo, Jia ; stable@dpdk.org > Subject: [dpdk-dev v2 3/3] test: enable HW CRC strip by default >=20 > Since VF has no ability to disable/enable HW CRC strip for non-DPDK PF=20 > drivers, and for most case of kernel driver default enable HW CRC=20 > strip, if disable HW CRC strip in test app's rxmode, VF driver will=20 > return fail and result the VF launch failure. So this patch default to en= able HW CRC strip to let VF launch successful. >=20 > Signed-off-by: Jeff Guo > Cc: stable@dpdk.org > --- > test/test-pipeline/init.c | 2 +- > test/test/test_kni.c | 2 +- > test/test/test_link_bonding.c | 4 ++-- > test/test/test_link_bonding_mode4.c | 2 +- > test/test/test_link_bonding_rssconf.c | 4 ++-- > test/test/test_pmd_perf.c | 2 +- > 6 files changed, 8 insertions(+), 8 deletions(-) >=20 > diff --git a/test/test-pipeline/init.c b/test/test-pipeline/init.c=20 > index > aef082f..00dbc27 100644 > --- a/test/test-pipeline/init.c > +++ b/test/test-pipeline/init.c > @@ -105,7 +105,7 @@ static struct rte_eth_conf port_conf =3D { > .hw_ip_checksum =3D 1, /* IP checksum offload enabled */ > .hw_vlan_filter =3D 0, /* VLAN filtering disabled */ > .jumbo_frame =3D 0, /* Jumbo Frame Support disabled */ > - .hw_strip_crc =3D 0, /* CRC stripped by hardware */ > + .hw_strip_crc =3D 1, /* CRC stripped by hardware */ > }, > .rx_adv_conf =3D { > .rss_conf =3D { > diff --git a/test/test/test_kni.c b/test/test/test_kni.c index=20 > 309741c..db17fdf > 100644 > --- a/test/test/test_kni.c > +++ b/test/test/test_kni.c > @@ -92,7 +92,7 @@ static const struct rte_eth_conf port_conf =3D { > .hw_ip_checksum =3D 0, > .hw_vlan_filter =3D 0, > .jumbo_frame =3D 0, > - .hw_strip_crc =3D 0, > + .hw_strip_crc =3D 1, > }, > .txmode =3D { > .mq_mode =3D ETH_DCB_NONE, > diff --git a/test/test/test_link_bonding.c=20 > b/test/test/test_link_bonding.c index 3229660..3a1194c 100644 > --- a/test/test/test_link_bonding.c > +++ b/test/test/test_link_bonding.c > @@ -172,7 +172,7 @@ struct rte_eth_rxmode rx_mode =3D { > .hw_vlan_strip =3D 1, /**< VLAN strip enabled. */ > .hw_vlan_extend =3D 0, /**< Extended VLAN disabled. */ > .jumbo_frame =3D 0, /**< Jumbo Frame Support disabled. */ > - .hw_strip_crc =3D 0, /**< CRC stripping by hardware disabled. */ > + .hw_strip_crc =3D 1, /**< CRC stripping by hardware disabled. */ > }; Comment "/**< CRC stripping by hardware disabled. */" need to be Changed to= o.