From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1A697A0547; Thu, 21 Oct 2021 10:30:44 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8E3D94118E; Thu, 21 Oct 2021 10:30:43 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id DDDAA40142 for ; Thu, 21 Oct 2021 10:30:42 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 3FF3E7F529; Thu, 21 Oct 2021 11:30:42 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 3FF3E7F529 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1634805042; bh=h4U7zVgxv4Dt3xj72HCJKDGRlBQ08XpKJwjdy1UOhIQ=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=j923KPs4I14H4aDo8uUnzNZgU1fs7ldOqhRaSL/c9JhY08Hiwc7f7/yXh82r074az PWyz3XzVJVifGT2DF6iklHqCn5wqTfYI45JsJ6AwINKkFyvGrG1tWQniLMjWifz8Ml 5RF55sBrJwZZUhisFl3Au2V8CpMX/QgNJqs/PDWs= To: "Wang, Jie1X" , "dev@dpdk.org" Cc: "Yigit, Ferruh" , NBU-Contact-Thomas Monjalon , "Li, Xiaoyun" , "Yang, SteveX" , "Wu, Jingjing" , "Xing, Beilei" , "Wu, Wenjun1" , "Zhang, Qi Z" , Ori Kam References: <20211020093224.1410449-1-jie1x.wang@intel.com> <20211021062603.1549268-1-jie1x.wang@intel.com> <20211021062603.1549268-2-jie1x.wang@intel.com> From: Andrew Rybchenko Organization: OKTET Labs Message-ID: <01b96476-2090-5814-3718-4c62dd35c047@oktetlabs.ru> Date: Thu, 21 Oct 2021 11:30:42 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v7 1/3] ethdev: support L2TPv2 and PPP procotol X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/21/21 11:28 AM, Wang, Jie1X wrote: > > >> -----Original Message----- >> From: Andrew Rybchenko >> Sent: Thursday, October 21, 2021 3:53 PM >> To: Wang, Jie1X ; dev@dpdk.org >> Cc: Yigit, Ferruh ; NBU-Contact-Thomas Monjalon >> ; Li, Xiaoyun ; Yang, SteveX >> ; Wu, Jingjing ; Xing, Beilei >> ; Wu, Wenjun1 ; Zhang, Qi Z >> ; Ori Kam >> Subject: Re: [PATCH v7 1/3] ethdev: support L2TPv2 and PPP procotol >> >> On 10/21/21 10:50 AM, Ori Kam wrote: >>> Hi Jie, >>> >>>> -----Original Message----- >>>> From: Jie Wang >>>> Sent: Thursday, October 21, 2021 9:26 AM >>>> Subject: [PATCH v7 1/3] ethdev: support L2TPv2 and PPP procotol >>>> >>>> Added flow pattern items and header formats of L2TPv2 and PPP. >>>> >>>> Signed-off-by: Wenjun Wu >>>> Signed-off-by: Jie Wang >> >> [snip] >> >>>> diff --git a/doc/guides/nics/features/iavf.ini >> b/doc/guides/nics/features/iavf.ini >>>> index d00ca934c3..a916275b88 100644 >>>> --- a/doc/guides/nics/features/iavf.ini >>>> +++ b/doc/guides/nics/features/iavf.ini >>>> @@ -50,8 +50,10 @@ icmp6 = Y >>>> ipv4 = Y >>>> ipv6 = Y >>>> ipv6_frag_ext = Y >>>> +l2tpv2 = Y >>>> l2tpv3oip = Y >>>> pfcp = Y >>>> +ppp = Y >> >> It must be added in the patch when driver support is added. >> > > Hi Andrew, > > I don't understand what you're saying. Could you describe it in more detail? The patch is an ethdev patch which defines the feature. When just the patch is applied, the driver iavf does not support it yet. Support is added in a later patch of the patch series. So, you should claim support in the driver when support is actually added. > >>>> sctp = Y >>>> tcp = Y >>>> udp = Y >> >> [snip]