From: Akhil Goyal <akhil.goyal@nxp.com>
To: Radu Nicolau <radu.nicolau@intel.com>, dev@dpdk.org
Cc: akhil.goyal@nxp.com, pablo.de.lara.guarch@intel.com, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3] examples/ipsec-secgw: limit inflight packets count
Date: Wed, 9 May 2018 17:32:29 +0530 [thread overview]
Message-ID: <01c2959d-1214-3309-b943-d08d4c20d5e5@nxp.com> (raw)
In-Reply-To: <1525856321-27612-1-git-send-email-radu.nicolau@intel.com>
On 5/9/2018 2:28 PM, Radu Nicolau wrote:
> Revert previous patch that introduce a performance
> degradation in certain scenarios and add a configurable
> limit for number inflight packets.
>
> Revert
> commit 84d4b5e4ec48 ("examples/ipsec-secgw: improve IPsec dequeue logic")
> Cc: stable@dpdk.org
>
> Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
> ---
> v3: updated enqueue size trim computation
>
> examples/ipsec-secgw/ipsec.c | 32 +++++++++++++++-----------------
> examples/ipsec-secgw/ipsec.h | 1 +
> 2 files changed, 16 insertions(+), 17 deletions(-)
>
> diff --git a/examples/ipsec-secgw/ipsec.c b/examples/ipsec-secgw/ipsec.c
> index ee24973..1929752 100644
> --- a/examples/ipsec-secgw/ipsec.c
> +++ b/examples/ipsec-secgw/ipsec.c
> @@ -348,13 +348,19 @@ create_session(struct ipsec_ctx *ipsec_ctx, struct ipsec_sa *sa)
> static inline void
> enqueue_cop(struct cdev_qp *cqp, struct rte_crypto_op *cop)
> {
> - int32_t ret, i;
> + int32_t ret = 0, i;
>
> cqp->buf[cqp->len++] = cop;
>
> if (cqp->len == MAX_PKT_BURST) {
> - ret = rte_cryptodev_enqueue_burst(cqp->id, cqp->qp,
> - cqp->buf, cqp->len);
> + int enq_size = cqp->len;
> + if ((cqp->in_flight + enq_size) >= MAX_INFLIGHT)
This should be ((cqp->in_flight + enq_size) > MAX_INFLIGHT). there Will
be one extra operation in case it is equal.
Otherwise,
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
next prev parent reply other threads:[~2018-05-09 12:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-03 11:07 [dpdk-dev] [PATCH] " Radu Nicolau
2018-05-09 8:56 ` [dpdk-dev] [PATCH v2] " Radu Nicolau
2018-05-09 8:58 ` [dpdk-dev] [PATCH v3] " Radu Nicolau
2018-05-09 12:02 ` Akhil Goyal [this message]
2018-05-09 15:02 ` De Lara Guarch, Pablo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01c2959d-1214-3309-b943-d08d4c20d5e5@nxp.com \
--to=akhil.goyal@nxp.com \
--cc=dev@dpdk.org \
--cc=pablo.de.lara.guarch@intel.com \
--cc=radu.nicolau@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).