From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20065.outbound.protection.outlook.com [40.107.2.65]) by dpdk.org (Postfix) with ESMTP id 3714C7E93; Wed, 9 May 2018 14:02:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=0rjtO0QSfltu45jHfT1KWiE/FkT+WzHkNz8Toqk9baI=; b=QC6/pMU8lgHhIYa6o98/6yY+5IjQpzVFMPjfbzO9pKyrqzQ+elMcmzbiC6mepfIWF43vpkym7yzx2jSQAf8BEnWP/crsgGdSpTtXNl8ZBxhY0MlMmbf2U96axsqElCCXlVITHbE2Uxub9e3rCekhL0tRP3nVzoOaRrQ8IKtAP60= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; Received: from [10.232.134.49] (14.142.187.166) by HE1PR04MB1386.eurprd04.prod.outlook.com (2a01:111:e400:535b::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.755.16; Wed, 9 May 2018 12:02:42 +0000 To: Radu Nicolau , dev@dpdk.org References: <1525856209-27513-1-git-send-email-radu.nicolau@intel.com> <1525856321-27612-1-git-send-email-radu.nicolau@intel.com> Cc: akhil.goyal@nxp.com, pablo.de.lara.guarch@intel.com, stable@dpdk.org From: Akhil Goyal Organization: NXP Message-ID: <01c2959d-1214-3309-b943-d08d4c20d5e5@nxp.com> Date: Wed, 9 May 2018 17:32:29 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1525856321-27612-1-git-send-email-radu.nicolau@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [14.142.187.166] X-ClientProxiedBy: BM1PR01CA0077.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:1::17) To HE1PR04MB1386.eurprd04.prod.outlook.com (2a01:111:e400:535b::16) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(5600026)(48565401081)(2017052603328)(7153060)(7193020); SRVR:HE1PR04MB1386; X-Microsoft-Exchange-Diagnostics: 1; HE1PR04MB1386; 3:bUBuOXfIZlAWbozvxYjilDM88Ghx4JAhGVr38LIH5TjGZHlgklw8bj4KoFKb0NsG9BtEKD3xez6QPChWmEqzDpLVAfbKVO98ftkwKl96tPoLbBr1SXNYJi74jV3DruaUhSpk8i9aFeD2omjn7vUXyvQxkXyiMRSYizYTlmkM2N8PCsai1XJ49khqrApb44eaWGooG1v2sr5RcKjv5tUP8a6bNZ0mU3oewYXiCh/7vVFYpgqi4Sb8wY0E3hocJ+6a; 25:8UEq25BZnP78qJfzWH7UFV66idVFB7ebM3gNxHtWnmxtBRd70wTKYSpY6unQawaD1yJecOXkbisPyW+5uO/+6AnZFw90e5oJd+mi/CIFci/edUlsfLst2Rm4ufaWcq2e5vgXzijzFHdR7fB8fkeYHZ85Nw5F4vlYNWnQaBD7Ld3GCMq0EUxQaL2x3s3R+62P7wYjhRNoQlqTy23nVsU0cCob8xJ51PA/jn6W8s+0g4cJM6dVeJBWRh85EZwAPhx2QKpG/j6xdpa0VtyBXG7NeOdVOwxwyjv7kpqEW6w2w+O30pvt9ZJG+x3LMfSQdQ9MVIla4PpGXsnUxapxmUuJgQ==; 31:unqzdGzXEhdFlR1yic5MPYCuRG6xnXfaXd95cTawRdEF+WrwQhmfKaXNspyFvI+pqlAErmwurIgFSBl3Yz8g1DybM0+5kM+5NVJ39HV+dbhIMY2zp3vjR0vlfm08JnWSiW2gYqUA6q9CCckKjVLjrKFo9HdplaObejVr1b9aj3EkSI7P7VaF7d0WawEzbBUqmJ8jzoXhvnHIyseZi+xjEf8Q7JV2zJml6KAcBb8Pfs8= X-MS-TrafficTypeDiagnostic: HE1PR04MB1386: X-Microsoft-Exchange-Diagnostics: 1; HE1PR04MB1386; 20:RO0cPagZ+C0hYKl8sqds7SOMsdyb16C7YzwUPCXg+AVIDThbnhi0W2gW1AY+F+3XXk3pIYCpSocDbIPFpGy4XkB3KWVi+rRmCu8GVRvHvunJMfBRRZGko1hj0DiM4udkfvfcCIHUE97LIFgfOYER7SXa8FYeCoZX0rRr5+Y43BARDEngBAvy95NnRUbWNmeY7QUKSTOhn1EFTBWfQE3pbNhLyFqKt6M4QtD4C+YTxnDTn7PMhu4FPycJYKPR3oJajFmiYEnUPBd4aHbklLYoxBYefjXHREqlP+P5WUE6oatMzHabwLGQZ0Laz0lK+4BRP+NatqeSCMUewsMLmPLVNwoDFUNaVFpgzaS2iMdxQzYEE0evjk3QINDVY2EXTJCnkRGkM3AqcdXpHhzns5vetMy6wxbjSiTSCH6CoeEda4aMzqOkstJqRn/jGM2gSvV1Zn5/P+hwzF9mdz/nJ6uSp5of6kzC9saUlnoLrFyv9Sn4uhva2X2ei6msUO75Dxlg; 4:gE1Y3aQk5SSSDSWtenLlDpFHAsFv2/Yrd6T8kVC3b+AzhXiO+P/ZU88hZWuFa7EgHXFQbDNj1is8/BTkl4m9R1tQ6pOavn1qXILyUH1nunx8Fw3Z9BYVrRcZas/K9uTEGBq2d+hdyJ6sFKVkaf6w93BjuoCbkmY8SgLyL01eTJZOkUv2SlQPq3fuAQPDzwdsGQc0a7HyK1v79R9pY48R3+x+Z2+bilL8hwMQZ5CrKphn7rcrexfwE8B6dKrjBBT+nzAmEQZ6PkvR3U5OunWHFOyYIBD/cULajf/WbMTaGNBkkbl/BCbe2vIdus4UL99lmtdT5GgWKWq0ARJc9r8DXJ/6rIuMEYq5OH2MMBMAKRA= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(228905959029699); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231254)(944501410)(52105095)(3002001)(93006095)(93001095)(10201501046)(6055026)(149027)(150027)(6041310)(20161123562045)(20161123558120)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:HE1PR04MB1386; BCL:0; PCL:0; RULEID:; SRVR:HE1PR04MB1386; X-Forefront-PRVS: 0667289FF8 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6049001)(346002)(366004)(376002)(39860400002)(39380400002)(396003)(189003)(199004)(44832011)(16576012)(81166006)(97736004)(65826007)(8676002)(81156014)(478600001)(2616005)(956004)(76176011)(229853002)(6666003)(6486002)(23746002)(7736002)(64126003)(16526019)(8936002)(305945005)(26005)(186003)(77096007)(2906002)(486006)(476003)(3260700006)(11346002)(5660300001)(446003)(25786009)(4326008)(50466002)(106356001)(86362001)(36916002)(58126008)(53936002)(52116002)(36756003)(6246003)(105586002)(31696002)(31686004)(55236004)(68736007)(5009440100003)(53546011)(386003)(230700001)(6116002)(65806001)(66066001)(3846002)(65956001)(67846002)(47776003)(316002)(59450400001)(110426005); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR04MB1386; H:[10.232.134.49]; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; HE1PR04MB1386; 23:fBvPtPL/hAcxPocBxz3hACcM+RcAa1uThO8Fi?= =?Windows-1252?Q?tTeobY/rVrrQf4aSTuyq2VA0CrSu69ftUB2tGVRktS9R4UrujrBUsJUJ?= =?Windows-1252?Q?xkpz7RpMt4BnoZrD99is+++Hsv5Zvus+cqcpXs0DRhoZhG091b60aVlU?= =?Windows-1252?Q?qe9c5t1T8xKUqloctjIoXIViSqSJEngLNdBcqPO14u0NM/8a6jkmoYAt?= =?Windows-1252?Q?VzI2ulYPlT5k8qFW4Z/xCi43UQT30aSawRhvWtuhaAPcPi4zgvh7Z/+y?= =?Windows-1252?Q?Hivq524fm7GxdFIyDmkn8D/bZrJ+bbyLnNLE95ePMBy44qchoIjZRco3?= =?Windows-1252?Q?RBuCvuZe5DCzTsZXFVFIGtU7hg2jUkF5G+yE2U1VOqFBvOWVY+oKNjgz?= =?Windows-1252?Q?IzbvxCDgI8GZslUI4c8TXlA/XCZ+1PTQxO+sk5R0HdWuxrOLviFE7u8o?= =?Windows-1252?Q?aY3A+vsmbDwC7mvxvJy4pQ29Sz6VND+kqejgp/S0B2DoEEQsZYV0WBnn?= =?Windows-1252?Q?6+yf7AJFOSRXQzR0Bmks+2OQ9m2TzJ3PK5H1EeKzS5+DY6lHJBsr0waR?= =?Windows-1252?Q?AMcNIKzqoYmM2LeBstNLFa8IJYi65DpZoRzmJpXc8rfyc9bqwpgCtOzt?= =?Windows-1252?Q?Og/817B7hBkJEDXYtdqdAhkP3zRGNq3+ZI28G89O1aFS9zWDO8QiOyWt?= =?Windows-1252?Q?s6uXTrHd6SCJb5N/ObJjkJ031g6ZitN92VxixIx5fYuUqR9q1zQtrxHP?= =?Windows-1252?Q?6gjTo2q9fySxRSwIf/ojKlviVMbV91yX791VlKjUV45kWVzVxMACqzR+?= =?Windows-1252?Q?bnZ2wdO3QNM9RQwgtGstVT0dQAceqOEWV3PCAUVKeBXnmpJPE0OnSoW8?= =?Windows-1252?Q?jwitFmuLbj1CS73QGo1YWWwU8fCk3zXDjcb0812CF38vArESpep6IPad?= =?Windows-1252?Q?ZAwTX5Db9GnMctvFHFUjoskuyQ0eTVxVtIr54CcOEa4DTsTvFKNUXQKi?= =?Windows-1252?Q?lNfS8/ZvbZaQ6M6hZ8QZVnP45UZducInuOGHKvtl36nWI2njz2Wcg8K7?= =?Windows-1252?Q?SaCWvnBW2RcqnxDe9CIodb8eZGKh1T59+MZH1a03Tci7O45qBkLhw6m2?= =?Windows-1252?Q?FAZIEvuAM40SaArmvG1b5r4FQunDjJwR3Ug0Wq5IZmZ9lEYaB+Q48ZDf?= =?Windows-1252?Q?lj6D0fckdsG/fJ4MYnrAqrjIVA+35LXSo1KaOdHG8t+0hpGMYJp6C3p8?= =?Windows-1252?Q?89OoIv0OsgaLYFqNHR0IApWGxqUHC8cy2EmsLkmWEaUWs1pQobN0Bxrm?= =?Windows-1252?Q?yKwT5gn/v8mOnv52YmLnvzGTCNeHR3KsBCAze1kmBin0P4cIG2cwiW78?= =?Windows-1252?Q?8TABI0PPsysvlH4l3JsXsCzUR1AmtZMyli4In7rFWQkYd/NaHD9O95/v?= =?Windows-1252?Q?beJyR1/k4WAey3Nb/OlQIopW3gK4JQhk7zDl1tsRTp/UL/YrNcbYrGP2?= =?Windows-1252?Q?S9u4HoKvm59PkvhP0Hz7oYhI4rXF261TPLWjvGnNU+4BzuAgzNasuUSK?= =?Windows-1252?Q?Zefx1DL7z02IQyDkq2yXAbnio49O4zUSycLrIl/priE1Nw2XgC77pJvv?= =?Windows-1252?Q?zhFp30FOqejgZJo7dOa37yHNAbqsKZf/WN6mlijmeiFmTX6vgE0JTqVk?= =?Windows-1252?Q?kO6H7OOZw=3D=3D?= X-Microsoft-Antispam-Message-Info: 0apcpFyhpnJsgCJuw4iN3nWXg2cKJeUU1QJF9yP+rQqUql/wT/HF2bJ2dIgojhnGI4XlCf7bj2sLMqTTyWBgjlZeUwNM7APh77PcZ1sgJcIQUXt3H3PSKr6jpNMwu9KRnOHJRG7NKodRYI6V85zyaXQxkV6eHy0/vheOHDpi4ZHSfuychIz1h365bTExhl2I X-Microsoft-Exchange-Diagnostics: 1; HE1PR04MB1386; 6:EG1qvZGy2BrgF5fwjz/5AkjRK4fhMI94JRdw5/z0oTmnP6kMnJzsa1LL9XJ2O/3lvqyxQV30NF3sOTUdL4Kf+hLjKu7z3K7ywv553Oz/wI8tvula5LGuJLhDalt5CUjgjITP9owJuHdBkw9CYQODyEVS3jJ5xZnMS6xPyW/vPYsyAzvJ7VpBlAMjTCihZLOOOfEXcOr4pID3Nv02PymUuOLNwUQuJoYFgLhgb48Q3cr89VeTICAYQdWB1a8L4dQtOhb7NNNJGP67rp0Lizw64MF7kOWLXu1o3NEwavS59fHczNjxBQ3zTSY1pabt6Ei2b/tf4g6k/ndNnNP9I+6/izb++VQ4cghiIEM9E6IHTny1BQ3QJluK/3WKIjfh8/S3I01VQe/9zbtVldbw8oum4P5+Et+merh6oyXS/QSiiq+ZU4d81BEuyYWI+FXDwOMgcDS8/eQzJHv7At8iP6+0Ew==; 5:o2LKccdjy/p5mmKL2mPS+8B+p+CjidcgFu1wVNbljCMBY+Yl9ZgEoVNBAJfpaPpHzF/bC1ocjzAU0tVGZ6sG9l7ThaEcdlkIQepthKMBSf5zuLsCQia+FTvc5M96J7EHgVXZs03LRR/kUmV78igiLPHMwq/jLMwqb5KYhaX89HI=; 24:3lTaeFtL6notxnPXw9R+KuxJBIjsz4zgilfqSM4XxPtOu2qrqUv4p8TyypsmhV0TJ16/PmcEgZsn5UD2s6T7LuT4FE/yn6o350+lW4IBlEw= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; HE1PR04MB1386; 7:gcK7ZxzRNpiDZsIZo4/h02cAKoUL7JaMqZDZ4TFB4mitxY9gwti84Yv5tO8vwrAcAzQGMpTPTatd+MZ3IbUz3t2Pfjth/o0gjzYSgHfKRyXGRoSJnyyrcm4Os5q7w7YoOZyzWdC7/8LABiYqVnMZXtAdaFVknqWy2JKUvUgCkjGTffgh01Ymg/udt3HhssWlwgYC6f08M9eheGIl+Fa+WZL6LFO/BAeE2GYK6ejw49lPk/tExfNX1U2jeqSK5kv9 X-MS-Office365-Filtering-Correlation-Id: 69511b20-9784-456d-b601-08d5b5a4c5df X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2018 12:02:42.9485 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 69511b20-9784-456d-b601-08d5b5a4c5df X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR04MB1386 Subject: Re: [dpdk-dev] [PATCH v3] examples/ipsec-secgw: limit inflight packets count X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 May 2018 12:02:46 -0000 On 5/9/2018 2:28 PM, Radu Nicolau wrote: > Revert previous patch that introduce a performance > degradation in certain scenarios and add a configurable > limit for number inflight packets. > > Revert > commit 84d4b5e4ec48 ("examples/ipsec-secgw: improve IPsec dequeue logic") > Cc: stable@dpdk.org > > Signed-off-by: Radu Nicolau > --- > v3: updated enqueue size trim computation > > examples/ipsec-secgw/ipsec.c | 32 +++++++++++++++----------------- > examples/ipsec-secgw/ipsec.h | 1 + > 2 files changed, 16 insertions(+), 17 deletions(-) > > diff --git a/examples/ipsec-secgw/ipsec.c b/examples/ipsec-secgw/ipsec.c > index ee24973..1929752 100644 > --- a/examples/ipsec-secgw/ipsec.c > +++ b/examples/ipsec-secgw/ipsec.c > @@ -348,13 +348,19 @@ create_session(struct ipsec_ctx *ipsec_ctx, struct ipsec_sa *sa) > static inline void > enqueue_cop(struct cdev_qp *cqp, struct rte_crypto_op *cop) > { > - int32_t ret, i; > + int32_t ret = 0, i; > > cqp->buf[cqp->len++] = cop; > > if (cqp->len == MAX_PKT_BURST) { > - ret = rte_cryptodev_enqueue_burst(cqp->id, cqp->qp, > - cqp->buf, cqp->len); > + int enq_size = cqp->len; > + if ((cqp->in_flight + enq_size) >= MAX_INFLIGHT) This should be ((cqp->in_flight + enq_size) > MAX_INFLIGHT). there Will be one extra operation in case it is equal. Otherwise, Acked-by: Akhil Goyal