From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM05-DM3-obe.outbound.protection.outlook.com (mail-eopbgr730064.outbound.protection.outlook.com [40.107.73.64]) by dpdk.org (Postfix) with ESMTP id 552995689 for ; Mon, 17 Sep 2018 12:38:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5fBGoQQANj/AD3ZgzUSc9AJreRhYe81RStXPExI+sQA=; b=XO/NfLGdFwL+zget47V8s6apcO/+5rnmYsiJlOdZNyHFe6i2hUhaAWdGISe/p/5L/CeBTgJI8PE8he664j5wqXufBxUsTHn1NpL0EMFRNq35FCkJtjdQjlev3dNd4DjYGhDEt6p6ICGrX+iZ2QzZRCE2obRsRudFNrPEKHAgp10= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Anoob.Joseph@cavium.com; Received: from [10.88.100.222] (115.113.156.2) by DM6PR07MB4905.namprd07.prod.outlook.com (2603:10b6:5:a3::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1143.15; Mon, 17 Sep 2018 10:37:56 +0000 To: Akhil Goyal , Anoob Joseph , Pablo de Lara , Thomas Monjalon Cc: Ankur Dwivedi , Jerin Jacob , Narayana Prasad , dev@dpdk.org, Murthy NSSR , Nithin Dabilpuram , Ragothaman Jayaraman , Srisivasubramanian S , Tejasree Kondoj References: <1528476325-15585-1-git-send-email-anoob.joseph@caviumnetworks.com> <1536033560-21541-1-git-send-email-ajoseph@caviumnetworks.com> <1536033560-21541-4-git-send-email-ajoseph@caviumnetworks.com> <5d7c6f9e-5865-a356-e1c2-5a85908055a0@caviumnetworks.com> From: "Joseph, Anoob" Message-ID: <01c58bca-9c17-2ed0-8ebf-83319e456174@caviumnetworks.com> Date: Mon, 17 Sep 2018 16:08:46 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [115.113.156.2] X-ClientProxiedBy: MAXPR0101CA0012.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:c::22) To DM6PR07MB4905.namprd07.prod.outlook.com (2603:10b6:5:a3::10) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 41514d9d-4e48-4866-137c-08d61c89a46e X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989137)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:DM6PR07MB4905; X-Microsoft-Exchange-Diagnostics: 1; DM6PR07MB4905; 3:dKj6x35jrNFsM0QKHb2Ji5o5OjEnS9v8hdyVIXmCiR76UsknDxfNZc1eFqSau9y7pDZT6iAbAjZ+rJb2yZGeiTF37QpldIFkdZ0kvKgcBZEaGrxbiLctdXt5bzJdABJrV3i7kbXUTTinX0EbEyanfv+sWy4yd3QcMpSR8JUcwvM3fHIX7F4A7aQok3TcBPxTR7f50aViRjiSHU0h+P4dwQlA+caScX9jTWI7BdFD8o2LeTqfsOEvSfZKzr1xQI2/; 25:i+IpGHSEtnkHsEVmLjr8bioGySgaPz9XXh6IEjHicURfYCRjltF6DJd/ABhqYVcQm6puG/pKxwa71qQUVRJoBxTFYDmGfJXF0lWG/gdK4QNv18ZS60fe4GhQ7yfhnXOXN6EpcvwUd+wUox77ej9UibtKyTq6sPC8Kmy9+e7WdlVuLvfJS88QJXXOJYWIoGe6Soh9C7tMw38/4UydCp3v+hyA0HPVHzA5f3w1xF+01H0My7QuHzU0g172IHhzsjUUf+76aRU00OfO8i517+5ukFX2FoiiNlOBJZ+PsTQrMEcxVkaHKkDdVBxTq2GNGOplQ9XVvXHvC9oiCRylXCeqZA==; 31:nMzosle1ZIxZ1p6iGR2+fOJI04Q26+OVFarQaq5NqORYK85FKL+HZkVhQP5kr3ave5Suveim3gR7Sbz4J0dfAAGcGqNoam+UxdfzvHZCxT3QLzeBy29N5ufo+GM8fFs/r3DIa98T0Psv0BpsexNvMRHSrHi/4jHZdJzXIoZKbEREEC3+06XLTfnhBeM0inbnEVA6FvADhmDKLbVlIyzvlPxTeMGTZ1Qf1DjlF5ecCng= X-MS-TrafficTypeDiagnostic: DM6PR07MB4905: X-Microsoft-Exchange-Diagnostics: 1; DM6PR07MB4905; 20:XCagelgQQg6A97VBq29Vo+RHyKQadZ8FSuhwWWWC4uPTnLKHZkHSCfvYM6IC5cH5GK9KA8WSvhvSkHTLOQEHzoc+ClB/jgG0mzXTm6YU4UU8fsDhZHktPjO9LMGnj/7FuTJvyESHHi5t0eiwi0OD7Pewe3tjDsyPPExBpQfo6wnjK3HeYuNcL4XQoqVX2gI75QqEV7bYSlPHgvMLJDE2id0DxuHdw5HQGaRX4A48ShQBw53V9zHOQEitLagJKxbc2JZybKVSVZ8BgyOElcy/MoF0b035qYBTnzvqVO6v2EDDmGfvJxWeUbZciMUoWok86393DbqAuHXxuZZdBoN/yZcsb5MQci83hh9r3NTBwllaYYtVXc/BJlUdIj/D41I6Yo+JzkFpRRnNm4AKHDYmvlFSC5Fd7fV06R4k74smb3w+sMEjbnjF5+6huwhFRB9U1SAcfNW7/FfB+J/HTfQ1sukFa1Ae1OhK+gz4qr2ZWRDyr6+N+f+qPQ2TiAIi4KsRL9MKYvb2A0DtX+RV4sp5Rbjh+oAKKy3jM3Fh5R8iCZyNRm++4jfwdLGvamzSOjbLg1ERFaWykB/G2gwKeoVgeACdXCjHx4TwsOtsU78PnbA=; 4:zchgObkwu/RqQt3YaRR41708qtbsrW4xzPixXVsRfCcyEWXgEuGjB3ccLUrAQSHV2Lz2N83M7nRDzdBD1cWfRgpBPaKAZadpeyyBoZRpEvyR5tUhQuQedXaPrEfFhGxKTZ/7BUJxLXkSMpAm0xrVMGyMnVFUllyXVS/fckLaSZbqzcTWIj2A5FhXvxNZ5Xo6Jo5Oh7aJSZ3Th2PgMhH9VY3YGKpqJBMq09m9PtEIu/sAPUtyQfptARhPjwohBKOtEDXV242w1Mtqa4+QfwP0M4xBVIgRo4168mXku0G9PmhGmewiGMbjHtAW/u05t4qv X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(131327999870524); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231355)(944501410)(52105095)(10201501046)(3002001)(93006095)(149027)(150027)(6041310)(20161123564045)(20161123558120)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699050); SRVR:DM6PR07MB4905; BCL:0; PCL:0; RULEID:; SRVR:DM6PR07MB4905; X-Forefront-PRVS: 0798146F16 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6049001)(366004)(39860400002)(376002)(136003)(346002)(396003)(189003)(199004)(486006)(476003)(2616005)(956004)(72206003)(16526019)(97736004)(6246003)(107886003)(47776003)(65826007)(5660300001)(6666003)(31696002)(7736002)(3846002)(3260700006)(25786009)(305945005)(6116002)(4326008)(11346002)(446003)(42882007)(26005)(93886005)(77096007)(478600001)(386003)(53546011)(65806001)(105586002)(8936002)(52146003)(229853002)(54906003)(110136005)(58126008)(2870700001)(68736007)(23676004)(81156014)(53936002)(6486002)(316002)(65956001)(81166006)(76176011)(52116002)(2486003)(50466002)(2906002)(67846002)(16576012)(8676002)(31686004)(64126003)(66066001)(106356001)(36756003); DIR:OUT; SFP:1101; SCL:1; SRVR:DM6PR07MB4905; H:[10.88.100.222]; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTZQUjA3TUI0OTA1OzIzOkxBeEZKSlBUdjZwMmhlRkZkNjF0SC9FRDdw?= =?utf-8?B?TUpqQmdOemFxRnZ2UVJXT2dtREYzNlZjd3I3dXhQRVpMZ0tEcTVYM1BMNnpQ?= =?utf-8?B?cURQTHBUZjdSQlBaamRMZ21YQis1S1oxSWExSCtud1REYWFDL3hyOWxGa2NL?= =?utf-8?B?dk94QXBHVHVQcmRNZ0UwQlEzYTA0YnQxcTVTWTM4dmxYdzJsdEFhOWcrVDJ4?= =?utf-8?B?UXZOYVFjZkZOYjZ4Y3RMcHdzVGlCUXpGdGEzQ3UrMUxlQkZabURUSnR4ZXJj?= =?utf-8?B?cjdqQUhzRE9wSWtjcTZmTW1XMXFJSDJNcUgyN2xKMFVYU3hmSENHWlhvWldV?= =?utf-8?B?N2JiMHZjdGJ5Zk9oTkNuNElFUVlnRlpBazUrNmJtRGxGdzZlT3cwTVJtUTZY?= =?utf-8?B?b2tZYm9acFNwd0QxK2l0YlBMRW5CRUIxL1V0SUZidzAzblR3eUhuOEU3dGlD?= =?utf-8?B?eVVhSEsxTWZVelR5M0VYODJPQ3FyTHVoRGQzNjJQNFZCenlvKzIwbHpSTkcx?= =?utf-8?B?bEhZN2M3Z0U5VmFrOStBSzRLSHBIaEt3dUp4L3VxUFhTdkg0ZEQ5R2tLRmQ0?= =?utf-8?B?NTNSOUNXWER0ZjY0ZWhNZ3hIaXNoRDZISmFKSkw5Ynl6b1Nqd24rRmp0MFBr?= =?utf-8?B?WGlpNW5tRjRUSjFYT1lhZFpRajA1WWd5ZWYxOFNGckNqR1UySVFDK0tNNVdP?= =?utf-8?B?RVhRdndoTmFERHFxMm1MMTJET0hmTzFvajJOZkh3ck9sNktWelRHaGlwRTVG?= =?utf-8?B?WGQxVDBpSENBOVhBQldTRDg3Y1BqTmYwRGZaMnpZTnExNjNvSzZWMkV1VHpq?= =?utf-8?B?N2pabFJHaVFsYzBQSVJrRW1YRDYxcHB1b2dSTEFvK0FzQTR5R3IwRklPZGs3?= =?utf-8?B?RnBnNVhsck4zd2o0cTRYV1dxWEJRK0xqWUUxZ2FEOXF0K3hlVDA5NEhybExX?= =?utf-8?B?U1M2eitoVWt3bXhjLzY2dkFiRDVNdnFlcFQ5OEx6L1lwQysraVFORFNyK1Ni?= =?utf-8?B?NXVHVk9iNTFQOHA0ZUZSNTFaMzNBb29SRGNrWkZNQlF4OHVlLzdqYnhXOUtm?= =?utf-8?B?b0dRWGl5U2ZKbGVvVWxLaHZ2RTFVYnVCakVkQ01WclhqSWQzRERTUGhpVmtk?= =?utf-8?B?UkVMNWJpc3FqalRhUzdlcVBMQmRFMHZteXdSSGhNKy9HSmtOdlQ0dkdicXAx?= =?utf-8?B?cWtzVll6RDBRN2tJRy9OSzBqbytqOVExV3RKNGo3NmtycmZvallMdTBrak9x?= =?utf-8?B?SmFTV2JKZjBucWFQbHdsd0NyMnFhTFRocitZaklvMDFvZzZPbmI1aXhnUU9M?= =?utf-8?B?b0ZhT1FMUmxUaDhyL2Q3S1pmbGhJU1Vsc0JQKzlzMFFnZ3cxU3RVNkhUNk9l?= =?utf-8?B?YlZKLzRRQTFVNEJwMEVBekZJNFBjMmtVNCtsNy9odEJGSCsrZ294bTlQT0F5?= =?utf-8?B?VTJoeVA4N0l2Q3ErblJpQVoyVFFzV05xUysyYjI4eVNIQ0dOMi9sNGdiM09r?= =?utf-8?B?ZEdmNVlvTWI2Y3JBVkZJdGdTRDhrYVc3VE1KNFAvdnFWUjlJeGF5MTNDWEhu?= =?utf-8?B?WXFpMFZKK00rRE5JVEVaWThNcUZ2RmVJNzQ2SGRDR2FGUmxPd2hkdjJ6bFVm?= =?utf-8?B?N0FNdGlIRHZKdE5ieWRHNmxaTE56N2pyaG5KV0tCMEJjbWtxSitDZVJCd1dx?= =?utf-8?B?ckQzTW1lakxmR1RLVjZFQjRxbUxnYXhybDlMb3FMenpQeFVVOWZZRzNQTGlx?= =?utf-8?B?RGNiNG9ycFFhT3VZaXp5RmFPb0lMQ3g3L09sODRSdEphdWhaay9PSFZvRGQ5?= =?utf-8?B?dkk1QXE4ajB4bVJlU3hoRjBoOFBTaElCVDl3TTJ3djVXMHlBM1pyTmgrRVQx?= =?utf-8?B?ck5ydWFBbENpUmZMcEtGWjV1V1k0dXVjQXhqaDJkNEsyaWJ5MmxsV1ArMDJH?= =?utf-8?B?U3pLaDlkMThRTzhIeC8ydUlOM3BEV2VoZXlXM0o0Z0pwSEI4bnBsYit2NU1q?= =?utf-8?B?RmIxTUZreitwMkROTVU1RWM2Y2pVRVBvNnBlTjdpcEtCZTZmWENyVndmTkI3?= =?utf-8?Q?Vu1u3836hIPvTqNh+PKr63VcD?= X-Microsoft-Antispam-Message-Info: frTy/tm2ydijIcclwIL//TDCyTv2G8XiidoBangTnfPA7pnSESB7gzfS/s+2qpJL4hfC3CDfRA+ZFVQV6fg8p/8nr4lJ1FB4c6QJ4XKzPA5tsJW+5It0nXxtr8dcfMd/kofHt/jf6H7d64P8mbawUzfG8j/3G5yzUPfvqv/4dKOPKNCalz/JyPeoVl9souJ+BwT1Be8nw78z6GhxsFc+3m+9/rH3K+vCdWEIOoIoCHawjyeLLCuNimGq/gOCrmXNltqzWDQaBAE1yxima2iBgnCsdEsPs8Y/d7Y/5yVbCSh/RD9jVucae/os13YhE7gvsozl1BDxxddAv8JRHc7ShEV4xaem3XR3AJRyqVMV91w= X-Microsoft-Exchange-Diagnostics: 1; DM6PR07MB4905; 6:zfi73auhfE13hym0LCIr/0obdI+EJcYgV0j/dcNPjA20nczw0oJN8/yioNBehteBrjNTG+YWvCa3UIlTfD9MLpG4pFg/XbtOYOJCyl1e05B+Wi3PrraOIy7/XzadCYAOaOt3JbyZyOUV2BEv1QaerX7JZU2GPXbdBySJg2QytKm8S9Zom8SgOObOiO0v+tSS71Q785I6i6N24akB2cUH2zEU6kCNcpOmQ2dmOsir8LgfOgMTskZwIfnhU7Ztx63VzkSepvKFubk5D/iRbRSlr8GR254k4M2bNEy7Jk993/Kaf5mK5z8goLgo+3QoTloaLPu5HyDpP4swHvcxSSOGFLwrGuHflxQAdIhrI6/93e354wZzWr7S4H/JaeUtvXfIydtvqYwevU/J7Jl2slye+vLqedaytuySuOm1kCCRnxgCUNF4bRYkzGClKRt6DoCmnVQ2FN73jetWdX9hLQaFfA==; 5:lSP54qUhYqZwlgfSR0Wo/wUUM/KSDt8x89g33itbkd8Bwzhldt+heT8ZbY6k4+zOTxJRN7HUKdlFj9IT8A6R7/dS580D0tE9cGqfUZdRPNu/LAVSQ3J8ayjrnS6rO8wEzzMpSuYzSudKFsKr/DuKRSgCTWT9vAd+JiQ8HPNX8yQ=; 7:JfrLHUSbRYzzYR/Pt9ivBkrbq69mH4TuOk61vq5MPfZLQ1zM7PZtd6d3U2rYjbkxEM736Ge2K5FaWA4SgsZQQmSY9SkS/yz5+tOxPgpusfNp+SgrOjgcH/izan8b5fG2eHP4ikTkVwRkEkbFaVTpuX4bwISmHxv284+a5zP7z15rmwhwF97k2jsPd0VPrqah1Mksf1zfu5ERss2x2osfPDxdBgezQhHADW3MTMtyVLLxLlbfCk8/ullIiOEWKCdU SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Sep 2018 10:37:56.7425 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 41514d9d-4e48-4866-137c-08d61c89a46e X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR07MB4905 Subject: Re: [dpdk-dev] [PATCH v2 03/33] crypto/octeontx: add PCI probe and remove X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Sep 2018 10:38:04 -0000 Hi Akhil, On 17-09-2018 16:04, Akhil Goyal wrote: > External Email > >>>> +static struct rte_pci_driver otx_cryptodev_pmd = { >>>> +             .id_table = pci_id_cpt_table, >>>> +             .drv_flags = RTE_PCI_DRV_NEED_MAPPING, >>>> +             .probe = otx_cpt_pci_probe, >>>> +             .remove = otx_cpt_pci_remove, >>>> +}; >>> remove extra spaces/ >> Between otx_cryptodev_pmd, otx_cryptodev_drv & >> RTE_INIT(otx_cpt_init_log)? Which all ones you want removed? > It looks there are 2 tabs for the elements of the above structure.. It > should be a single tab. Understood. Will fix it in v3. Thanks, Anoob