From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 3C3CE3237 for ; Mon, 30 Jan 2017 18:19:22 +0100 (CET) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP; 30 Jan 2017 09:19:21 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,312,1477983600"; d="scan'208";a="53805921" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.38]) ([10.237.220.38]) by orsmga004.jf.intel.com with ESMTP; 30 Jan 2017 09:19:21 -0800 To: Pascal Mazon , dev@dpdk.org References: <20170129021205.36860-1-keith.wiles@intel.com> <2c430141-94c1-5482-7fc2-94f5908b41e0@intel.com> From: Ferruh Yigit Message-ID: <01e6d298-0356-aefd-5e54-4fd73748f890@intel.com> Date: Mon, 30 Jan 2017 17:19:20 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/tap: driver closing tx interface on queue setup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Jan 2017 17:19:23 -0000 On 1/30/2017 2:38 PM, Pascal Mazon wrote: > On 01/30/2017 12:00 PM, Ferruh Yigit wrote:> On 1/29/2017 2:12 AM, Keith > Wiles wrote: >>> The tap driver setup both rx and tx file descriptors when the >>> rte_eth_rx_queue_setup() causing the tx to be closed when tx setup >>> was called. >> >> Can you please describe the problem more. >> Without this patch rx->fd == tx->fd, with this patch rx and tx has >> different file descriptors. >> >> What was the wrong with rx and tx having same fd? >> >> As far as I can see, rte_eth_rx_queue_setup() won't close tx->fd, that >> function will do nothing if rx or tx has valid fd. >> >>> >>> Signed-off-by: Keith Wiles >> >> <...> >> > > Hi, > > The tap PMD recently broke for me because of this patch [1]. > > During init (eth_dev_tap_create()), the tap PMD allocates a shared RX/TX > queue through tun_alloc(). > The recent patch now releases existing queues in rx_queue_setup(), > before adding new ones. > > When rx_queue_setup() is called, it uses close() calls on all shared > queues, effectively deleting the netdevice. > That's the main issue here. > > I tested Keith's patch [2], and it fixes that issue, using separate queues. Thanks for the clarification, and I am adding following patch to patch [2]: Tested-by: Pascal Mazon <...> > > [1] d00d7cc88335 ("ethdev: release queue before setting up") > [2] http://dpdk.org/ml/archives/dev/2017-January/056470.html > >