From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BC2B1A04C7; Mon, 14 Sep 2020 16:29:57 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 91C412BAB; Mon, 14 Sep 2020 16:29:56 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 8101BFFA for ; Mon, 14 Sep 2020 16:29:55 +0200 (CEST) IronPort-SDR: BaD/NOPPLSCPv2tOJgBrg1F+ME4WG5RVAmBUlryPEJuXq9uMBLMnIQpEKMpliG++/cOj2Eq0pO vW9oVG0M88kg== X-IronPort-AV: E=McAfee;i="6000,8403,9744"; a="156478743" X-IronPort-AV: E=Sophos;i="5.76,426,1592895600"; d="scan'208";a="156478743" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Sep 2020 07:29:52 -0700 IronPort-SDR: jb8ZWoS1P0LbyBn+ZM144pSxlEAcagXciSk+6j3CBygpqewv+SCKt/6kTBST8Yb2HYZtlYdAMC iDToNAuuy0CQ== X-IronPort-AV: E=Sophos;i="5.76,426,1592895600"; d="scan'208";a="507162222" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.247.225]) ([10.213.247.225]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Sep 2020 07:29:50 -0700 To: Andrew Rybchenko , Ori Kam , David Marchand Cc: Thomas Monjalon , John McNamara , Marko Kovacevic , "dev@dpdk.org" References: <1596464905-43867-1-git-send-email-orika@mellanox.com> <5b902c08-69b3-905b-3b95-2ce12e94a63b@solarflare.com> From: Ferruh Yigit Message-ID: <01e97737-2fd1-33af-350b-afce9b2dd544@intel.com> Date: Mon, 14 Sep 2020 15:29:47 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.2.2 MIME-Version: 1.0 In-Reply-To: <5b902c08-69b3-905b-3b95-2ce12e94a63b@solarflare.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] doc: update RSS action with best effort X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 8/3/2020 4:55 PM, Andrew Rybchenko wrote: > On 8/3/20 6:49 PM, Ori Kam wrote: >> Hi David, >> >>> -----Original Message----- >>> From: David Marchand >>> >>> On Mon, Aug 3, 2020 at 5:23 PM Ori Kam wrote: >>>>>> + >>>>>> +- Hashing on types that are not supported by the PMD. >>>>> Shouldn't it return error to the caller? >>>>> >>>> That’s depends, if for example the application requested eth and IPv4, >>>> and the PMD can do only IPv4 so according to this, the PMD will just do IPv4. >>> We should have some validation in ethdev to catch this. >>> Is it not the case? >>> >> Like I said in my reply to Andrew, in rte_flow we don't have such caps. >> Maybe we should think about adding them for the RSS case, but again it is tricky >> What if one RSS type is supported depending on the flow or other types? > > Also I'd like to add that ethdev layer is dummy for rte_flow API. > It does not parse pattern/actions etc. May be should change it one day. > As far as I remember not having capabilities was the design decision, PMD does the validation via 'rte_flow_validate()'. Indeed it can be quite complex to have that kind of capability reporting, and without something like that there is not much to do in ethdev layer.