From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B1486A054A; Thu, 11 Feb 2021 11:49:10 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2F5E11CC38A; Thu, 11 Feb 2021 11:49:10 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 9AEAE1CC344 for ; Thu, 11 Feb 2021 11:49:08 +0100 (CET) IronPort-SDR: EFTWMkUhojOPj809UjCclOKUrVQtEqYADaq4A5JsqB7KtLhOJ1qrECj8jSShimRXRdbu9MZ4DP 5XVzsbih/EAQ== X-IronPort-AV: E=McAfee;i="6000,8403,9891"; a="246286816" X-IronPort-AV: E=Sophos;i="5.81,170,1610438400"; d="scan'208";a="246286816" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Feb 2021 02:48:59 -0800 IronPort-SDR: F61dpLgGxy/eB70VFSdfRJKjE9VD0GJb9iMmi2sLFrWWAqSzMOkuzTgsh/eB+cnODCZWQ7x5S8 MZm3mgXz6ITA== X-IronPort-AV: E=Sophos;i="5.81,170,1610438400"; d="scan'208";a="397207009" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.252.21.217]) ([10.252.21.217]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Feb 2021 02:48:58 -0800 To: Renata Saiakhova , Harman Kalra , Bruce Richardson , Ray Kinsella , Neil Horman Cc: dev@dpdk.org References: <20200817140828.9769-1-Renata.Saiakhova@ekinops.com> <20200817140828.9769-2-Renata.Saiakhova@ekinops.com> From: "Burakov, Anatoly" Message-ID: <0218e65e-960c-14f5-a9e4-9b48fa43f444@intel.com> Date: Thu, 11 Feb 2021 10:48:56 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20200817140828.9769-2-Renata.Saiakhova@ekinops.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 1/1] librte_eal: rte_intr_callback_unregister_sync() - wrapper around rte_intr_callback_unregister(). X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 17-Aug-20 3:08 PM, Renata Saiakhova wrote: > Avoid race with unregister interrupt hanlder if interrupt > source has some active callbacks at the moment, use wrapper > around rte_intr_callback_unregister() to check for -EAGAIN > return value and to loop until rte_intr_callback_unregister() > succeeds. > > Signed-off-by: Renata Saiakhova > --- The subject line is too long, suggested rewording: eal/interrupts: add synchronous wrapper around unregister Otherwise, LGTM Acked-by: Anatoly Burakov -- Thanks, Anatoly