From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 63F1C1B1A5 for ; Wed, 20 Dec 2017 15:04:54 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Dec 2017 06:04:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,432,1508828400"; d="scan'208";a="17608950" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga001.jf.intel.com with ESMTP; 20 Dec 2017 06:04:52 -0800 Received: from fmsmsx102.amr.corp.intel.com (10.18.124.200) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 20 Dec 2017 06:04:51 -0800 Received: from fmsmsx117.amr.corp.intel.com ([169.254.3.21]) by FMSMSX102.amr.corp.intel.com ([169.254.10.49]) with mapi id 14.03.0319.002; Wed, 20 Dec 2017 06:04:51 -0800 From: "Wiles, Keith" To: Bin Huang CC: "dev@dpdk.org" , "bin.huang@hxt-semitech.com" , "jie2.liu@hxt-semitech.com" , "bing.zhao@hxt-semitech.com" , "zhiqiang.zhang@hxt-semitech.com" Thread-Topic: [PATCH] pktgen-dpdk: fix low performance in VM virtio pmd mode Thread-Index: AQHTeWkzf3iPPJpPB0yJTHALYWy7cKNMykoA Date: Wed, 20 Dec 2017 14:04:50 +0000 Message-ID: <02AC231F-0D3A-407E-86D0-3517A90CEE9B@intel.com> References: <1513757055-13883-1-git-send-email-huangbin.mails@gmail.com> In-Reply-To: <1513757055-13883-1-git-send-email-huangbin.mails@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.254.0.10] Content-Type: text/plain; charset="us-ascii" Content-ID: <582F79829340DA40898035DCB547ABA3@intel.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] pktgen-dpdk: fix low performance in VM virtio pmd mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Dec 2017 14:04:54 -0000 > On Dec 20, 2017, at 2:04 AM, Bin Huang wrote: >=20 > pktgen pre-allocated TX data in mbuf would be modified by virtio pmd driv= er due to virtio pkt head extension. > it will caused mbuf data_len keep growing, packets size on wire growing, = then tx pps performance drop. >=20 > set corresponding mbuf data_len in pktmbuf reset to fix it. >=20 > Signed-off-by: Bin Huang > Signed-off-by: Bin Huang > Signed-off-by: Bin Huang > --- > lib/common/mbuf.h | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/lib/common/mbuf.h b/lib/common/mbuf.h > index 759f95d..93065f6 100644 > --- a/lib/common/mbuf.h > +++ b/lib/common/mbuf.h > @@ -18,6 +18,7 @@ pktmbuf_reset(struct rte_mbuf *m) > m->nb_segs =3D 1; > m->port =3D 0xff; >=20 > + m->data_len =3D m->pkt_len; > m->data_off =3D (RTE_PKTMBUF_HEADROOM <=3D m->buf_len) ? > RTE_PKTMBUF_HEADROOM : m->buf_len; > } > --=20 > 2.7.4 Thank you for the patch, this maybe the problem a few others have seen. >=20 Regards, Keith