From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3BB354373A; Thu, 21 Dec 2023 07:27:10 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0A50F402EA; Thu, 21 Dec 2023 07:27:10 +0100 (CET) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2071.outbound.protection.outlook.com [40.107.20.71]) by mails.dpdk.org (Postfix) with ESMTP id BDE70402E5; Thu, 21 Dec 2023 07:27:08 +0100 (CET) ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=a08ZpFTSNsgLT9213cYGHJ9tcKHt3xvDgyjzpb7iMYz0PD0TITMj23ZQ+H/DNbHbodUHWcXmyWj2WN2mESlkSOrv1x7KYw+mQgQV/tVS1wIyuL6a87wKICNQt/+7CFOoIOthnFGVNOMAjU9GH4e1A0Fcokl8agSG6QTUOwTaA4nYdvqDm4UpUdhUBnZDtxaaDrHrauWIWPTwru2xbnDWEPp7ThmV+6WJXyI/hAoxv53APueaLW4ouwb0ymE+3rIH6axH12Uo0wtTojLpuETKIAnwCs3X4G81h/kfsJFNKHv08NP2NBorM6K/xV2GWiPLTaFRXv+iB18WBKF7yPRGCg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zkCpgcrouk22VmedKwmbtiGb7eKHNiDTmo+IdkZ+gfE=; b=NyQb5rMASO/+jGuttbzYMuZU0xUepWeQt/OSta8+fzWWfWCSoxReL8CJcJX4Wmmuae2uln04b8T/ddQBbGMcX9j7UglFYW4kC3aS9iRgfjKM5O0hb6C/z4JGDKoHn1gXextAbhcTjS2cG4fl9fcWTr9LZjsNz4cgvOgIU3cHAZD7kFkWaBUC7G0TpmiS2PrLIWZKN52cHOqqFLWfSM6gXbp4abQexPh4EsWDBrdFkS+XMhEcyDroLq2JBNkrdTuNt9K4JACHYuNEaadKVZCs8kDo2uAByvO3x6GMkqScZEb8dSr248CBYIFSD6KdLnYGoOyccT/vUGXIqfrk2lMp8Q== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=dpdk.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zkCpgcrouk22VmedKwmbtiGb7eKHNiDTmo+IdkZ+gfE=; b=kE1xBgJwO/RyhUnavb0HWsLMtyNobGGwwSe+PrVmpAqUCbDtHKosLQMxgqEx18jGa2lbf1kY3ecckxkpD1RnuzCk5DeP8hM3TH478VkVWNpITvR2lpitBszjG9dswiQiOsFGU797KFyIFwNS3RGA5S3XZmWPy5YAEc46afzBxiM= Received: from DB7PR05CA0066.eurprd05.prod.outlook.com (2603:10a6:10:2e::43) by DBBPR08MB5899.eurprd08.prod.outlook.com (2603:10a6:10:208::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.18; Thu, 21 Dec 2023 06:27:07 +0000 Received: from DB5PEPF00014B9C.eurprd02.prod.outlook.com (2603:10a6:10:2e:cafe::b0) by DB7PR05CA0066.outlook.office365.com (2603:10a6:10:2e::43) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.19 via Frontend Transport; Thu, 21 Dec 2023 06:27:07 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5PEPF00014B9C.mail.protection.outlook.com (10.167.8.170) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.14 via Frontend Transport; Thu, 21 Dec 2023 06:27:06 +0000 Received: ("Tessian outbound 385ad2f98d71:v228"); Thu, 21 Dec 2023 06:27:05 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 4f2a14443ff5f480 X-CR-MTA-TID: 64aa7808 Received: from ea22ce47fc0f.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id E4F1F5EA-4199-4399-844C-21AC9CA9F7F3.1; Thu, 21 Dec 2023 06:26:59 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ea22ce47fc0f.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 21 Dec 2023 06:26:59 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AKNta6RFdZ+rNcLJ0N8rTPXDx1YDPRr8jwbEEJVSy9K4JitdqiGbnOqtL3I9/4DVvbfybGutTSwudhTRUNVT/+JZBGhU5rpqaV6mTz8WdkT2LwKuTt/6+WvZbAXxJAh81EeIvFnpxTiTZ02DrNcIiZFDlMsMK3CGPWfF6vufwn3s2rAnNxMlKxjqUqMtoOT5XRnwIyKFQXz26YtITX6zmBFwD+buZq2IO5VV1mLT2QEXpilHCYjtgTiCZbwvxXYzh0QvM4X1DEylexj2trgDUcWTGbDD9wluZ0xx3YK/luFHqJq+BF9ihX/K+STt0APnxGELpe1KADzcIJ1QRRMmgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zkCpgcrouk22VmedKwmbtiGb7eKHNiDTmo+IdkZ+gfE=; b=TULESnng0qj0PK1XYVzJe/V2jPNw2FDom8ggnkuXiFM4loOvLXE6r6s0lueJb10u/d8pqjY/49BTjRY/uasBDIQH3npJIEGAuTH4ZCl+qQ6cR+rmP+xRXuTv2uJnaMQxY0QhL1KcKs4GnGYN55SpFT5ofxPt3voEcJLorPRC7jrrGI+eeOVUvwH0JOuabHuzfI3JW0VryKtypIy0nn9rdXjkJFN5XJs7MykG/hrvyapTsRwhz/p4350AglLbK0KypMh7JJ/6BsFMvsMXpdg0El2ogyOEcryCHmiSnbnAgz2sPEVZPbf+sNpWsNZ6d1H0EPy91DWpOySTSu7ZCkIGdg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zkCpgcrouk22VmedKwmbtiGb7eKHNiDTmo+IdkZ+gfE=; b=kE1xBgJwO/RyhUnavb0HWsLMtyNobGGwwSe+PrVmpAqUCbDtHKosLQMxgqEx18jGa2lbf1kY3ecckxkpD1RnuzCk5DeP8hM3TH478VkVWNpITvR2lpitBszjG9dswiQiOsFGU797KFyIFwNS3RGA5S3XZmWPy5YAEc46afzBxiM= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB7080.eurprd08.prod.outlook.com (2603:10a6:20b:401::19) by DB3PR08MB8964.eurprd08.prod.outlook.com (2603:10a6:10:431::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.18; Thu, 21 Dec 2023 06:26:58 +0000 Received: from AS8PR08MB7080.eurprd08.prod.outlook.com ([fe80::715e:6aad:437c:9e22]) by AS8PR08MB7080.eurprd08.prod.outlook.com ([fe80::715e:6aad:437c:9e22%3]) with mapi id 15.20.7113.019; Thu, 21 Dec 2023 06:26:58 +0000 Message-ID: <02af7a27-2608-4397-a8dd-c4c4d4f6e4ac@arm.com> Date: Thu, 21 Dec 2023 14:26:49 +0800 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 01/13] hash: remove some dead code Content-Language: en-US To: David Marchand , dev@dpdk.org Cc: thomas@monjalon.net, ferruh.yigit@amd.com, bruce.richardson@intel.com, stephen@networkplumber.org, mb@smartsharesystems.com, stable@dpdk.org, Tyler Retzlaff , Yipeng Wang , Sameh Gobriel , Vladimir Medvedkin , Ray Kinsella , Dharmik Thakkar , nd@arm.com References: <20231117131824.1977792-1-david.marchand@redhat.com> <20231220153607.718606-1-david.marchand@redhat.com> <20231220153607.718606-2-david.marchand@redhat.com> From: Ruifeng Wang In-Reply-To: <20231220153607.718606-2-david.marchand@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SG2PR01CA0146.apcprd01.prod.exchangelabs.com (2603:1096:4:8f::26) To AS8PR08MB7080.eurprd08.prod.outlook.com (2603:10a6:20b:401::19) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR08MB7080:EE_|DB3PR08MB8964:EE_|DB5PEPF00014B9C:EE_|DBBPR08MB5899:EE_ X-MS-Office365-Filtering-Correlation-Id: bc5449c1-1ab5-4820-4d30-08dc01edda58 X-LD-Processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: vIJx3corgFyeB9gW23iID7oImEsBKXixyuyQGXoCIm8hPDHnH3PSp7O3UQ0o4KcTaGtN5oNWgg0OFSid/vfuWKSGKMKvwnEo9fD7nPw3Sx6nkBuuDxGOoS6P5yLEu7Vx4KaE4mZjDWILuPXp1xKzjF6q03UKUhD8XN799evwVRZq2bfpNud8UcDL3EvNt4457By/cpUw0UU4GCWXQ6KnKwL8FaIPlOX55vPowXk4qidRZ0nYCIWF7McuBC9xx3CoHtnOt8c2D/pqwKOC7x0ND9iLu2LVtZ1vO1tgmYZNnniKIeIMjkwCNHDLTPYcZoCH+GcasbiO60M1vpBo3Hn5uorpY1TMM7z3iLsNmXhEDs0YRX1m5kYuJgeicAzuEmDWpYoeqojM0ngayCEZFFVbAP1prYSqOMMj2mp/lbFzQZ0BKUI4+EodwSj+4lmtgnsNS89kPsptCRbxQPJCP95P+oOfJxsmskly0WZOned/35ou/nYrvR8t9RUeGDrBVtHW1S5n5Rw8NCjBqFFKgUPJY/GuCIZy1rg5ZImH/SlpLK5oSvZ/znpQKz66/J9E0P7S/7ULX3KbvaCTJIW4RyMWWOZNoCFPKIFCihyVgR/c8TeFMaPo9VdjOk/GOgchl18ncbJADtStg4rD0R8YOEySGeETslnoIMAV8PCAesWK+FTG0lPTWX8XORnNLxdeew+z X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS8PR08MB7080.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(376002)(366004)(136003)(396003)(39850400004)(230373577357003)(230473577357003)(230922051799003)(64100799003)(451199024)(186009)(1800799012)(316002)(8936002)(66946007)(66556008)(66476007)(54906003)(4326008)(8676002)(6486002)(478600001)(31696002)(5660300002)(7416002)(36756003)(41300700001)(2906002)(86362001)(31686004)(26005)(2616005)(83380400001)(6512007)(6666004)(6506007)(53546011)(38100700002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR08MB8964 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5PEPF00014B9C.eurprd02.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 44f17ecc-3535-403a-dba5-08dc01edd54e X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: aQ2GB+G0PIqUVnNtbNpBRoKUW4Plir7/7nbO/S0HQuhKFuwzEfBUVcNTntNa2K/J0+VOJnRKvthweMMysQ0bFLCBMIcTYd3hW1wpPmTRTeO1bTJY4q4zlgQulrI6ZeowWL6nF6co7+djJ37OZCVhMbwkO4cwRNML9mCXjI2S2dkoMVEWmX18VvchHp8AfmSNa5Kr8lkHjSL5T3/jUcIGqF0gVdxwUUXxZhe9WTnFtIavBP/JnSefFmtiddLmr+qmkE5GYmy5Qk+rBU8iM6dmc8mRd9gKkq0alhjMbK//IZvsAh7wawXJZ5Sm0rWtw+Y6uuzPb5hvYJXlD5MUFWRVHiCBZ9a9VCL0hSSm4xtF8ptypu1ajQpsKfLiHffTpyn6WkZ03YYsJdZH9CTgq/9lNcdcLlwl0xsq9Hw3x7jKRaRzeKBKg7h4A9qsuHT9ZoOATZlcr0Fj26ZOx8BGhoKdyfOw3h5hBgwscvkCBDUAN8Dzgx6TBuQp6+AcekTqCF/516yb0ppqcuX8T01PIjp6LrON5QzIODLyEWeDH/AS9T2KD5hBX6GTOSN0NvgYdORZS9CXcHbI4SK0/si01ENrf6AHDbG721crZ/UiY7PerR3wzeNvKB9sGr7znU+wuxZqHW6APVbLJ0zqlQtbWzXiVdXGudNxusF7fpYpKE6X5320FHc0vq9b7M81Y6I39vhbSkuVgJc2hWbXewDrz8t/hoD4D2e2pq+tZr9uM3ePFXsKCeWUNBgvRfa2XrPR4fyrCvESXzAgQ+op2wdzM21ErN1yQw07pYTJwjTDttd4SNozsP06gkrmu1dumKOWZpIc X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230031)(4636009)(396003)(136003)(376002)(39860400002)(346002)(230473577357003)(230922051799003)(230373577357003)(451199024)(82310400011)(64100799003)(1800799012)(186009)(40470700004)(46966006)(36840700001)(31686004)(40480700001)(41300700001)(6512007)(86362001)(6506007)(6666004)(336012)(26005)(53546011)(478600001)(31696002)(40460700003)(2616005)(36756003)(5660300002)(2906002)(8936002)(8676002)(4326008)(6486002)(83380400001)(316002)(70206006)(70586007)(54906003)(450100002)(47076005)(36860700001)(81166007)(82740400003)(356005)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2023 06:27:06.1708 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bc5449c1-1ab5-4820-4d30-08dc01edda58 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5PEPF00014B9C.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB5899 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2023/12/20 11:35 PM, David Marchand wrote: > This macro is not used. > > Fixes: 769b2de7fb52 ("hash: implement RCU resources reclamation") > Cc: stable@dpdk.org > > Signed-off-by: David Marchand > Reviewed-by: Stephen Hemminger > Reviewed-by: Tyler Retzlaff > --- > lib/hash/rte_cuckoo_hash.h | 11 ----------- > 1 file changed, 11 deletions(-) > > diff --git a/lib/hash/rte_cuckoo_hash.h b/lib/hash/rte_cuckoo_hash.h > index f7afc4dd79..8ea793c66e 100644 > --- a/lib/hash/rte_cuckoo_hash.h > +++ b/lib/hash/rte_cuckoo_hash.h > @@ -29,17 +29,6 @@ > #define RETURN_IF_TRUE(cond, retval) > #endif > > -#if defined(RTE_LIBRTE_HASH_DEBUG) > -#define ERR_IF_TRUE(cond, fmt, args...) do { \ > - if (cond) { \ > - RTE_LOG(ERR, HASH, fmt, ##args); \ > - return; \ > - } \ > -} while (0) > -#else > -#define ERR_IF_TRUE(cond, fmt, args...) > -#endif > - > #include > #include > To correct the disclaimer issue. Reviewed-by: Ruifeng Wang