From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-f195.google.com (mail-lj1-f195.google.com [209.85.208.195]) by dpdk.org (Postfix) with ESMTP id 128DE1DA4 for ; Fri, 21 Sep 2018 16:46:04 +0200 (CEST) Received: by mail-lj1-f195.google.com with SMTP id l15-v6so11899320lji.6 for ; Fri, 21 Sep 2018 07:46:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=474A91hhL+fZMD1pUIozRwvin/2iOAYlUbVjHunPxTY=; b=grNG2x1AgEOiUGyspk0FFUfkmB2Yx5lYj+ENTNmPg76eewo/nvyHVj4rhlIZZdWWFu G5C9E6GRhwC/IajSGBZ9BRQyGeLcaR00p5oP06WXIUzEjcCzaaXro5VE+WbKxeqs/1EU DsCmm/Z8ctIUBFFo7QVkWFk07AQIOhVs0Zzh9tntu1uiF8UyaWoHHYNP6qR3/e04TVNN y1jlqaHn66Sr3Af4PZtkjf0tHeICZ4a27V36EBdmJNZXTvkfMomCQM6RmAYZqsNi+D2N ISfNR4XmK94yN+nHux5zpjIXTwfny1PJ0cH8b5ViYazw0shYCcZT69gf6Z/Sv018iIPo n43w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=474A91hhL+fZMD1pUIozRwvin/2iOAYlUbVjHunPxTY=; b=BffRFbSyDjl+Ni2u8/AlZRwF/a5hO/xwe5PprT4MIvOE+OdVHM199Yqx92V5xEynv5 8o3S5Jjkd+vap0Sf4qwXy1K2EvcP/r0NZFZrvdNXEJNYBgN1LNBEQrKqtCSYlcQhkDWH Y08leu5IvwUbIJIFYOlcogsW4A8lPdRZumOggO3s24iujs6w2uCwErg592IUYWx5Jqmx tIahVvt4baZ27R25k8pS5pxtyFPydmvOb3Ce/Ew0U2rGzsZfUJJ/qPkkvytkQ73guzZv HR4iNoi7+kvLd4KYywPxnHuvTXmpP0j3nUp8BSbKJj3jMWbhLizX87c55csTCu5PMR3E nsyw== X-Gm-Message-State: ABuFfohfqrSNQpAd14GEJigt9ZfpVmbqQwSdKr+uyEMlUM0PWs+o0wne pdmwF7vg4kFJI0Exj+ix1iImcQ== X-Google-Smtp-Source: ANB0VdbVnTDF0V1tyeqvunbvTLRkRrQpIxERVZxvK5GhZcfFqvmXQYpUk57M6Msn18HXn0A3Oz3w4A== X-Received: by 2002:a2e:9bc9:: with SMTP id w9-v6mr2117812ljj.33.1537541163562; Fri, 21 Sep 2018 07:46:03 -0700 (PDT) Received: from [10.0.0.72] (31-172-191-173.noc.fibertech.net.pl. [31.172.191.173]) by smtp.gmail.com with ESMTPSA id h90-v6sm5171890lji.66.2018.09.21.07.46.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 21 Sep 2018 07:46:02 -0700 (PDT) To: Akhil Goyal , Tomasz Duszynski , dev@dpdk.org Cc: Nadav Haklai , mw@semihalf.com References: <1535118895-6505-1-git-send-email-tdu@semihalf.com> <1535118895-6505-5-git-send-email-tdu@semihalf.com> From: Andrzej Ostruszka Message-ID: <02bf2f77-0b7a-f0f8-137a-4b246d313164@semihalf.com> Date: Fri, 21 Sep 2018 16:46:01 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 4/6] crypto/mvsam: add support for AES ECB X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Sep 2018 14:46:04 -0000 Akhil This is ECB mode so AFAIU there is no need for IV as this is not feed forward/back type of algo and there is nothing extra needed by the first block (same thing in ccp driver). I'm leaving this as it is (same for 3DES). On 17.09.2018 15:59, Akhil Goyal wrote: > On 8/24/2018 7:24 PM, Tomasz Duszynski wrote: [...] >> + [RTE_CRYPTO_CIPHER_AES_ECB] = { [...] >> + .algo = RTE_CRYPTO_CIPHER_AES_ECB, >> + .block_size = 16, [...] >> + .iv_size = { >> + .min = 0, >> + .max = 0, >> + .increment = 0 >> + } > iv size may not be zero in this case and also in other patch for 3des. > Please check