From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9CC2BA04B1; Wed, 23 Sep 2020 11:35:41 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2B6F81DB83; Wed, 23 Sep 2020 11:35:41 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id CEC291D920 for ; Wed, 23 Sep 2020 11:35:38 +0200 (CEST) IronPort-SDR: 0BnIMD//CBaXA1kjDCdrnc+uv1MCLO8wnz7is/aRK0cc7enf8v/TsZUF3WD7dRlKP8B7Z3H/tg 1cYqDgXQ8+qw== X-IronPort-AV: E=McAfee;i="6000,8403,9752"; a="160122942" X-IronPort-AV: E=Sophos;i="5.77,293,1596524400"; d="scan'208";a="160122942" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Sep 2020 02:35:37 -0700 IronPort-SDR: /nf4l7s++WTLje8388/becG8Ow0q4gHMlslbr213BQuekruCPR6OekjoZOuLjtdy1IEc+VDfYO DXy4/NIn91EA== X-IronPort-AV: E=Sophos;i="5.77,293,1596524400"; d="scan'208";a="305309474" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.218.147]) ([10.213.218.147]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Sep 2020 02:35:35 -0700 To: "Wei Hu (Xavier)" Cc: dev@dpdk.org, Wenzhuo Lu , Beilei Xing , Bernard Iremonger , xavier.huwei@huawei.com, lihuisong@huawei.com, Pavan Nikhilesh , Andrew Rybchenko , "jerinj@marvell.com" References: <20200908021603.44862-1-huwei013@chinasoftinc.com> <20200908021603.44862-2-huwei013@chinasoftinc.com> <689cd203-fa42-bf2a-6821-6065cb760b0b@163.com> From: Ferruh Yigit Message-ID: <02fd6a3c-3810-fbb6-f51d-7c29fc26bfed@intel.com> Date: Wed, 23 Sep 2020 10:35:31 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.2.2 MIME-Version: 1.0 In-Reply-To: <689cd203-fa42-bf2a-6821-6065cb760b0b@163.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 1/2] app/testpmd: update Rx RSS HASH offload when setting MQ RSS X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/23/2020 8:04 AM, Wei Hu (Xavier) wrote: > Hi, Ferruh Yigit > > On 2020/9/23 0:21, Ferruh Yigit wrote: >> On 9/8/2020 3:16 AM, Wei Hu (Xavier) wrote: >>> From: Huisong Li >>> >>> Currently, when starting testpmd application without '--disable-rss' and >>> the number of Rx queue configured is greater than 1, ETH_MQ_RX_RSS flag >>> is set in port->dev_conf.rxmode.mq_mode in testpmd application, and >>> DEV_RX_OFFLOAD_RSS_HASH flag is set in rx_offloads >>> (dev->data->dev_conf.rxmode.offloads) according to the ETH_MQ_RX_RSS >>> flag of rxmode.mq_mode in PMD drivers. >>> >>> However, DEV_RX_OFFLOAD_RSS_HASH is not set to rx_offloads maintained >>> in testpmd application, this will cause the inconsistent problem that >>> rx_offloads is different for testpmd and PMD drivers. >> >> Yes for DEV_RX_OFFLOAD_RSS_HASH, application rx_offload config and PMD >> one diverges, for *some* PMDs. >> >> This is done to have the backward compatibility of the PMD behavior. >> >> The PMDs that would like to write the provide the calculated hash >> value back, overwrites the offload config to enable >> 'DEV_RX_OFFLOAD_RSS_HASH'. And does more work than user requested, >> this shouldn't have any side affect. >> Some doesn't provide the hash unless user explicitly requests it. >> >> Applications shouldn't set it blindly, at least first check if PMD >> supports it but even that case, unless it is needed I think HASH >> offload shouldn't be requested by default. > > OK, we are going to do modification to add check if PMD support > DEV_RX_OFFLOAD_RSS_HASH before setting it as below: > >  @@ -3356,11 +3356,13 @@ init_port_config(void) >            } >            if (port->dcb_flag == 0) { >               if (port->dev_conf.rx_adv_conf.rss_conf.rss_hf != 0) { >                    port->dev_conf.rxmode.mq_mode = >                        (enum rte_eth_rx_mq_mode) >                            (rx_mq_mode & ETH_MQ_RX_RSS); >            if (port->dev_info.rx_offload_capa & >               DEV_RX_OFFLOAD_RSS_HASH) >              port->dev_conf.rxmode.offloads |= >                         DEV_RX_OFFLOAD_RSS_HASH; >              } else >                    port->dev_conf.rxmode.mq_mode = ETH_MQ_RX_NONE; >            } > Hi Xavier, The capability check is correct thing to do, but even in that case I am not sure if we should set the config by default. The reason to extract the 'DEV_RX_OFFLOAD_RSS_HASH' offload is to gain performance for some NICs, enabling it by default defeats the purpose. The offload should be enabled when application needs the provided hash value. I can see you are trying to remove the divergence between PMD and application config, this can be fixed when all PMDs take this user offload request into account instead of overwriting, but for some PMDs it is cheaper to provide the hash value instead of checks, so this divergence is not easy to address.