Re: [dpdk-dev] [PATCH v2 0/5] add dpdk packet capture support for tcpdump

[Pavel Fedin <p.fedin@samsung.com>]

 Hello!

> >  2. What if i don't want separate RX and TX streams either? It only prevents me
> > from seeing the complete picture.
> 
> Do you mean not to have separate pcap files for tx and rx? If so, I would prefer to keep this
> as it is.

 I mean - add an option not to have separate files.

> Because pcap changes need to be replaced with TUN/TAP pmd once available in future.

 I believe it's lo-o-o-ong way to get there... 

> >  3. vhostuser ports are missing. Perhaps not really related to this patchset, i just
> > don't know how much code "server" part of vhostuser shares with normal PMDs,
> > but anyway, ability to dump them too would be nice to have.
> >
> 
> I think this can be done in future i.e. when vhost as PMD is available. But as of now vhost
> is library.

 I expected "server"-side vhost to be the same as "client" part (AKA virtio), just use another mechanism for exchanging control
information (via socket). Is it not true? I suppose, driving queues from both sides should be quite symmetric.

Kind regards,
Pavel Fedin
Senior Engineer
Samsung Electronics Research center Russia