From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id E846E201 for ; Mon, 27 Nov 2017 12:05:21 +0100 (CET) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Nov 2017 03:05:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,464,1505804400"; d="scan'208";a="178215378" Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23]) by orsmga005.jf.intel.com with ESMTP; 27 Nov 2017 03:05:20 -0800 Received: from irsmsx111.ger.corp.intel.com (10.108.20.4) by IRSMSX109.ger.corp.intel.com (163.33.3.23) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 27 Nov 2017 11:05:19 +0000 Received: from irsmsx107.ger.corp.intel.com ([169.254.10.239]) by irsmsx111.ger.corp.intel.com ([169.254.2.30]) with mapi id 14.03.0319.002; Mon, 27 Nov 2017 11:05:19 +0000 From: "O Mahony, Billy" To: "Doherty, Declan" , "dev@dpdk.org" Thread-Topic: [PATCH] cryptodev: Add useful comment to _sym_session Thread-Index: AQHTZjo9lIZZqOJpqUawRfndlLiAhqMoEk3w Date: Mon, 27 Nov 2017 11:05:18 +0000 Message-ID: <03135AEA779D444E90975C2703F148DC58C55818@IRSMSX107.ger.corp.intel.com> References: <1511647837-19170-1-git-send-email-billy.o.mahony@intel.com> In-Reply-To: <1511647837-19170-1-git-send-email-billy.o.mahony@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjIyM2VhYWYtMjZkNy00NzI4LWE1YWEtMzY5NWZjZGZiYzQ3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IjVoTStrN1ZyZE12RVhTZ3FzbFFMa2pManUyc1hGQlpQM05VTGNCdmJianM9In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] cryptodev: Add useful comment to _sym_session X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Nov 2017 11:05:22 -0000 Nacked-by: Billy O'Mahony There are some assumptions about the internals of crypto lib in this commen= t. I'll remove those and submit again. > -----Original Message----- > From: O Mahony, Billy > Sent: Saturday, November 25, 2017 10:11 PM > To: Doherty, Declan ; dev@dpdk.org > Cc: O Mahony, Billy > Subject: [PATCH] cryptodev: Add useful comment to _sym_session >=20 > Signed-off-by: Billy O'Mahony > --- > lib/librte_cryptodev/rte_cryptodev.h | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) >=20 > diff --git a/lib/librte_cryptodev/rte_cryptodev.h > b/lib/librte_cryptodev/rte_cryptodev.h > index dade554..6edb468 100644 > --- a/lib/librte_cryptodev/rte_cryptodev.h > +++ b/lib/librte_cryptodev/rte_cryptodev.h > @@ -890,7 +890,12 @@ rte_cryptodev_enqueue_burst(uint8_t dev_id, uint16_t > qp_id, } >=20 >=20 > -/** Cryptodev symmetric crypto session */ > +/** Cryptodev symmetric crypto session > + * Internally the crytpodev library maintains an association between > +the > + * session and an rte_crypto_sym_xform which is specified as an > +argument to > + * rte_cryptodev_sym_session_create(). Therefore a session has a fixed > +xform > + * chain and each xform has a fixed algo, key, op-type, digest_len etc. > + */ > struct rte_cryptodev_sym_session { > __extension__ void *sess_private_data[0]; > /**< Private session material */ > -- > 2.7.4