* [dpdk-dev] [PATCH] cryptodev: Add useful comment to _sym_session
@ 2017-11-25 22:10 Billy O'Mahony
2017-11-27 11:05 ` O Mahony, Billy
0 siblings, 1 reply; 5+ messages in thread
From: Billy O'Mahony @ 2017-11-25 22:10 UTC (permalink / raw)
To: declan.doherty, dev; +Cc: Billy O'Mahony
Signed-off-by: Billy O'Mahony <billy.o.mahony@intel.com>
---
lib/librte_cryptodev/rte_cryptodev.h | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptodev/rte_cryptodev.h
index dade554..6edb468 100644
--- a/lib/librte_cryptodev/rte_cryptodev.h
+++ b/lib/librte_cryptodev/rte_cryptodev.h
@@ -890,7 +890,12 @@ rte_cryptodev_enqueue_burst(uint8_t dev_id, uint16_t qp_id,
}
-/** Cryptodev symmetric crypto session */
+/** Cryptodev symmetric crypto session
+ * Internally the crytpodev library maintains an association between the
+ * session and an rte_crypto_sym_xform which is specified as an argument to
+ * rte_cryptodev_sym_session_create(). Therefore a session has a fixed xform
+ * chain and each xform has a fixed algo, key, op-type, digest_len etc.
+ */
struct rte_cryptodev_sym_session {
__extension__ void *sess_private_data[0];
/**< Private session material */
--
2.7.4
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] cryptodev: Add useful comment to _sym_session
2017-11-25 22:10 [dpdk-dev] [PATCH] cryptodev: Add useful comment to _sym_session Billy O'Mahony
@ 2017-11-27 11:05 ` O Mahony, Billy
0 siblings, 0 replies; 5+ messages in thread
From: O Mahony, Billy @ 2017-11-27 11:05 UTC (permalink / raw)
To: Doherty, Declan, dev
Nacked-by: Billy O'Mahony <billy.o.mahony@intel.com>
There are some assumptions about the internals of crypto lib in this comment. I'll remove those and submit again.
> -----Original Message-----
> From: O Mahony, Billy
> Sent: Saturday, November 25, 2017 10:11 PM
> To: Doherty, Declan <declan.doherty@intel.com>; dev@dpdk.org
> Cc: O Mahony, Billy <billy.o.mahony@intel.com>
> Subject: [PATCH] cryptodev: Add useful comment to _sym_session
>
> Signed-off-by: Billy O'Mahony <billy.o.mahony@intel.com>
> ---
> lib/librte_cryptodev/rte_cryptodev.h | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/lib/librte_cryptodev/rte_cryptodev.h
> b/lib/librte_cryptodev/rte_cryptodev.h
> index dade554..6edb468 100644
> --- a/lib/librte_cryptodev/rte_cryptodev.h
> +++ b/lib/librte_cryptodev/rte_cryptodev.h
> @@ -890,7 +890,12 @@ rte_cryptodev_enqueue_burst(uint8_t dev_id, uint16_t
> qp_id, }
>
>
> -/** Cryptodev symmetric crypto session */
> +/** Cryptodev symmetric crypto session
> + * Internally the crytpodev library maintains an association between
> +the
> + * session and an rte_crypto_sym_xform which is specified as an
> +argument to
> + * rte_cryptodev_sym_session_create(). Therefore a session has a fixed
> +xform
> + * chain and each xform has a fixed algo, key, op-type, digest_len etc.
> + */
> struct rte_cryptodev_sym_session {
> __extension__ void *sess_private_data[0];
> /**< Private session material */
> --
> 2.7.4
^ permalink raw reply [flat|nested] 5+ messages in thread
* [dpdk-dev] [PATCH] cryptodev: Add useful comment to _sym_session
@ 2017-11-27 11:40 Billy O'Mahony
2017-11-27 11:44 ` Trahe, Fiona
0 siblings, 1 reply; 5+ messages in thread
From: Billy O'Mahony @ 2017-11-27 11:40 UTC (permalink / raw)
To: pablo.de.lara.guarch, dev; +Cc: Billy O'Mahony
Signed-off-by: Billy O'Mahony <billy.o.mahony@intel.com>
---
lib/librte_cryptodev/rte_cryptodev.h | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptodev/rte_cryptodev.h
index dade554..879bd71 100644
--- a/lib/librte_cryptodev/rte_cryptodev.h
+++ b/lib/librte_cryptodev/rte_cryptodev.h
@@ -890,7 +890,10 @@ rte_cryptodev_enqueue_burst(uint8_t dev_id, uint16_t qp_id,
}
-/** Cryptodev symmetric crypto session */
+/** Cryptodev symmetric crypto session
+ * Each session is derived from a fixed xform chain. Therefore each session
+ * has a fixed algo, key, op-type, digest_len etc.
+ */
struct rte_cryptodev_sym_session {
__extension__ void *sess_private_data[0];
/**< Private session material */
--
2.7.4
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] cryptodev: Add useful comment to _sym_session
2017-11-27 11:40 Billy O'Mahony
@ 2017-11-27 11:44 ` Trahe, Fiona
2017-12-11 10:43 ` De Lara Guarch, Pablo
0 siblings, 1 reply; 5+ messages in thread
From: Trahe, Fiona @ 2017-11-27 11:44 UTC (permalink / raw)
To: O Mahony, Billy, De Lara Guarch, Pablo, dev; +Cc: O Mahony, Billy
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Billy O'Mahony
> Sent: Monday, November 27, 2017 11:40 AM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; dev@dpdk.org
> Cc: O Mahony, Billy <billy.o.mahony@intel.com>
> Subject: [dpdk-dev] [PATCH] cryptodev: Add useful comment to _sym_session
>
> Signed-off-by: Billy O'Mahony <billy.o.mahony@intel.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] cryptodev: Add useful comment to _sym_session
2017-11-27 11:44 ` Trahe, Fiona
@ 2017-12-11 10:43 ` De Lara Guarch, Pablo
0 siblings, 0 replies; 5+ messages in thread
From: De Lara Guarch, Pablo @ 2017-12-11 10:43 UTC (permalink / raw)
To: Trahe, Fiona, O Mahony, Billy, dev; +Cc: O Mahony, Billy
> -----Original Message-----
> From: Trahe, Fiona
> Sent: Monday, November 27, 2017 11:45 AM
> To: O Mahony, Billy <billy.o.mahony@intel.com>; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>; dev@dpdk.org
> Cc: O Mahony, Billy <billy.o.mahony@intel.com>
> Subject: RE: [dpdk-dev] [PATCH] cryptodev: Add useful comment to
> _sym_session
>
>
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Billy O'Mahony
> > Sent: Monday, November 27, 2017 11:40 AM
> > To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
> dev@dpdk.org
> > Cc: O Mahony, Billy <billy.o.mahony@intel.com>
> > Subject: [dpdk-dev] [PATCH] cryptodev: Add useful comment to
> _sym_session
> >
> > Signed-off-by: Billy O'Mahony <billy.o.mahony@intel.com>
> Acked-by: Fiona Trahe <fiona.trahe@intel.com>
Applied to dpdk-next-crypto.
Thanks,
Pablo
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-12-11 10:43 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-25 22:10 [dpdk-dev] [PATCH] cryptodev: Add useful comment to _sym_session Billy O'Mahony
2017-11-27 11:05 ` O Mahony, Billy
2017-11-27 11:40 Billy O'Mahony
2017-11-27 11:44 ` Trahe, Fiona
2017-12-11 10:43 ` De Lara Guarch, Pablo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).