From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 76799A04DD; Thu, 22 Oct 2020 11:33:23 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 98403A959; Thu, 22 Oct 2020 11:33:21 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 2B8EA6948 for ; Thu, 22 Oct 2020 11:33:19 +0200 (CEST) IronPort-SDR: eZdlYTD3fkKWxOzZLoW9RKzQd1HrGwNnRqEftTaByEkRuc8p4ZMxJ/6166n0eyob/m/LSFG7VI zHZFxEP8AbAw== X-IronPort-AV: E=McAfee;i="6000,8403,9781"; a="252198156" X-IronPort-AV: E=Sophos;i="5.77,404,1596524400"; d="scan'208";a="252198156" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Oct 2020 02:33:17 -0700 IronPort-SDR: ElLqyIRQ1FpyMWy2b9cc/9CnRH2EVRIDjr+CoBritvbacup5fqVcJgdMrvpNj4R6+S6L9D9qVc TMOa8R1T5Wxg== X-IronPort-AV: E=Sophos;i="5.77,404,1596524400"; d="scan'208";a="533892238" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.248.224]) ([10.213.248.224]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Oct 2020 02:33:15 -0700 To: Andrew Rybchenko , Ray Kinsella , Neil Horman , Hemant Agrawal , Sachin Saxena , Thomas Monjalon Cc: dev@dpdk.org, Xiaoyun Li References: <1603030152-13451-1-git-send-email-arybchenko@solarflare.com> <1603030152-13451-15-git-send-email-arybchenko@solarflare.com> <6e63e0fe-0609-0109-c73e-9ef39e459c82@solarflare.com> From: Ferruh Yigit Message-ID: <03162c0d-d6e7-f72f-1864-f806d4ac938f@intel.com> Date: Thu, 22 Oct 2020 10:33:11 +0100 MIME-Version: 1.0 In-Reply-To: <6e63e0fe-0609-0109-c73e-9ef39e459c82@solarflare.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 14/14] ethdev: remove legacy filter API functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/22/2020 10:12 AM, Andrew Rybchenko wrote: > On 10/20/20 5:52 PM, Ferruh Yigit wrote: >> On 10/18/2020 3:09 PM, Andrew Rybchenko wrote: >>> The legacy filter API, including rte_eth_dev_filter_supported() and >>> rte_eth_dev_filter_ctrl() is removed. Flow API should be used. >>> >>> examples/tep_termination build is broken. >>> >>> Signed-off-by: Andrew Rybchenko >> >> <...> >> >>> --- a/lib/librte_ethdev/rte_eth_ctrl.h >>> +++ b/lib/librte_ethdev/rte_eth_ctrl.h >>> @@ -43,17 +43,7 @@ enum rte_filter_type { >>>    * Generic operations on filters >>>    */ >>>   enum rte_filter_op { >>> -    /** used to check whether the type filter is supported */ >>> -    RTE_ETH_FILTER_NOP = 0, >>> -    RTE_ETH_FILTER_ADD,      /**< add filter entry */ >>> -    RTE_ETH_FILTER_UPDATE,   /**< update filter entry */ >>> -    RTE_ETH_FILTER_DELETE,   /**< delete filter entry */ >>> -    RTE_ETH_FILTER_FLUSH,    /**< flush all entries */ >>> -    RTE_ETH_FILTER_GET,      /**< get filter entry */ >>> -    RTE_ETH_FILTER_SET,      /**< configurations */ >>> -    RTE_ETH_FILTER_INFO,     /**< retrieve information */ >>> -    RTE_ETH_FILTER_STATS,    /**< retrieve statistics */ >>> -    RTE_ETH_FILTER_OP_MAX >>> +    RTE_ETH_FILTER_GET,      /**< get flow API ops */ >>>   }; >> >> Thanks Andrew working on this, >> >> It would be nice to have it in -rc1 to be tested better but it was >> received late for it. >> I suspect there will be more cleanup here or there by time. >> >> Since there will be a new version, >> What do you thinks creating a new dev_ops, like '.flow_ops_get' and >> replace '.filter_ctrl' in this patchset? >> >> This makes the naming/logic more clear, also allows removing a above >> 'RTE_ETH_FILTER_GET'. > > I fully agree, but I'm not sure that I can find time to do it > right now. Got it, it is nice to have if you have time, OK to postpone. > I will move rte_filter_{type,op} enums to ethdev > internal interface in v2 +1 > and the cleanup could be done any time later. > Yes it can be done later, thanks.