From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id AA3F891; Tue, 13 Nov 2018 12:57:07 +0100 (CET) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 7B029400056; Tue, 13 Nov 2018 11:57:06 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 13 Nov 2018 11:57:00 +0000 To: Ferruh Yigit , Thomas Monjalon CC: , , Wenzhuo Lu , "Luca Boccassi" References: <1541642954-37497-1-git-send-email-wenzhuo.lu@intel.com> <20181113111238.80107-1-ferruh.yigit@intel.com> <20181113111238.80107-3-ferruh.yigit@intel.com> <824d74df-bd6d-d974-c6e6-098972081354@solarflare.com> <91793616-688c-0fe8-4850-b426eeb79103@intel.com> From: Andrew Rybchenko Message-ID: <032e013e-6624-9871-7cc7-86363f7c78b1@solarflare.com> Date: Tue, 13 Nov 2018 14:56:56 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <91793616-688c-0fe8-4850-b426eeb79103@intel.com> Content-Language: en-GB X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24218.003 X-TM-AS-Result: No-4.845500-8.000000-10 X-TMASE-MatchedRID: csPTYAMX1+EOwH4pD14DsPHkpkyUphL94+ZcrqvCDkHOxDyJFXIPjva/ u/WjK5O/PkLPiTrkPiIfLxvfma9ooEAtyy4tEzfaY1bQMCMvmn58yGO3dvk8/QJ1vk7thYuGUdf EKc10rU4vQVE0yOGFpYqBZeVCt3Cf0nbjHOkZyPk+W6N2SzBTBwfnX3+9Fm452Yajy1P9W1XSUa Se3PSxAfdoK1MEIGGXeTjw/FyRX6RNfs8n85Te8oMbH85DUZXyavP8b9lJtWoneb0MAqO76SOQp saCFqSL1HakkmFwNHHaJyeKXcGUiAHCFti1weqNuQVpBNdTFOLFUsoOjYzOqU/9WTQ3bF+JxYca x5egE7blC6VYjDr/0qZSiPJ8syVutZqhhmued6dwZAlw9yyoQD2kmCVFuT9AR8Ddj45OYneZJB6 UtR4MgvOptlTzRhSyAvjBvFUX7YjQ453/lGy4VpRMZUCEHkRt X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--4.845500-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24218.003 X-MDID: 1542110227-u4f3Jx_6lVNx Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v4 3/3] ethdev: eliminate interim variable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Nov 2018 11:57:08 -0000 On 11/13/18 2:51 PM, Ferruh Yigit wrote: > On 11/13/2018 11:22 AM, Andrew Rybchenko wrote: >> On 11/13/18 2:12 PM, Ferruh Yigit wrote: >>> `local_conf` variable was needed for offload conversions but no more >>> required. No functional difference, only interim variable eliminated. >>> >>> Fixes: ab3ce1e0c193 ("ethdev: remove old offload API") >>> Cc: stable@dpdk.org >>> >>> Signed-off-by: Ferruh Yigit >> I guess it will be easier to backport the fix if it is the first fix in the series. > I thought this is the less important one and that is why put it as last. Didn't > want this patch cause any conflict while getting other fixes. > > Which patch do you mention to be easier to backport if this is the first, this > one or others? This one. It touches lines which are moved in the previous patch. Not really that important. >> Reviewed-by: Andrew Rybchenko >>