From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com [209.85.212.181]) by dpdk.org (Postfix) with ESMTP id 8E78DA6A for ; Mon, 2 Mar 2015 09:19:51 +0100 (CET) Received: by widem10 with SMTP id em10so12147211wid.0 for ; Mon, 02 Mar 2015 00:19:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:references:in-reply-to:subject:date:message-id :mime-version:content-type:content-transfer-encoding:thread-index :content-language; bh=1UvLlpUVkXm7X5ZXOaefJR7wbJ34c3Rc5gciYxbAf6g=; b=u5dfvjKwGvWn2QIJhuxfKwlvmp4+ztFmwc/PWC0/NeUPMS6OZ0WzUU3a099A90XjqL zM2qICf32CO1RRqaXBZqXX+UNiJvc0uzI+QyKWsk50ItR7nv1wiSErQvWI8IiYANkwBl LVlTsKz/JpNzz3jp2QZT2y5eamp04DcqXgWTDd+0QGb7IBiOYsYbBAM4GWxTZ6aXwm8d TJUqripfOinfTXNHotyHqotrMDGTGdtYh00TUOhB4N4EPYHGol5rP/24bINtnHUH/2ym I0GuvlXxkhBNokjNQas/ur15hxp6b1lrem8wV+blnu6obAz7JBvUUgJdHac/q7X8tqA3 0OWA== X-Received: by 10.194.134.105 with SMTP id pj9mr54655652wjb.143.1425284391393; Mon, 02 Mar 2015 00:19:51 -0800 (PST) Received: from laptop1 (84.95.210.61.forward.012.net.il. [84.95.210.61]) by mx.google.com with ESMTPSA id fu1sm14984962wic.2.2015.03.02.00.19.50 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 02 Mar 2015 00:19:50 -0800 (PST) From: "Raz Amir" To: "'Neil Horman'" References: <1424932400-66862-1-git-send-email-razamir22@gmail.com> <20150301134818.GA31578@neilslaptop.think-freely.org> <031801d0542a$f859d1e0$e90d75a0$@gmail.com> <20150301171646.GA32246@neilslaptop.think-freely.org> In-Reply-To: <20150301171646.GA32246@neilslaptop.think-freely.org> Date: Mon, 2 Mar 2015 10:18:42 +0200 Message-ID: <032e01d054c1$7fc654f0$7f52fed0$@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 15.0 Thread-Index: AQL76vl+o9soqPI/+Wx+6keMGfRa0gE/xKU3A5z257kBrUMSNJp9W60A Content-Language: en-gb Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] pci: save list of detached devices, and re-probe during driver unload X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Mar 2015 08:19:51 -0000 The patch I suggest is in the nic_uio freebsd kernel driver. I don't think that rte_log can be used there. I checked the contigmem freebsd driver and it uses printf. I can either remove those printfs, or keep them. I suggest keeping them as they were very helpful for understanding the flow, and they don't provide too much output (depending on the amount of interfaces connected to the nic_uio driver). How should I continue with this patch? BTW, I don't see it in incoming patches page at http://dpdk.org/dev/patchwork/project/dpdk/list/?page=1 Is it because I missed something in the code contribution instruction? -----Original Message----- From: Neil Horman [mailto:nhorman@tuxdriver.com] Sent: 01 March 2015 19:17 To: Raz Amir Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] pci: save list of detached devices, and re-probe during driver unload On Sun, Mar 01, 2015 at 04:21:10PM +0200, Raz Amir wrote: > Can you refer me to the logging facilities you are referring to for > this Freebsd driver? > device_probe_and_attach is an API in Freebsd kernel which is called > during rte_log and friends. > boot for finding the relevant driver for each device. > I added manual call to it in the driver unload for re-probing and > re-matching the devices that were detached by the driver. > Before this change, you had to reboot in order to get the devices back. > my bad, I didn't see it defined and was thinking it was removed from an earlier version of the dpdk. Neil > -----Original Message----- > From: Neil Horman [mailto:nhorman@tuxdriver.com] > Sent: 01 March 2015 15:48 > To: Raz Amir > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] pci: save list of detached devices, > and re-probe during driver unload > > On Thu, Feb 26, 2015 at 06:33:20AM +0000, Raz Amir wrote: > > Added code that saves the pointers to the detached devices, during > > driver loading, and during driver unloading, go over the list, and > > re-attach them by calling device_probe_and_attach on each device. > > > > Signed-off-by: Raz Amir > > --- > > lib/librte_eal/bsdapp/nic_uio/nic_uio.c | 26 > > +++++++++++++++++++++++++- > > 1 file changed, 25 insertions(+), 1 deletion(-) > > > > diff --git a/lib/librte_eal/bsdapp/nic_uio/nic_uio.c > b/lib/librte_eal/bsdapp/nic_uio/nic_uio.c > > index 5ae8560..7d702a5 100644 > > --- a/lib/librte_eal/bsdapp/nic_uio/nic_uio.c > > +++ b/lib/librte_eal/bsdapp/nic_uio/nic_uio.c > > @@ -55,6 +55,9 @@ __FBSDID("$FreeBSD$"); > > > > #define MAX_BARS (PCIR_MAX_BAR_0 + 1) > > > > +#define MAX_DETACHED_DEVICES 128 > > +static device_t detached_devices[MAX_DETACHED_DEVICES] = {}; static > > +int last_detached = 0; > > > > struct nic_uio_softc { > > device_t dev_t; > > @@ -291,14 +294,35 @@ nic_uio_load(void) > > if (dev != NULL) > > for (i = 0; i < NUM_DEVICES; i++) > > if (pci_get_vendor(dev) == devices[i].vend > && > > - pci_get_device(dev) == > devices[i].dev) > > + pci_get_device(dev) == > devices[i].dev) { > > + if (last_detached+1 > < MAX_DETACHED_DEVICES) { > > + > printf("nic_uio_load: detaching and storing dev=%p\n", dev); No > printfs. Use the logging facilities > > > + > detached_devices[last_detached++] = dev; > > + } > > + else { > > + > printf("nic_uio_load: reached MAX_DETACHED_DEVICES=%d. dev=%p won't be > reattached\n", > > + > MAX_DETACHED_DEVICES, dev); > Dittto > > > + } > > + > > device_detach(dev); > > + } > > } > > } > > > > static void > > nic_uio_unload(void) > > { > > + int i; > > + printf("nic_uio_unload: entered ... \n"); > > + > > + for (i = 0; i < last_detached; i++) { > > + printf("nic_uio_unload: calling to device_probe_and_attach > for dev=%p...\n", > > + detached_devices[i]); > > + device_probe_and_attach(detached_devices[i]); > Where is this defined? It doesn't appear to be in the latest dpdk. > > > + printf("nic_uio_unload: done.\n"); > > + } > > + > > + printf("nic_uio_unload: leaving ... \n"); > > } > > > > static int > > -- > > 2.1.2 > > > > > >