From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
To: Huisong Li <lihuisong@huawei.com>,
dev@dpdk.org, 3chas3@gmail.com, humin29@huawei.com
Cc: david.marchand@redhat.com, fengchengwen@huawei.com,
huangdaode@huawei.com, liudongdong3@huawei.com
Subject: Re: [PATCH] net/bonding: fix bond4 drop valid MAC packets
Date: Sun, 6 Nov 2022 14:01:46 +0300 [thread overview]
Message-ID: <03446e7e-84b8-cffa-01db-8ab22fdf1265@oktetlabs.ru> (raw)
In-Reply-To: <20221019033231.24835-1-lihuisong@huawei.com>
On 10/19/22 06:32, Huisong Li wrote:
> Currently, by default, bond4 will first try to enable allmulti and
> then enable promiscuous if fail to enable allmulti. On reception,
> whether unicast and multicast packets should be dropped depends on
> which mode has been enabled on the bonding interface.
>
> In fact, if MAC address of packets in mac_addrs array of bonding
> interface, these packets should not be dropped. However, now only
> check the default MAC address, which will cause the packets with
> MAC added by the '.mac_addr_add' are dropped.
>
> Fixes: 68218b87c184 ("net/bonding: prefer allmulti to promiscuous for LACP")
> Cc: stable@dpdk.org
>
> Signed-off-by: Huisong Li <lihuisong@huawei.com>
Reviewed-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Applied to dpdk-next-net/main, thanks.
prev parent reply other threads:[~2022-11-06 11:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-19 3:32 Huisong Li
2022-11-06 11:01 ` Andrew Rybchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03446e7e-84b8-cffa-01db-8ab22fdf1265@oktetlabs.ru \
--to=andrew.rybchenko@oktetlabs.ru \
--cc=3chas3@gmail.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=huangdaode@huawei.com \
--cc=humin29@huawei.com \
--cc=lihuisong@huawei.com \
--cc=liudongdong3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).