From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id BED9AA00C4;
	Sun,  6 Nov 2022 12:01:48 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 8227440691;
	Sun,  6 Nov 2022 12:01:48 +0100 (CET)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id 0477E4003C
 for <dev@dpdk.org>; Sun,  6 Nov 2022 12:01:47 +0100 (CET)
Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 85AAE62;
 Sun,  6 Nov 2022 14:01:46 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 85AAE62
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1667732506;
 bh=9tp/odLdUEmzXCcDwKGyLLKegODtKaSsGm064BSwsI0=;
 h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
 b=lOXY3i5Q4jscm/riGc12nAAQIfpMsFuKFEhKl0jbWf6Y9HO7rpIkZI6T5Mv7xo59W
 qov3TBAA7ukjFqmjct29Jps6YWFTP2YGDKumbBSYvoyMROzJuFumzc9lWi5uw5r1I4
 Z4G9giCiXCY14dZ/OV3O9Lnl2uFBjCS2p9qRIHaY=
Message-ID: <03446e7e-84b8-cffa-01db-8ab22fdf1265@oktetlabs.ru>
Date: Sun, 6 Nov 2022 14:01:46 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [PATCH] net/bonding: fix bond4 drop valid MAC packets
Content-Language: en-US
To: Huisong Li <lihuisong@huawei.com>, dev@dpdk.org, 3chas3@gmail.com,
 humin29@huawei.com
Cc: david.marchand@redhat.com, fengchengwen@huawei.com,
 huangdaode@huawei.com, liudongdong3@huawei.com
References: <20221019033231.24835-1-lihuisong@huawei.com>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Organization: OKTET Labs
In-Reply-To: <20221019033231.24835-1-lihuisong@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 10/19/22 06:32, Huisong Li wrote:
> Currently, by default, bond4 will first try to enable allmulti and
> then enable promiscuous if fail to enable allmulti. On reception,
> whether unicast and multicast packets should be dropped depends on
> which mode has been enabled on the bonding interface.
> 
> In fact, if MAC address of packets in mac_addrs array of bonding
> interface, these packets should not be dropped. However, now only
> check the default MAC address, which will cause the packets with
> MAC added by the '.mac_addr_add' are dropped.
> 
> Fixes: 68218b87c184 ("net/bonding: prefer allmulti to promiscuous for LACP")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Huisong Li <lihuisong@huawei.com>

Reviewed-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>

Applied to dpdk-next-net/main, thanks.