From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <mhall@mhcomputing.net>
Received: from mail.mhcomputing.net (master.mhcomputing.net [74.208.46.186])
 by dpdk.org (Postfix) with ESMTP id 1FCB6B34B
 for <dev@dpdk.org>; Thu, 24 Jul 2014 10:13:30 +0200 (CEST)
Received: from android-fb5fc4f6ed62fb42
 (172-3-139-73.lightspeed.sntcca.sbcglobal.net [172.3.139.73])
 by mail.mhcomputing.net (Postfix) with ESMTPSA id 0AB5F80C764;
 Thu, 24 Jul 2014 01:14:21 -0700 (PDT)
User-Agent: K-9 Mail for Android
In-Reply-To: <1454201.eyrodsIZYi@xps13>
References: <1406184149-11531-1-git-send-email-helin.zhang@intel.com>
 <9589603.4uh6CsY5aa@xps13> <20140724080113.GB21277@mhcomputing.net>
 <1454201.eyrodsIZYi@xps13>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain;
 charset=UTF-8
From: Matthew Hall <mhall@mhcomputing.net>
Date: Thu, 24 Jul 2014 01:14:44 -0700
To: Thomas Monjalon <thomas.monjalon@6wind.com>,
 Helin Zhang <helin.zhang@intel.com>
Message-ID: <0344b116-248f-4f64-9ef7-31be52ba8632@email.android.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 3/5] i40e: support selecting hash functions
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 24 Jul 2014 08:13:30 -0000

If no reboot of the card is needed then it's probably better to add it to one of the ethtool style APIs...
-- 
Sent from my mobile device.

On July 24, 2014 1:07:37 AM PDT, Thomas Monjalon <thomas.monjalon@6wind.com> wrote:
>2014-07-24 01:01, Matthew Hall:
>> On Thu, Jul 24, 2014 at 09:59:23AM +0200, Thomas Monjalon wrote:
>> > Is it really a good idea to configure this kind of thing at build
>time?
>> > Maybe yes, I'm not sure.
>> 
>> Whether it's safe to set at runtime probably depends what happens to
>the card 
>> if it gets changed. Do you have to reset the card or the port? Or is
>it OK if 
>> it's more dynamic?
>
>No, we can change configuration with rte_eth_dev_configure() before
>initializing port. So it is truly configurable.
>Requiring recompilation means it's not really configurable between 2
>runs.
>And it breaks binary packaging for Linux distributions.
>
>Many things in DPDK are configured at build time. But we should wonder
>if
>it's really a good design.