From: "WanRenyong" <wanry@yunsilicon.com>
To: "Stephen Hemminger" <stephen@networkplumber.org>
Cc: <dev@dpdk.org>, <ferruh.yigit@amd.com>
Subject: Re: [PATCH v3 19/19] net/xsc: add dev basic stats ops
Date: Sat, 21 Sep 2024 15:15:59 +0800 [thread overview]
Message-ID: <03516c2b-ebba-4c8b-9056-90732cb2152b@yunsilicon.com> (raw)
In-Reply-To: <20240919120417.3eb8cfa9@hermes.local>
On 2024/9/20 3:04, Stephen Hemminger wrote:
> On Wed, 18 Sep 2024 14:09:36 +0800
> "WanRenyong" <wanry@yunsilicon.com> wrote:
>
>>
>> +static int
>> +xsc_ethdev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
>> +{
>> + struct xsc_ethdev_priv *priv = TO_XSC_ETHDEV_PRIV(dev);
>> + uint32_t rxqs_n = priv->num_rq;
>> + uint32_t txqs_n = priv->num_sq;
>> + uint32_t i, idx;
>> + struct xsc_rxq_data *rxq;
>> + struct xsc_txq_data *txq;
>> +
>> + memset(stats, 0, sizeof(struct rte_eth_stats));
> Memset here is unnecessary already done in ethdev.
Thanks for review, will fix it in the next version.
--
Thanks,
WanRenyong
next prev parent reply other threads:[~2024-09-21 7:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-18 6:09 WanRenyong
2024-09-19 19:04 ` Stephen Hemminger
2024-09-21 7:15 ` WanRenyong [this message]
2024-09-19 19:05 ` Stephen Hemminger
2024-09-21 7:21 ` WanRenyong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03516c2b-ebba-4c8b-9056-90732cb2152b@yunsilicon.com \
--to=wanry@yunsilicon.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).