From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A794B459E8; Sat, 21 Sep 2024 09:22:07 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3A13840041; Sat, 21 Sep 2024 09:22:07 +0200 (CEST) Received: from lf-2-34.ptr.blmpb.com (lf-2-34.ptr.blmpb.com [101.36.218.34]) by mails.dpdk.org (Postfix) with ESMTP id 363834003C for ; Sat, 21 Sep 2024 09:22:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=feishu2403070942; d=yunsilicon.com; t=1726903317; h=from:subject: mime-version:from:date:message-id:subject:to:cc:reply-to:content-type: mime-version:in-reply-to:message-id; bh=cKmbS7wzz0hQMok/czbHHvWYTQG4gqtaf2aawhF6pV8=; b=WnmAcplhYR01/iikPBvwqvgv56lU0FS/rwZLuUcldFrMgmbnFlLvRVCJE96xdaS/uaWhc0 ElzlMa1A5AM1zPJKAJYXCNTLRI7uE/V0C2RnZyxHL5c+tM/9uon/icWC3fUIaR+rPTtqhS kDybrOSSoJbJadPNiOFY+saYk8wtonmWDGGs7orc7zJ3T3ixcM+SqcfLx/wZ13KfsFA8n7 5A87FVjYpw2AvK/61XzQoHFrPglaOOTVfSBdqGGNsMCtFTInCyjYSDIpga1+U0X5rAJP08 crDe5HLrGcT/eIUOMKNvhhmBd75bgrkg6mxSBgGHb4I97GX6VYMgSaQosHLdLA== To: "Stephen Hemminger" Subject: Re: [PATCH v3 19/19] net/xsc: add dev basic stats ops Message-Id: <03516c2b-ebba-4c8b-9056-90732cb2152b@yunsilicon.com> X-Original-From: WanRenyong User-Agent: Mozilla Thunderbird In-Reply-To: <20240919120417.3eb8cfa9@hermes.local> Received: from [127.0.0.1] ([114.93.15.93]) by smtp.feishu.cn with ESMTPS; Sat, 21 Sep 2024 15:21:55 +0800 Content-Transfer-Encoding: 7bit Cc: , X-Lms-Return-Path: References: <20240918060936.1231758-20-wanry@yunsilicon.com> <20240919120417.3eb8cfa9@hermes.local> From: "WanRenyong" Date: Sat, 21 Sep 2024 15:15:59 +0800 Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2024/9/20 3:04, Stephen Hemminger wrote: > On Wed, 18 Sep 2024 14:09:36 +0800 > "WanRenyong" wrote: > >> >> +static int >> +xsc_ethdev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats) >> +{ >> + struct xsc_ethdev_priv *priv = TO_XSC_ETHDEV_PRIV(dev); >> + uint32_t rxqs_n = priv->num_rq; >> + uint32_t txqs_n = priv->num_sq; >> + uint32_t i, idx; >> + struct xsc_rxq_data *rxq; >> + struct xsc_txq_data *txq; >> + >> + memset(stats, 0, sizeof(struct rte_eth_stats)); > Memset here is unnecessary already done in ethdev. Thanks for review, will fix it in the next version. -- Thanks, WanRenyong