From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id A331DA00C1;
Mon, 28 Oct 2019 13:12:23 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id D097D1BEE8;
Mon, 28 Oct 2019 13:12:22 +0100 (CET)
Received: from mail-lj1-f196.google.com (mail-lj1-f196.google.com
[209.85.208.196]) by dpdk.org (Postfix) with ESMTP id A8CA81BEE7
for <dev@dpdk.org>; Mon, 28 Oct 2019 13:12:21 +0100 (CET)
Received: by mail-lj1-f196.google.com with SMTP id y3so11074823ljj.6
for <dev@dpdk.org>; Mon, 28 Oct 2019 05:12:21 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=semihalf-com.20150623.gappssmtp.com; s=20150623;
h=subject:from:to:cc:references:message-id:date:user-agent
:mime-version:in-reply-to:content-language:content-transfer-encoding;
bh=FS6/MYaLJa8LvJcSm1Wz5Z/n1ExMNZ+iPxXk/PuHzn0=;
b=UQZBkit7/uUU2CfOKFhRhnn6HV18BkItd0o17/7m4Bl5m7jRK3Ec8y4W3yMTgFRYCb
GjmdXv22Y8GSMVtZSpNE+l4HlEv+tTvIB2ijLxmu7hwuNdVjNKmRnwx//g1u3OelTQ4W
QV3t6E4Faz/0kcYq/7sYXLwi0pPn5K2IlrtcwpM+CKZTKiSz6We7DhGgXZkoQ2x4+QVs
ouolgT4fjh6iSAYHVYYRgkPiOy8bR3PWC/TNzxYw05Z7Todgcj07NgGT0KjRncDahTOt
jZF5TEGzqLJB9Pzrynk0oZArxZL0SsIPqsjEBHOmYXe5o0UCW5yrizqfP8tTkxABKSQ1
4+Tw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:subject:from:to:cc:references:message-id:date
:user-agent:mime-version:in-reply-to:content-language
:content-transfer-encoding;
bh=FS6/MYaLJa8LvJcSm1Wz5Z/n1ExMNZ+iPxXk/PuHzn0=;
b=CMW7ooCtqAMBUsnBn6dvGHNcAFtlhsmS3Pi0x7DgvQCtSDojDeX9sSxKElV3D9RpOu
iihHpkOoxhLEZJzEGuRPIo03DSLNUGGyVvScfRdDjW6pweYEqOFtRbzU24ShTGFGhSvF
n66f2tJZ9TU8ETFyAsMUDFw61uICTPCgyY2Ej6KSxfjxhXLBdNmjIXyJV+iyxVozrG7F
LndxbhoHZfhQlClQ08RaMiUG9YQJWFdy2a8anysp3Dwdo81ntyjJwaFcyrKVMZWEUPGQ
U667mE0GBdNaTp8n0RzI6a4g0qUmDTXQ2c0gqSM4RybMO4EyGLY6v89GowgL3OVXydF9
5ajA==
X-Gm-Message-State: APjAAAUNCcMi6EhOF+A07atQ4YMcJbiA1mM+XbWKjNuVmdaJia6xzdda
P5ubpGtUiUcTZsBq2aQ+wNWJUw==
X-Google-Smtp-Source: APXvYqxZR7A3J1LAXiaJB6DxHhUPlow8chGhrpHlmdWqKmOex3FMIhgT93vgop9kzZ5eO9fYm3j6Rw==
X-Received: by 2002:a2e:9d8d:: with SMTP id c13mr10159864ljj.220.1572264741103;
Mon, 28 Oct 2019 05:12:21 -0700 (PDT)
Received: from [10.0.0.72] (31-172-191-173.noc.fibertech.net.pl.
[31.172.191.173])
by smtp.gmail.com with ESMTPSA id c6sm2313902lji.62.2019.10.28.05.12.19
(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
Mon, 28 Oct 2019 05:12:20 -0700 (PDT)
From: Andrzej Ostruszka <amo@semihalf.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, Ray Kinsella <mdr@ashroe.eu>,
Aaron Conole <aconole@redhat.com>, Michael Santana <msantana@redhat.com>,
John McNamara <john.mcnamara@intel.com>,
Marko Kovacevic <marko.kovacevic@intel.com>,
David Hunt <david.hunt@intel.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Vladimir Medvedkin <vladimir.medvedkin@intel.com>,
Robert Sanford <rsanford@akamai.com>,
Erik Gabriel Carrillo <erik.g.carrillo@intel.com>,
mattias.ronnblom@ericsson.com, stephen@networkplumber.org
References: <20190917075754.8310-1-amo@semihalf.com>
<20190917075754.8310-2-amo@semihalf.com>
<8ba7ce2f-e687-3e1c-c7ab-7749764e80d8@ashroe.eu> <1775281.ulgepI6dQ0@xps>
<ca0ed170-fde4-fc41-bbf0-6543c23c4d8e@semihalf.com>
Message-ID: <035707a2-fedd-6d57-af81-f4942e90f677@semihalf.com>
Date: Mon, 28 Oct 2019 13:12:19 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <ca0ed170-fde4-fc41-bbf0-6543c23c4d8e@semihalf.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v2 01/10] build: add an option to enable LTO
build
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On 10/28/19 9:36 AM, Andrzej Ostruszka wrote:
> On 10/27/19 12:31 PM, Thomas Monjalon wrote:
[...]
>> Should we document its use in rte_function_versioning.h
>> and versioning.rst?
>
> Yes, I think so. I'll add that.
One quick notice. There is a slight mismatch between documentation of
VERSION_SYMBOL/BIND_DEFAULT_SYMBOL and their implementation i.e. the
docs claim that the underscore is added by these macros (b_e) while it
is currently being supplied at the macro invocations.
I'll try to update docs to match the header but if you'd like to change
it the other way* please let me know.
Regards
Andrzej
[*] Change the implementation of these macros to use:
... RTE_STR(b) "_" RTE_STR(e)
and remove underscore from all invocations of these macros.