From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5F72142C10; Fri, 2 Jun 2023 15:10:22 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EA65840ED8; Fri, 2 Jun 2023 15:10:21 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 7C8B4406B8 for ; Fri, 2 Jun 2023 15:10:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1685711419; x=1717247419; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=FWthQjcTEPeSLvzryPCXy1o9owwPi/pZHovT7+l8xoE=; b=QjSpbi6V/oguqtpolYcM4KxnW+sGYweqy5Rmpybkd4FQ4uZQ7NOVMkGS MPErypKF+0D6x+aHNYDijmHuuoIuxtk1jrHOCyhKfzg3qaczO3UXGimoD PcD6oKpcj8yP7aIg7zn/NtFAPknpjkf2IVm/cMBr+HDBvlrwv4ySZ8zVw xq/KPoWtjML5BDBDk3ck0jaEzlAUfHsHA9WXgzgGEVhzyRBkFOHoKnnfd pIL5dpw/M4LiU9pA5dQ+gL4/jgmg8UdpCT9D+kvJliaGohQE4AYje0tuQ +TW0IWaIj1QmwT7YsOJrPKhPaqMTMDQcEAjpMYgPSri08hn70fF8vKFS4 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10729"; a="340491330" X-IronPort-AV: E=Sophos;i="6.00,213,1681196400"; d="scan'208";a="340491330" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jun 2023 06:10:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10729"; a="707850499" X-IronPort-AV: E=Sophos;i="6.00,213,1681196400"; d="scan'208";a="707850499" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga002.jf.intel.com with ESMTP; 02 Jun 2023 06:10:18 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Fri, 2 Jun 2023 06:10:18 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Fri, 2 Jun 2023 06:10:18 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.101) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Fri, 2 Jun 2023 06:10:17 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gjXc5prYy+XTI+HRCIngtw3WobTw1q3kBnn1bL9/AM727ig1ZpDu16AlQEkczajRbkYa2GLhW5uRgngZl3f8ckqT/deZM/uqXxvzfBTH90fSJylpuSnUyUJUt8M7kc5WmuLk+N+WSv28RaMZQW+dLZu1idL+FjLBhMnUuYVA1ArXT4ADyzYCkuXyt+90kP0J+SgPdA4oq68reK1d3V/Iud4adt4vU6UPHPSYoeug/ociWu6c8DildQ5mtii3q5CTyRTQMD5vZOZUIe276b3B1W5I+3oftHCIRWDFK4Ftw4PYJ42cUtOkIotGXcDI4EiXNapHWP7q1B9MmbbFDtGgrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VUwnz37Lkl//d55/m04bKNRLz5CiXucWuhQCe2hfrBo=; b=Z6675fOttJFzGucjSyr8LFLFXbzcjEhyVBWSx8kwcbdMvwWKXmxf96UB3TuYU4f0okmUo8W5bvnYcpRyDU0aCdhOS9iGmpzGJi+RA+S+IT9tYAsz+053VTGwm9GGJSM4DNF4ER2dIKHAdHfgBZ2REGxO9URIa3RhpKTtAOTVW5kqehnWO3ZXnG6okG0Y2MaYKWyOX/rGZRkAaOXnMFxSah8OFj8I7AmtmDYc1uho7QEOB3DKvw/5nmv+DjgZVhFu1yqtoTyi3/iKbwD4c4TRr3fW0a3Hfisst0MZ8JKyhNSZlIxvViu8fLR2IHdbq5kgr/zAQ0mjRO7L9MzA7xdmUQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DM4PR11MB6502.namprd11.prod.outlook.com (2603:10b6:8:89::7) by SA2PR11MB4810.namprd11.prod.outlook.com (2603:10b6:806:116::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.22; Fri, 2 Jun 2023 13:10:14 +0000 Received: from DM4PR11MB6502.namprd11.prod.outlook.com ([fe80::49c0:aa4c:e5b4:e718]) by DM4PR11MB6502.namprd11.prod.outlook.com ([fe80::49c0:aa4c:e5b4:e718%7]) with mapi id 15.20.6455.020; Fri, 2 Jun 2023 13:10:14 +0000 Message-ID: <0376667b-7b39-9e3f-c176-e8176226e3af@intel.com> Date: Fri, 2 Jun 2023 14:10:09 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.11.1 Subject: Re: [External] Re: [PATCH] eal/linux: register mp hotplug callback after memory init To: =?UTF-8?B?546L5b+X5a6P?= CC: , References: <20230531065506.63021-1-wangzhihong.wzh@bytedance.com> <76dfde52-62ab-5497-194c-c49f6a4cc95c@intel.com> Content-Language: en-US From: "Burakov, Anatoly" In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0251.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:350::19) To DM4PR11MB6502.namprd11.prod.outlook.com (2603:10b6:8:89::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR11MB6502:EE_|SA2PR11MB4810:EE_ X-MS-Office365-Filtering-Correlation-Id: 632b0802-072c-4bbf-8aa2-08db636ab407 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PMoKrEwMERLs8Ou0ptMkAzS18pC0XyZOTv+0r7qw31lmtmhn5jds3teeQZMC64sC87ortV9+qT+Dfoz9/2BrMh68VIt77yBSy8ta4lmV3fwX/IJgcoy3QSlquUGtEnbA1MOsJJjrNsCLM6FMCWqfvjmN4jaBdiiWVhsSqA22tAOIxDEEnCzxkh004xug8+HfC9RsnCGa+47faYj8TAzqDHgGl9qbc7GVuYbE5/aMywwEbBrjQJg9+top3fCTKqG0mX1DVdEVUEz5zX/9/7Lg1hkNQUaPjcpdfWcBxExpaFEDFkFofmia77xcsvFHwhfFpzT0cQ9iJnlaQ9O7BH8TIEhZZBgr6z6ajfeI+JrcjgpXOlo42p+kQ+xKwV82MaTYPLJyrDnyNKE8G3ukltxFI+/cHDhPEAImqfMKHAISsc7vx9MMhUEeTWEqiqVyFeskhXcd3UkBGzSilLe8xssg9FSPiG+KzaCgkP3GdDSt7wXS279f+C9tNRLlTQCupXCwZLeWUa0fJoXXfF2D7TLwyvT5dEDL1ToRlSE+vSA3RZHM8DnfY2GJmodHuTKIek43RfLrUcnUVnu5jIyFccn8Ein2aCnXCYll7Fs2/+zq4IhMkIF0VMmez8ayGAKrGATFVbdEtGN4uGMwHAh8dNyNJA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB6502.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(376002)(346002)(396003)(39860400002)(366004)(136003)(451199021)(6666004)(107886003)(6486002)(38100700002)(36756003)(31696002)(2616005)(83380400001)(82960400001)(86362001)(53546011)(6512007)(6506007)(26005)(186003)(66556008)(6916009)(66946007)(66476007)(2906002)(4326008)(316002)(8936002)(8676002)(31686004)(41300700001)(478600001)(5660300002)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OVpWRmtLWWtMVzlTZUNtSkJjUFBTMFFEOXZOdnQvU2pSRHdHaGszN1hsSUly?= =?utf-8?B?czYwQUEyVlhqRStvOGxGaEUxMVZlQ3JxaCtJVENORjJDSHJjSDVaZlhScUpM?= =?utf-8?B?ZmZZU1RnWHJoamxHOFVJZmFDa0pXZ2JhdWw4QWZTTTVNN0s3L1BKK2xIL3lS?= =?utf-8?B?WUpkWE1UZU03Yi9ETGlvY0xFK0txMXBLYVROb1VKZ293VlhyOTBvVDBhc0Rq?= =?utf-8?B?Q0JDMXB6Rng3clJpY2ZUK2ZocmhMU3dualE3U2NyM1VxV3kxNFZmWWhVUVFC?= =?utf-8?B?MGFnVENCWDNYU2pIblo4S1BMN1NLQngzL3JWeUQ4N1hTOEpSSU1SV1NUamFW?= =?utf-8?B?bWFuWDI3UWJnNGRNZm04ckhZejVmLy9xVGlSRFZPUnpFWUZoeFlrS3BhYlhU?= =?utf-8?B?TTZoSEpGS3pISE5vS3F1NUxUcWp4QVI3V2cxc0NkUVk0c1VWYzRmUDBNQzVP?= =?utf-8?B?aXI0eXRHT0NLMExZenBzb0t4NUtuM2VPTXk5bm1VQ29pRFZGUkVnYlZkNEdO?= =?utf-8?B?N1B6MEdVcUg1L1VrOG5UclZIYjFpUVF2OThuZEVHWHR3VXdYakd1Y3pNcVpN?= =?utf-8?B?dkwwc1VWVC8wQUpHR2hZZ0Z6V0pSWkRsUGhCZUlqbjgvOFRReGRtNzgzV3Fj?= =?utf-8?B?U3p2cXIyaVFSWFNYVC8rQU1yR2ZQSFRYQUNkV2hYdG5tMDRhbWhYZFErcFhl?= =?utf-8?B?ZjVSWEVaVVVYNnZKNSs3YTNocDJlUllCUDdtQ1ZQNlQwT05XSDFUY3Vwcllz?= =?utf-8?B?amdOQ2I0TW9WRERNWDVZaUhuenpTOGFYRTQydXhua2ZMVm1PYWFOc1NCWkRY?= =?utf-8?B?ZHFRdUlOV0VXTk1RWDBSS3JRbjNHODNBdUtjVmtLUUg0Y2REQnpiamFJSkRZ?= =?utf-8?B?NWcweGM4L1N1K0Q4ci9vTjR2c1FYT2RLRm1iRHg5V0hMZzBzaWNxMGNFSVBF?= =?utf-8?B?MzFIWmwxa3NtcTgwdW0vSjdXTUJtYlpGaFgvdjNlTlF4YjdyOW5RcHQ1SzNO?= =?utf-8?B?d21kR05vMGIwSXFUN2hUclV5V01iendUckFLR2theEhqUjRwcTlxOGZFeEpi?= =?utf-8?B?UlgyZDRPdUJNLzJOM3RYaWpVbzlyM3hTOHNiTVFyWG95SlkydHRvWVF1OTRF?= =?utf-8?B?WkhGald6SDkray94ZmNyd3NPc2Vwdy9OZUliQmdBejZ4UHFTWnhtVExJaUh5?= =?utf-8?B?T1NCWDlGWHI5V0ZPelNrNTRBblFKOVRWamY5OEVTbmpycGFCNk91SjRtN0dx?= =?utf-8?B?d2VkMVRWeDBIbkMvc0kzZFpBRlJOZytUQklTSzNpSzdrdTZUUmpHZVZPZnF6?= =?utf-8?B?UWpvejluaTFLaC9oejdObFpseVN4YlF4VkRWd3FMYkxqdklQdjZ1cXYxQUN2?= =?utf-8?B?QzFuQnNHRVBRSWMyaVUvbkN0WGluUE83MTl6RU4rR3FBVFNRWkN5ZmRMT1RN?= =?utf-8?B?WE4xTXc5QW1abHB5N00wenU5dkFsL1JNOFM2ZlhPMG9oZDhFbTdiSG5TQWZH?= =?utf-8?B?c0JVMUhVL3VzL1Q5MSs3WjV0VGE4NjZRLzd5MCtHZUJvNVU4cEJNbWhheTNu?= =?utf-8?B?RzhtdVRZWlM2WmFneEdqb043UUluYVc5L01Jc3FHdVdXWGRVVlpFR2s1dHV3?= =?utf-8?B?cWdraVJUSDBCb01VQ0paUFJmMmJLVEpEak9rOFdGZTFERWFnT2dZNkpWNjRE?= =?utf-8?B?UjdRY0NQWWhWejhCTC9VdEpCRlhBcWhmeUVDQ0hCc2FNbmdyVDlJZG5FU3RE?= =?utf-8?B?RWhrNER6VkIxVVBlR3QvWmFidlh6UnFwWHRWMndQY3dTMXhZa1J4SFUxTXRQ?= =?utf-8?B?VUJDWHY2WDlkTkRPK05rYjA3bFV4NTF0L3hBbWhBYmpMNGdRa0FJajN0Z2ds?= =?utf-8?B?M2JtQmRiV3JIOWVDS0Y5Rk9ERHdDcU9Xa0ZMa0J4bHZnZi9QQ0F4RUM0L1Zq?= =?utf-8?B?OTY1cFdnakJ2NnZ2cTVidm1yejNpZDk1RGpDY3MwMzhEbGFueVFuaVFTUXZ4?= =?utf-8?B?ZFRTdytqSHZpcm8vV0hXMGdTMUpXZ1dkM25PSXNuZ1N1eVVLdnZ1dGJkTW1h?= =?utf-8?B?cjJTdXp4TDU4d1pnUUVUSUg4UUtEMU80bFkxRUNPejJjVmh6T1F2UVhvbjNS?= =?utf-8?B?NlZQckh2eW55d3EzRkdMcFkyREd3bjJhQ0hRN28vQnYvUytNenpsUHllWmR5?= =?utf-8?B?eUE9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 632b0802-072c-4bbf-8aa2-08db636ab407 X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6502.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jun 2023 13:10:14.3081 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jGtCtpbOpI5N+SNP12j4anvhqcctihMtO3ZDIcHwTgemNk4rVcln+uaj2kU5CkLsXoi4/hY+B29eiV6qZ9FhRsK1Ag8OAx8vJ/JZfyHr5ZY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4810 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/2/2023 4:33 AM, 王志宏 wrote: > Apologize that I have to go directly to function names to explain :) >   - rte_eal_intr_init creates eal_intr_thread_main which starts > eal_intr_handle_interrupts >   - rte_mp_channel_init creates mp_handle which processes messages > registered by rte_mp_action_register >   - then, eal_mp_dev_hotplug_init calls rte_mp_action_register to > register handle_primary_request for EAL_DEV_MP_ACTION_REQUEST > > At this point the whole messaging mechanism starts to function: When > primary attaches/detaches devices, it sends EAL_DEV_MP_ACTION_REQUEST, > and handle_primary_request invokes __handle_primary_request, which > calls local_dev_probe/remove. In the end it goes to for > example rte_eth_dev_attach_secondary. > > Now, if secondary is somewhere after eal_mp_dev_hotplug_init but before > memory init done, it will crash due to memory access violation. > > Thanks > Zhihong Hi, I went into the code for IPC and you're right: we're only ignoring requests from *unregistered* callbacks, but if they were already registered, we handle them, which would cause your issue. -- Thanks, Anatoly