From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: Jianbo Liu <jianbo.liu@linaro.org>
Cc: "Zhang, Helin" <helin.zhang@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>,
"jerin.jacob@caviumnetworks.com" <jerin.jacob@caviumnetworks.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 1/5] i40e: extract non-x86 specific code from vector driver
Date: Thu, 13 Oct 2016 11:58:15 +0000 [thread overview]
Message-ID: <039ED4275CED7440929022BC67E706115065BAE4@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <CAP4Qi3_a2dNfZ=0kTfk-+4MQjJ-rffmp3hq_LRh3vVMXH=H6qw@mail.gmail.com>
Hi Jianbo
> -----Original Message-----
> From: Jianbo Liu [mailto:jianbo.liu@linaro.org]
> Sent: Thursday, October 13, 2016 11:00 AM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: Zhang, Helin <helin.zhang@intel.com>; Wu, Jingjing
> <jingjing.wu@intel.com>; jerin.jacob@caviumnetworks.com; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 1/5] i40e: extract non-x86 specific code from
> vector driver
>
> On 12 October 2016 at 10:55, Zhang, Qi Z <qi.z.zhang@intel.com> wrote:
> > Hi Jianbo
> >
> >> -----Original Message-----
> >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jianbo Liu
> >> Sent: Wednesday, August 24, 2016 5:54 PM
> >> To: Zhang, Helin <helin.zhang@intel.com>; Wu, Jingjing
> >> <jingjing.wu@intel.com>; jerin.jacob@caviumnetworks.com;
> dev@dpdk.org
> >> Cc: Jianbo Liu <jianbo.liu@linaro.org>
> >> Subject: [dpdk-dev] [PATCH 1/5] i40e: extract non-x86 specific code
> >> from vector driver
> >>
> >> move scalar code which does not use x86 intrinsic functions to new
> >> file "i40e_rxtx_vec_common.h", while keeping x86 code in
> i40e_rxtx_vec.c.
> >> This allows the scalar code to to be shared among vector drivers for
> >> different platforms.
> >>
> >> Signed-off-by: Jianbo Liu <jianbo.liu@linaro.org>
> >> ---
> ...
> >
> > Should we rename the function "_40e_rx_queue_release_mbufs_vec" to
> > "i40e_rx_queue_release_mbufs_vec_default", so functions be wrapped
> can follow a consistent rule?
>
> I think these two ways are different.
> For func/_func, _func implements what func needs to do, they are same.
> We needs _func inline, to be called in different ARCHs.
> But for func/func_default, func_default is the default behavior, but you can
> use or not-use it in func.
Got your point, I also saw ixgbe is implemented in the same way.
Thanks!
Qi
next prev parent reply other threads:[~2016-10-13 11:58 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-24 9:53 [dpdk-dev] [PATCH 0/5] i40e: vector poll-mode driver on ARM64 Jianbo Liu
2016-08-24 9:53 ` [dpdk-dev] [PATCH 1/5] i40e: extract non-x86 specific code from vector driver Jianbo Liu
2016-10-12 2:55 ` Zhang, Qi Z
2016-10-13 3:00 ` Jianbo Liu
2016-10-13 11:58 ` Zhang, Qi Z [this message]
2016-08-24 9:53 ` [dpdk-dev] [PATCH 2/5] i40e: implement vector PMD for ARM architecture Jianbo Liu
2016-08-26 14:20 ` Thomas Monjalon
2016-10-12 2:46 ` Zhang, Qi Z
2016-10-13 2:19 ` Jianbo Liu
2016-08-24 9:53 ` [dpdk-dev] [PATCH 3/5] i40e: enable i40e vector PMD on ARMv8a platform Jianbo Liu
2016-08-24 9:53 ` [dpdk-dev] [PATCH 4/5] i40e: make vector driver filenames consistent Jianbo Liu
2016-08-24 9:53 ` [dpdk-dev] [PATCH 5/5] maintainers: claim i40e vector PMD on ARM Jianbo Liu
2016-08-24 10:49 ` [dpdk-dev] [PATCH 0/5] i40e: vector poll-mode driver on ARM64 Thomas Monjalon
2016-08-24 13:30 ` Shreyansh Jain
2016-08-26 6:42 ` Jianbo Liu
2016-09-19 16:25 ` Bruce Richardson
2016-10-04 8:24 ` Thomas Monjalon
2016-10-14 3:59 ` [dpdk-dev] [PATCH v2 " Jianbo Liu
2016-10-14 4:00 ` [dpdk-dev] [PATCH v2 1/5] i40e: extract non-x86 specific code from vector driver Jianbo Liu
2016-10-14 4:00 ` [dpdk-dev] [PATCH v2 2/5] i40e: implement vector PMD for ARM architecture Jianbo Liu
2016-10-14 13:26 ` Jerin Jacob
2016-10-14 4:00 ` [dpdk-dev] [PATCH v2 3/5] i40e: enable i40e vector PMD on ARMv8a platform Jianbo Liu
2016-10-14 13:28 ` Jerin Jacob
2016-10-14 4:00 ` [dpdk-dev] [PATCH v2 4/5] i40e: make vector driver filenames consistent Jianbo Liu
2016-10-14 4:00 ` [dpdk-dev] [PATCH v2 5/5] maintainers: claim i40e vector PMD on ARM Jianbo Liu
2016-10-17 14:44 ` [dpdk-dev] [PATCH v2 0/5] i40e: vector poll-mode driver on ARM64 Bruce Richardson
2016-10-19 9:20 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=039ED4275CED7440929022BC67E706115065BAE4@SHSMSX103.ccr.corp.intel.com \
--to=qi.z.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=jianbo.liu@linaro.org \
--cc=jingjing.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).